[{"id":18055,"web_url":"https://patchwork.libcamera.org/comment/18055/","msgid":"","date":"2021-07-09T13:46:30","subject":"Re: [libcamera-devel] [PATCH v5 8/8] ipa: raspberrypi: Make\n\tvariable names consistent","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 09/07/2021 10:56, Naushir Patuck wrote:\n> s/DefaultAnalogueGain/defaultAnalogueGain/\n> s/DefaultExposureTime/defaultExposureTime/\n> \n> Change these for consistency with the other static const variables.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 8fb98a49da63..1dd7fd68c3e9 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n> using utils::Duration;\n> \n> /* Configure the sensor with these values initially. */\n> -constexpr double DefaultAnalogueGain = 1.0;\n> -constexpr Duration DefaultExposureTime = 20.0ms;\n> +constexpr double defaultAnalogueGain = 1.0;\n> +constexpr Duration defaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> constexpr Duration defaultMaxFrameDuration = 250.0s;\n> \n> @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n> \t\t/* Supply initial values for gain and exposure. */\n> \t\tControlList ctrls(sensorCtrls_);\n> \t\tAgcStatus agcStatus;\n> -\t\tagcStatus.shutter_time = DefaultExposureTime;\n> -\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n> +\t\tagcStatus.shutter_time = defaultExposureTime;\n> +\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \n> \t\tASSERT(controls);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1C74C3224\n\tfor ;\n\tFri, 9 Jul 2021 13:46:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 580DA684E7;\n\tFri, 9 Jul 2021 15:46:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEC4F605AC\n\tfor ;\n\tFri, 9 Jul 2021 15:46:33 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7536AE7;\n\tFri, 9 Jul 2021 15:46:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DrjAwUaT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625838393;\n\tbh=WLbbta4L6uwP8jEFgR39GAjAHzKCstGFaifoPyDY1eU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DrjAwUaTxnsjYjJ7l0ywbPP9e1dxxi0atHtbUEZskGRx247JZwgbhAIlLQD1vA4/I\n\tvqHVhwDiqVjZGYTrDxLwwR6YbIk6i561QoXJoYervBwZxb8Sysstb2Otyzt6O3d8FD\n\tfivrUPCwEcoAOZY5w9aaiSKtE0mf1V7Y1U+hMyX4=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210709095638.2801713-1-naush@raspberrypi.com>\n\t<20210709095638.2801713-8-naush@raspberrypi.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 9 Jul 2021 14:46:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210709095638.2801713-8-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 8/8] ipa: raspberrypi: Make\n\tvariable names consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]