[{"id":18054,"web_url":"https://patchwork.libcamera.org/comment/18054/","msgid":"","date":"2021-07-09T13:45:30","subject":"Re: [libcamera-devel] [PATCH v5 7/8] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 09/07/2021 10:56, Naushir Patuck wrote:\n> With the recent change to allow long exposures on the imx477, the existing 100s\n> limit was not adequate.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index db103a885b7a..8fb98a49da63 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -62,7 +62,7 @@ using utils::Duration;\n> constexpr double DefaultAnalogueGain = 1.0;\n> constexpr Duration DefaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> -constexpr Duration defaultMaxFrameDuration = 100.0s;\n> +constexpr Duration defaultMaxFrameDuration = 250.0s;\n\nI really love the Duration post-fixes. Makes this so clear and readable.\n\nReviewed-by: Kieran Bingham \n\n> \n> /*\n> * Determine the minimum allowable inter-frame duration to run the controller\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 796C6C3224\n\tfor ;\n\tFri, 9 Jul 2021 13:45:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDA34684E7;\n\tFri, 9 Jul 2021 15:45:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78673605AC\n\tfor ;\n\tFri, 9 Jul 2021 15:45:33 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07ACBE7;\n\tFri, 9 Jul 2021 15:45:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KDOoQBgj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625838333;\n\tbh=k4atHO1C+sYto7TC2VAOrneF+P4HXbI5e6FHZuDIXu0=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=KDOoQBgjt411PixX0OrUP84zF9xecKyRiqYlE0kcmC0RMCHW5q+yz9KAhjT1e0gsX\n\tRZ+GRZHcMrvq/60Z0OMbjvfGW9YiZ9+zvkHwLaKJeK5i27TlixrNFsl4WxsGhs71bl\n\tycwqTOpfQvbM82MMGNfMfw7KKUQqSg7mFZ5AY594=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210709095638.2801713-1-naush@raspberrypi.com>\n\t<20210709095638.2801713-7-naush@raspberrypi.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 9 Jul 2021 14:45:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210709095638.2801713-7-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 7/8] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]