[{"id":18045,"web_url":"https://patchwork.libcamera.org/comment/18045/","msgid":"","date":"2021-07-09T12:57:26","subject":"Re: [libcamera-devel] [PATCH v5 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 09/07/2021 10:56, Naushir Patuck wrote:\n> This header file is no longer C compatible, so remove the extern \"C\"\n> declaration.\n> \n> Replace C++ style comments with C style based on libcamera guidelines.\n> \n> There are no functional changes in this commit.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> .../raspberrypi/controller/device_status.h | 24 +++++++------------\n> 1 file changed, 9 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\n> index f74235248b12..733378dbfa27 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.h\n> +++ b/src/ipa/raspberrypi/controller/device_status.h\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> *\n> * device_status.h - device (image sensor) status\n> */\n> @@ -8,25 +8,19 @@\n> \n> #include \n> \n> -// Definition of \"device metadata\" which stores things like shutter time and\n> -// analogue gain that downstream control algorithms will want to know.\n> -\n> -#ifdef __cplusplus\n> -extern \"C\" {\n> -#endif\n> +/*\n> + * Definition of \"device metadata\" which stores things like shutter time and\n> + * analogue gain that downstream control algorithms will want to know.\n> + */\n> \n> struct DeviceStatus {\n> -\t// time shutter is open\n> +\t/* time shutter is open */\n> \tlibcamera::utils::Duration shutter_speed;\n> \tdouble analogue_gain;\n> -\t// 1.0/distance-in-metres, or 0 if unknown\n> +\t/* 1.0/distance-in-metres, or 0 if unknown */\n> \tdouble lens_position;\n> -\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n> +\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n> \tdouble aperture;\n> -\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n> +\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n> \tdouble flash_intensity;\n> };\n> -\n> -#ifdef __cplusplus\n> -}\n> -#endif\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90E51BD794\n\tfor ;\n\tFri, 9 Jul 2021 12:57:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECD36605AC;\n\tFri, 9 Jul 2021 14:57:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C59F9605AC\n\tfor ;\n\tFri, 9 Jul 2021 14:57:28 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 365E3E7;\n\tFri, 9 Jul 2021 14:57:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qhwvKM2T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625835448;\n\tbh=P148vEtsIfJDMpk7LCJeBQStuecP7kA5PBbbC80ySRo=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=qhwvKM2TxURr1+w3AA6K1VMOA5GWCfmp9auD4NCvlyglCzprCuuxaUOFyavGmFiUP\n\t1Vbdl3RPWAGLau/5a12l/jRxrJKQ6uMVR8yopwqqDU7ytq7yFdkqIyAUQsVTBgZmiz\n\tPXoGt8gWf/OWvfNbjZovqr0QbYWjs0jZdpFmAIa0=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210709095638.2801713-1-naush@raspberrypi.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 9 Jul 2021 13:57:26 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210709095638.2801713-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]