[{"id":18092,"web_url":"https://patchwork.libcamera.org/comment/18092/","msgid":"","date":"2021-07-11T23:16:28","subject":"Re: [libcamera-devel] [PATCH 1/2] DNI: Enforce IPA isolation and\n\tset log file path","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Thu, Jul 08, 2021 at 01:51:44PM +0530, Umang Jain wrote:\n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> src/libcamera/ipa_manager.cpp | 1 +\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 31a3c006..623c27b7 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -12,6 +12,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -39,6 +40,7 @@ class IPAIPU3 : public IPAIPU3Interface\n> public:\n> \tint init([[maybe_unused]] const IPASettings &settings) override\n> \t{\n> +\t\tlogSetFile(\"/tmp/isolated.log\");\n> \t\treturn 0;\n> \t}\n> \tint start() override;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index b4606c61..5d8ddae1 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -258,6 +258,7 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> \n> bool IPAManager::isSignatureValid([[maybe_unused]] IPAModule *ipa) const\n> {\n> +\treturn false;\n\nYou may be interested in \"[PATCH 3/3] libcamera: ipa_manager: Allow\nforcing IPA module isolation\" that I have just sent.\n\n> #if HAVE_IPA_PUBKEY\n> \tFile file{ ipa->path() };\n> \tif (!file.open(File::ReadOnly))","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2A9ABD794\n\tfor ;\n\tSun, 11 Jul 2021 23:17:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B8FE68524;\n\tMon, 12 Jul 2021 01:17:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7BD660280\n\tfor ;\n\tMon, 12 Jul 2021 01:17:14 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 736BCCC;\n\tMon, 12 Jul 2021 01:17:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fTNETXGh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626045434;\n\tbh=2Ixi/gB5Ye4UaotBnQxWnXS6SJqtjHEZcn61ND/QTEM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fTNETXGhpsLyG1IOmBLgJEOE/wh9pd2x80sWgsf8xjOPS8NSju5zbssvWGeABROVZ\n\tnDtPcAsr6SF4w2vsh9Dfx34QpltGe46jZ0syUuZOsCs/4m3IN37tzoZf29Aoee+5ZH\n\t0kyam30EX7FVACQ7oLkr16BVvjUWrWhKnybnDAq0=","Date":"Mon, 12 Jul 2021 02:16:28 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210708082145.122160-1-umang.jain@ideasonboard.com>\n\t<20210708082145.122160-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210708082145.122160-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] DNI: Enforce IPA isolation and\n\tset log file path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]