{"id":12866,"url":"https://patchwork.libcamera.org/api/patches/12866/?format=json","web_url":"https://patchwork.libcamera.org/patch/12866/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210708082145.122160-2-umang.jain@ideasonboard.com>","date":"2021-07-08T08:21:44","name":"[libcamera-devel,1/2] DNI: Enforce IPA isolation and set log file path","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ae3dad1303ba99b77fccddc67d794d3b20ae132e","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12866/mbox/","series":[{"id":2217,"url":"https://patchwork.libcamera.org/api/series/2217/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2217","date":"2021-07-08T08:21:43","name":"utils: ipc: proxy: Always reset ControlSerializer during IPA configure","version":1,"mbox":"https://patchwork.libcamera.org/series/2217/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12866/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12866/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03C73C3224\n\tfor ;\n\tThu, 8 Jul 2021 08:22:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6FA26851F;\n\tThu, 8 Jul 2021 10:21:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1853468509\n\tfor ;\n\tThu, 8 Jul 2021 10:21:58 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.59])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D295CE7;\n\tThu, 8 Jul 2021 10:21:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"biKy8mUG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625732517;\n\tbh=oEjSie/682r4kN2gVxepKJuJcyDTRryTkzZovvVAbEY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=biKy8mUGzQ8NZAhmORy/t+8dodFPUH+usc0oJU+yOdpe4sumki1Q0zY6iFyFKx7s0\n\tN17/1lUArAfHLy90jzjuJwvt+mkCdI4el1N1KfHYZeThLrTLOrMPC1Um2m+G7wtRye\n\tM4ZLWB8Xy47dGUyIGa5sBCz+GPLzSanoFmQeTSv0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 8 Jul 2021 13:51:44 +0530","Message-Id":"<20210708082145.122160-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210708082145.122160-1-umang.jain@ideasonboard.com>","References":"<20210708082145.122160-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] DNI: Enforce IPA isolation and set\n\tlog file path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"---\n src/ipa/ipu3/ipu3.cpp | 2 ++\n src/libcamera/ipa_manager.cpp | 1 +\n 2 files changed, 3 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 31a3c006..623c27b7 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include \n \n #include \n+#include \n \n #include \n #include \n@@ -39,6 +40,7 @@ class IPAIPU3 : public IPAIPU3Interface\n public:\n \tint init([[maybe_unused]] const IPASettings &settings) override\n \t{\n+\t\tlogSetFile(\"/tmp/isolated.log\");\n \t\treturn 0;\n \t}\n \tint start() override;\ndiff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex b4606c61..5d8ddae1 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -258,6 +258,7 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n \n bool IPAManager::isSignatureValid([[maybe_unused]] IPAModule *ipa) const\n {\n+\treturn false;\n #if HAVE_IPA_PUBKEY\n \tFile file{ ipa->path() };\n \tif (!file.open(File::ReadOnly))\n","prefixes":["libcamera-devel","1/2"]}