{"id":12862,"url":"https://patchwork.libcamera.org/api/patches/12862/?format=json","web_url":"https://patchwork.libcamera.org/patch/12862/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210707144202.1327061-9-nfraprado@collabora.com>","date":"2021-07-07T14:42:00","name":"[libcamera-devel,v5,08/10] lc-compliance: Check that requests complete successfully","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d8c98f5baab8c3c161365f6db1b21e01be71cea7","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12862/mbox/","series":[{"id":2216,"url":"https://patchwork.libcamera.org/api/series/2216/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2216","date":"2021-07-07T14:41:52","name":"lc-compliance: Add test to queue more requests than hardware depth","version":5,"mbox":"https://patchwork.libcamera.org/series/2216/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12862/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12862/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D379CBD794\n\tfor ;\n\tWed, 7 Jul 2021 14:42:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1AD668519;\n\tWed, 7 Jul 2021 16:42:37 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5624860284\n\tfor ;\n\tWed, 7 Jul 2021 16:42:35 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:6553:ad0c:9d2a:24db])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id DF5801F434E1;\n\tWed, 7 Jul 2021 15:42:33 +0100 (BST)"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Jul 2021 11:42:00 -0300","Message-Id":"<20210707144202.1327061-9-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210707144202.1327061-1-nfraprado@collabora.com>","References":"<20210707144202.1327061-1-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 08/10] lc-compliance: Check that\n\trequests complete successfully","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a request fails to queue it is completed but with its status set to\nRequestCancelled. Add a check in the requestComplete callback to make\nsure that the request was completed successfully.\n\nSigned-off-by: Nícolas F. R. A. Prado \n---\n\nAdded in v5\n\n src/lc-compliance/simple_capture.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\nindex 5aecc1ab0afc..7bdc8abc4c0b 100644\n--- a/src/lc-compliance/simple_capture.cpp\n+++ b/src/lc-compliance/simple_capture.cpp\n@@ -175,6 +175,7 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n \n void SimpleCaptureBalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tif (captureCompleted())\n \t\treturn;\n \n@@ -210,6 +211,7 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n \n void SimpleCaptureUnbalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tif (captureCompleted())\n \t\treturn;\n \n@@ -245,5 +247,6 @@ void SimpleCaptureOverflow::capture()\n \n void SimpleCaptureOverflow::requestComplete([[maybe_unused]] Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete) << \"Request didn't complete successfully\";\n \tcaptureCompleted();\n }\n","prefixes":["libcamera-devel","v5","08/10"]}