{"id":12852,"url":"https://patchwork.libcamera.org/api/patches/12852/?format=json","web_url":"https://patchwork.libcamera.org/patch/12852/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210707094815.1500917-9-naush@raspberrypi.com>","date":"2021-07-07T09:48:15","name":"[libcamera-devel,v4,8/8] ipa: raspberrypi: Make variable names consistent","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f31a50c0338dff5ce2c47fc852d5e1f000206f7f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12852/mbox/","series":[{"id":2214,"url":"https://patchwork.libcamera.org/api/series/2214/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2214","date":"2021-07-07T09:48:07","name":"Raspberry Pi: Enable imx477 long exposure modes","version":4,"mbox":"https://patchwork.libcamera.org/series/2214/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12852/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12852/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AAD3C3225\n\tfor ;\n\tWed, 7 Jul 2021 09:48:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 272EC6851F;\n\tWed, 7 Jul 2021 11:48:33 +0200 (CEST)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E3386851B\n\tfor ;\n\tWed, 7 Jul 2021 11:48:23 +0200 (CEST)","by mail-wr1-x42b.google.com with SMTP id t6so2296264wrm.9\n\tfor ;\n\tWed, 07 Jul 2021 02:48:23 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:f800:302e:bf7e:a06b])\n\tby smtp.gmail.com with ESMTPSA id\n\tr16sm23377836wrx.63.2021.07.07.02.48.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Jul 2021 02:48:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dN9i+D6R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=dN9i+D6RKPPLxUCHuh2KwqgOie/w5yIdl7EpIw3SR+PebDSbx+VmMsJygl479OGqqQ\n\trM/7huivwoK+IEQn0n3DdDqdfjLMtLIoRmDINUvTIugOlCWgGB9Jc+qa29kVUOm+aNUb\n\tpXixzJ7/JfHA29XqNOPJTkgxG4Zl7wMFWBY5DqOxn4nk3MrcurmEOBc2mkN0crwU+hoM\n\ttq0wFIDsMDDI3+Fjc5h1njmw89ec+F/iJZ215gy5/EmtOn41pbsuNtCVYbh+LQ3rmFRi\n\tQ8n2cujAXDZBCMW2x/gQB6u7m2zlR7QFILaEp3iyzMoleOIE6CLoVPTJzY2cGGWqK8cF\n\tSTbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=ugAKTymgDU1Hdy7ztsUQar6W1h2KVZPHagFM/DXk/5kaNpbNBdyJHrp6l0lZUwXqY4\n\tuT01jG1cAaz0UKucnv6krdM+XSVTPNht81T7s37TWpvKxnrQFV2kXPCru3ReW6GrAQGB\n\tj9ojGjltDwbEkf0YSAqolAHOtmb1ZQSv2WICQWsZikqEiz7ubAYUfuWantbUCe9k4W67\n\t3ZkI7W/gP5IF+goL+nIhpimg5qIGYzVGOFyycUMJn+WNXoBbTy6qdFPY+s5SrTauLPvk\n\tQS52wWHN9O6JR+YFnH8D27axr8DRnk2W2TkZL9T65Vy508gff/lpLIZWTax1KFkYkt/I\n\t127g==","X-Gm-Message-State":"AOAM533YnnOYnaQ3q1Dstn/orXaIVSxueFCXbXBtglhzc1+W62A7sFAY\n\twL6XW0f0mcuEl+qR1ZhU86PhLs+kLpUJPQ==","X-Google-Smtp-Source":"ABdhPJwWQn7vWf9bCOMe3q9RJfCenKC6GFuzpqwNghALd8ZI8dl8IX3G3vRNMurIhfMtC+zbzKA/HQ==","X-Received":"by 2002:a05:6000:1b8c:: with SMTP id\n\tr12mr18642355wru.427.1625651303135; \n\tWed, 07 Jul 2021 02:48:23 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Jul 2021 10:48:15 +0100","Message-Id":"<20210707094815.1500917-9-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210707094815.1500917-1-naush@raspberrypi.com>","References":"<20210707094815.1500917-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 8/8] ipa: raspberrypi: Make variable\n\tnames consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8fb98a49da63..1dd7fd68c3e9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n","prefixes":["libcamera-devel","v4","8/8"]}