[{"id":18021,"web_url":"https://patchwork.libcamera.org/comment/18021/","msgid":"","date":"2021-07-08T09:20:51","subject":"Re: [libcamera-devel] [PATCH v4 5/8] ipa: raspberrypi: Allow long\n\texposure modes for imx477.","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThank you for the updated patch!\n\nOn Wed, 7 Jul 2021 at 10:48, Naushir Patuck wrote:\n>\n> Update the imx477 CamHelper to use long exposure modes if needed.\n> This is done by overloading the CamHelper::GetVBlanking function to return a\n> frame length (and vblank value) computed using a scaling factor when the value\n> would be larger than what the sensor register could otherwise hold.\n>\n> CamHelperImx477::Prepare is also overloaded to ensure that the \"device.status\"\n> metadata returns the right value if the long exposure scaling factor is used.\n> The scaling factor is unfortunately not returned back in metadata.\n>\n> With the current imx477 driver, we can achieve a maximum exposure time of approx\n> 127 seconds since the HBLANK control is read-only.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 87 +++++++++++++++++++++++\n> 1 file changed, 87 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> index 91d05d9226ff..3059a5c6c4d7 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> @@ -6,14 +6,23 @@\n> */\n>\n> #include \n> +#include \n> #include \n> #include \n> #include \n>\n> +#include \n> +\n> #include \"cam_helper.hpp\"\n> #include \"md_parser.hpp\"\n>\n> using namespace RPiController;\n> +using namespace libcamera;\n> +using libcamera::utils::Duration;\n> +\n> +namespace libcamera {\n> +LOG_DECLARE_CATEGORY(IPARPI)\n> +}\n>\n> /*\n> * We care about two gain registers and a pair of exposure registers. Their\n> @@ -34,6 +43,9 @@ public:\n> CamHelperImx477();\n> uint32_t GainCode(double gain) const override;\n> double Gain(uint32_t gain_code) const override;\n> + void Prepare(libcamera::Span buffer, Metadata &metadata) override;\n> + uint32_t GetVBlanking(Duration &exposure, Duration minFrameDuration,\n> + Duration maxFrameDuration) const override;\n> void GetDelays(int &exposure_delay, int &gain_delay,\n> int &vblank_delay) const override;\n> bool SensorEmbeddedDataPresent() const override;\n> @@ -44,6 +56,10 @@ private:\n> * in units of lines.\n> */\n> static constexpr int frameIntegrationDiff = 22;\n> + /* Maximum frame length allowable for long exposure calculations. */\n> + static constexpr int frameLengthMax = 0xffdc;\n> + /* Largest long exposure scale factor given as a left shift on the frame length. */\n> + static constexpr int longExposureShiftMax = 7;\n>\n> void PopulateMetadata(const MdParser::RegisterMap ®isters,\n> Metadata &metadata) const override;\n> @@ -64,6 +80,77 @@ double CamHelperImx477::Gain(uint32_t gain_code) const\n> return 1024.0 / (1024 - gain_code);\n> }\n>\n> +void CamHelperImx477::Prepare(libcamera::Span buffer, Metadata &metadata)\n> +{\n> + MdParser::RegisterMap registers;\n> + DeviceStatus deviceStatus, parsedDeviceStatus;\n> +\n> + if (metadata.Get(\"device.status\", deviceStatus)) {\n> + LOG(IPARPI, Error) << \"DeviceStatus not found from DelayedControls\";\n> + return;\n> + }\n> +\n> + parseEmbeddedData(buffer, metadata);\n> +\n> + if (metadata.Get(\"device.status\", parsedDeviceStatus)) {\n> + LOG(IPARPI, Error) << \"DeviceStatus not found after parsing\";\n> + return;\n> + }\n\nJust one little question here: if we found the DeviceStatus in the\nmetadata before parsing, isn't it guaranteed to be there even if\nparsing fails? So what would happen is the parsedDeviceStatus would be\nthe same as the deviceStatus.\n\nI don't know if it's worth actually changing anything, though handling\nthat second \"not found\" error seems unnecessary. Maybe we should get\nthe return code and assert if it's wrong? But I agree that what you\nhave will work fine, so I don't mind either way.\n\n(Maybe this kind of thing would be easier to write if\nparseEmbeddedData returned whether it succeeded or not... but I don't\nreally want to propose going there right now!)\n\n> +\n> + /*\n> + * The DeviceStatus struct is first populated with values obtained from\n> + * DelayedControls. If this reports frame length is > frameLengthMax,\n> + * it means we are using a long exposure mode. Since the long exposure\n> + * scale factor is not returned back through embedded data, we must rely\n> + * on the existing exposure lines and frame length values returned by\n> + * DelayedControls.\n> + *\n> + * Otherwise, all values are updated with what is reported in the\n> + * embedded data.\n> + */\n> + if (deviceStatus.frame_length > frameLengthMax) {\n> + parsedDeviceStatus.shutter_speed = deviceStatus.shutter_speed;\n> + parsedDeviceStatus.frame_length = deviceStatus.frame_length;\n> + metadata.Set(\"device.status\", parsedDeviceStatus);\n> + LOG(IPARPI, Debug) << \"Metadata updated for long exposure: \"\n> + << parsedDeviceStatus;\n> + }\n> +}\n\nYes, I think I like this version. It seems easy to understand and we\ndon't duplicate all that code from before. It's definitely a better\nmodel to follow if folks come up against other similar sensors.\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> +\n> +uint32_t CamHelperImx477::GetVBlanking(Duration &exposure,\n> + Duration minFrameDuration,\n> + Duration maxFrameDuration) const\n> +{\n> + uint32_t frameLength, exposureLines;\n> + unsigned int shift = 0;\n> +\n> + frameLength = mode_.height + CamHelper::GetVBlanking(exposure, minFrameDuration,\n> + maxFrameDuration);\n> + /*\n> + * Check if the frame length calculated needs to be setup for long\n> + * exposure mode. This will require us to use a long exposure scale\n> + * factor provided by a shift operation in the sensor.\n> + */\n> + while (frameLength > frameLengthMax) {\n> + if (++shift > longExposureShiftMax) {\n> + shift = longExposureShiftMax;\n> + frameLength = frameLengthMax;\n> + break;\n> + }\n> + frameLength >>= 1;\n> + }\n> +\n> + if (shift) {\n> + /* Account for any rounding in the scaled frame length value. */\n> + frameLength <<= shift;\n> + exposureLines = ExposureLines(exposure);\n> + exposureLines = std::min(exposureLines, frameLength - frameIntegrationDiff);\n> + exposure = Exposure(exposureLines);\n> + }\n> +\n> + return frameLength - mode_.height;\n> +}\n> +\n> void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay,\n> int &vblank_delay) const\n> {\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47076C3224\n\tfor ;\n\tThu, 8 Jul 2021 09:21:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACA2B6851C;\n\tThu, 8 Jul 2021 11:21:04 +0200 (CEST)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4645368509\n\tfor ;\n\tThu, 8 Jul 2021 11:21:03 +0200 (CEST)","by mail-wr1-x42a.google.com with SMTP id d12so6018617wre.13\n\tfor ;\n\tThu, 08 Jul 2021 02:21:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BtHZ8tPr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=E0RgVeESuk+4+84QDZugIUxhpTbnjv2Tfcli75lCWOw=;\n\tb=BtHZ8tPrCwlvadVEklahgmhwZA/iSZp+5vmYmJG2dWzShO39DIlhMol6AodBEIhjzH\n\ti18Dcbh3kdokbtj3wthBDcq6b0QJ2LV3OIWXmAoy0hvKIWMrAkN2U9wIrUrKRcAZdmuO\n\tsK39eFgUy+Oq54NxQmEz6W2OMizq2hN7xs4V5mgevl5SJmW6R9M7LGwa86QRxBuD8p9l\n\tlYTil69ezXC+1lXns3OuKYFZ297mP9kvbPVFFLzr/kE3ls5a6d0fxS5xew7W1Tveqg6f\n\tyi3LXRLG9aQnVZEmTtshsJSL0GeM3sPxAuARJLEDTTelDLHukNBKGXoLLagIdFCgrDBF\n\t+mew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=E0RgVeESuk+4+84QDZugIUxhpTbnjv2Tfcli75lCWOw=;\n\tb=SuYep99l+zHNumKGzFzn8rHI3QwHUdunxzz3Q0RbGM6wHdgIK3fJwSzXL/p7MNlJhu\n\tH5z4uGF6NoJeFdvkHaWNywyZEP2xvm17z4wpvVs5XJTG17b6unWJzyekgIDJB+X8p5xe\n\tRf/6Q3R5HkDUZIB7UQfg9Uw6/sWbpI2C+tIsgMA7ofTrNEqWkzqW9EbSCF45Iawq+8DS\n\t6jNnTWiGw4RDZ5fCzbATm4YJ4sY+lST2ZuhCWMAgk59ZeFdf+LqTGHKYTt47UYpyhrJR\n\tbN3gGI6hiZwNIv2Dc3dZqTgoEFcUy+hFt/FMy7Cwh0hN947hcBbcnWv3KbP/MyJMjKZY\n\tbyeQ==","X-Gm-Message-State":"AOAM533eKYqyCRT59tzpi+NCXcSbYnQ4NOtaUsPjcZeXiLWIg6HFEnWu\n\teOP9L8plFi9/V3pek9sQUyS1qUdCv3ZJjKRXmdTtMA==","X-Google-Smtp-Source":"ABdhPJyaAowTz/R0XGKbWOqvrBZrq91plv2sfRGS85OytrxU5I8k9YS8RCKOESxmhK4pf1PPzmQ/+GkwctccpeaM6Uo=","X-Received":"by 2002:a5d:6506:: with SMTP id x6mr2822761wru.86.1625736062845; \n\tThu, 08 Jul 2021 02:21:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20210707094815.1500917-1-naush@raspberrypi.com>\n\t<20210707094815.1500917-6-naush@raspberrypi.com>","In-Reply-To":"<20210707094815.1500917-6-naush@raspberrypi.com>","From":"David Plowman ","Date":"Thu, 8 Jul 2021 10:20:51 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v4 5/8] ipa: raspberrypi: Allow long\n\texposure modes for imx477.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18024,"web_url":"https://patchwork.libcamera.org/comment/18024/","msgid":"","date":"2021-07-08T09:28:32","subject":"Re: [libcamera-devel] [PATCH v4 5/8] ipa: raspberrypi: Allow long\n\texposure modes for imx477.","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your review feedback.\n\nOn Thu, 8 Jul 2021 at 10:21, David Plowman \nwrote:\n\n> Hi Naush\n>\n> Thank you for the updated patch!\n>\n> On Wed, 7 Jul 2021 at 10:48, Naushir Patuck wrote:\n> >\n> > Update the imx477 CamHelper to use long exposure modes if needed.\n> > This is done by overloading the CamHelper::GetVBlanking function to\n> return a\n> > frame length (and vblank value) computed using a scaling factor when the\n> value\n> > would be larger than what the sensor register could otherwise hold.\n> >\n> > CamHelperImx477::Prepare is also overloaded to ensure that the\n> \"device.status\"\n> > metadata returns the right value if the long exposure scaling factor is\n> used.\n> > The scaling factor is unfortunately not returned back in metadata.\n> >\n> > With the current imx477 driver, we can achieve a maximum exposure time\n> of approx\n> > 127 seconds since the HBLANK control is read-only.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/cam_helper_imx477.cpp | 87 +++++++++++++++++++++++\n> > 1 file changed, 87 insertions(+)\n> >\n> > diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> > index 91d05d9226ff..3059a5c6c4d7 100644\n> > --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> > +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> > @@ -6,14 +6,23 @@\n> > */\n> >\n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> >\n> > +#include \n> > +\n> > #include \"cam_helper.hpp\"\n> > #include \"md_parser.hpp\"\n> >\n> > using namespace RPiController;\n> > +using namespace libcamera;\n> > +using libcamera::utils::Duration;\n> > +\n> > +namespace libcamera {\n> > +LOG_DECLARE_CATEGORY(IPARPI)\n> > +}\n> >\n> > /*\n> > * We care about two gain registers and a pair of exposure registers.\n> Their\n> > @@ -34,6 +43,9 @@ public:\n> > CamHelperImx477();\n> > uint32_t GainCode(double gain) const override;\n> > double Gain(uint32_t gain_code) const override;\n> > + void Prepare(libcamera::Span buffer, Metadata\n> &metadata) override;\n> > + uint32_t GetVBlanking(Duration &exposure, Duration\n> minFrameDuration,\n> > + Duration maxFrameDuration) const override;\n> > void GetDelays(int &exposure_delay, int &gain_delay,\n> > int &vblank_delay) const override;\n> > bool SensorEmbeddedDataPresent() const override;\n> > @@ -44,6 +56,10 @@ private:\n> > * in units of lines.\n> > */\n> > static constexpr int frameIntegrationDiff = 22;\n> > + /* Maximum frame length allowable for long exposure\n> calculations. */\n> > + static constexpr int frameLengthMax = 0xffdc;\n> > + /* Largest long exposure scale factor given as a left shift on\n> the frame length. */\n> > + static constexpr int longExposureShiftMax = 7;\n> >\n> > void PopulateMetadata(const MdParser::RegisterMap ®isters,\n> > Metadata &metadata) const override;\n> > @@ -64,6 +80,77 @@ double CamHelperImx477::Gain(uint32_t gain_code) const\n> > return 1024.0 / (1024 - gain_code);\n> > }\n> >\n> > +void CamHelperImx477::Prepare(libcamera::Span buffer,\n> Metadata &metadata)\n> > +{\n> > + MdParser::RegisterMap registers;\n> > + DeviceStatus deviceStatus, parsedDeviceStatus;\n> > +\n> > + if (metadata.Get(\"device.status\", deviceStatus)) {\n> > + LOG(IPARPI, Error) << \"DeviceStatus not found from\n> DelayedControls\";\n> > + return;\n> > + }\n> > +\n> > + parseEmbeddedData(buffer, metadata);\n> > +\n> > + if (metadata.Get(\"device.status\", parsedDeviceStatus)) {\n> > + LOG(IPARPI, Error) << \"DeviceStatus not found after\n> parsing\";\n> > + return;\n> > + }\n>\n> Just one little question here: if we found the DeviceStatus in the\n> metadata before parsing, isn't it guaranteed to be there even if\n> parsing fails? So what would happen is the parsedDeviceStatus would be\n> the same as the deviceStatus.\n>\n\n> I don't know if it's worth actually changing anything, though handling\n> that second \"not found\" error seems unnecessary. Maybe we should get\n> the return code and assert if it's wrong? But I agree that what you\n> have will work fine, so I don't mind either way.\n>\n\nYou are right. The second failure test will never hit, and I can get rid of\nthis test. Will do so for the next revision.\n\nRegards,\nNaush\n\n\n>\n> (Maybe this kind of thing would be easier to write if\n> parseEmbeddedData returned whether it succeeded or not... but I don't\n> really want to propose going there right now!)\n>\n> > +\n> > + /*\n> > + * The DeviceStatus struct is first populated with values\n> obtained from\n> > + * DelayedControls. If this reports frame length is >\n> frameLengthMax,\n> > + * it means we are using a long exposure mode. Since the long\n> exposure\n> > + * scale factor is not returned back through embedded data, we\n> must rely\n> > + * on the existing exposure lines and frame length values\n> returned by\n> > + * DelayedControls.\n> > + *\n> > + * Otherwise, all values are updated with what is reported in the\n> > + * embedded data.\n> > + */\n> > + if (deviceStatus.frame_length > frameLengthMax) {\n> > + parsedDeviceStatus.shutter_speed =\n> deviceStatus.shutter_speed;\n> > + parsedDeviceStatus.frame_length =\n> deviceStatus.frame_length;\n> > + metadata.Set(\"device.status\", parsedDeviceStatus);\n> > + LOG(IPARPI, Debug) << \"Metadata updated for long\n> exposure: \"\n> > + << parsedDeviceStatus;\n> > + }\n> > +}\n>\n> Yes, I think I like this version. It seems easy to understand and we\n> don't duplicate all that code from before. It's definitely a better\n> model to follow if folks come up against other similar sensors.\n>\n> Reviewed-by: David Plowman \n>\n> Thanks!\n> David\n>\n> > +\n> > +uint32_t CamHelperImx477::GetVBlanking(Duration &exposure,\n> > + Duration minFrameDuration,\n> > + Duration maxFrameDuration) const\n> > +{\n> > + uint32_t frameLength, exposureLines;\n> > + unsigned int shift = 0;\n> > +\n> > + frameLength = mode_.height + CamHelper::GetVBlanking(exposure,\n> minFrameDuration,\n> > +\n> maxFrameDuration);\n> > + /*\n> > + * Check if the frame length calculated needs to be setup for\n> long\n> > + * exposure mode. This will require us to use a long exposure\n> scale\n> > + * factor provided by a shift operation in the sensor.\n> > + */\n> > + while (frameLength > frameLengthMax) {\n> > + if (++shift > longExposureShiftMax) {\n> > + shift = longExposureShiftMax;\n> > + frameLength = frameLengthMax;\n> > + break;\n> > + }\n> > + frameLength >>= 1;\n> > + }\n> > +\n> > + if (shift) {\n> > + /* Account for any rounding in the scaled frame length\n> value. */\n> > + frameLength <<= shift;\n> > + exposureLines = ExposureLines(exposure);\n> > + exposureLines = std::min(exposureLines, frameLength -\n> frameIntegrationDiff);\n> > + exposure = Exposure(exposureLines);\n> > + }\n> > +\n> > + return frameLength - mode_.height;\n> > +}\n> > +\n> > void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay,\n> > int &vblank_delay) const\n> > {\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CFE7BD794\n\tfor ;\n\tThu, 8 Jul 2021 09:28:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B7C06851C;\n\tThu, 8 Jul 2021 11:28:51 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AF7368509\n\tfor ;\n\tThu, 8 Jul 2021 11:28:49 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id 8so1698278lfp.9\n\tfor ;\n\tThu, 08 Jul 2021 02:28:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QASmy0fz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=uwiowEUSvDYNSUZDH0jymoEGqMCwY3REt/KOnCqYvmU=;\n\tb=QASmy0fz5INRWoXMWwJb6YJnzJ31tgWdfWMhEHv6bYtevoVr4khKkHI4kvMQyOW0wx\n\tEwhNgenEJgGduaShOGnx1nyxIG64PakwAEmR6sZ3T0kWK6e7b7oUCSBNqqA1U/aBKsgV\n\tceXgXrAzCoRek2qSVvi5ad0aURk850y59wg5FlRQqXhKGIDaXWfPdmhbu3jsZv8ZKgxH\n\tJemREnxrb4yzQAWRdLpDYlyobBiUERtKEHl4rOO+/I1ZC9coJmmtp2bJucOBuZt6Toud\n\tZyvv/NrNBS5Bw8lLwCMoQNozyHFU7ML1NiesmnZKk0weyetq7YVOpYSWeN2vhfWj+BCq\n\tZ7DA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=uwiowEUSvDYNSUZDH0jymoEGqMCwY3REt/KOnCqYvmU=;\n\tb=XdAgOKPS3uXeHv6msafp68i8P55/H5YnQ9d4gxgCHBAdW7R/+M+0IJWXp20zhJJ7hj\n\tvLS11oNw3lJnPo5kiieZ2FFzgvLQDh7AmCj8rF2KC7mubMKU6LQKhG3ysa+hjtxC/9P3\n\tLzTvABiIOQP21thH7nuWseo/NXLGynha0f1MYv3yGyjYt6EH2W+ZyvzbkHmkE1nPlTN0\n\tF3ZZf6bl/2+95uSfZwlnJzPGmJcwmZ6QTwoCONITzn1JyepPNa79O663Diu5KYw4gmjB\n\t5QFsVm0vVqZWDdhU9TU0GTgnmsaObmF0eo3yia1EsG1HOH1F6txA2DpN/kv7GJzSdDBH\n\tUZiA==","X-Gm-Message-State":"AOAM533CMIV7v95JwPKeHPJzJHOze7eYxcER3CCG8WKPtt+Sodqcy4bn\n\tEgKbwyIAKBsqPKByEj48stxTUVVHqo9JR9uLG5JN6w==","X-Google-Smtp-Source":"ABdhPJyJDJRwfg89jh4TOw/SNMTi3oUek/GFfvw7kFGez6q9XzU2blpc3vcPWpkqAeqft1YJKZd3V/v/xmbLm1xYVhc=","X-Received":"by 2002:a05:6512:3b8b:: with SMTP id\n\tg11mr14333150lfv.617.1625736528826; \n\tThu, 08 Jul 2021 02:28:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20210707094815.1500917-1-naush@raspberrypi.com>\n\t<20210707094815.1500917-6-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Thu, 8 Jul 2021 10:28:32 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"multipart/alternative; boundary=\"0000000000004ca7a705c69948e0\"","Subject":"Re: [libcamera-devel] [PATCH v4 5/8] ipa: raspberrypi: Allow long\n\texposure modes for imx477.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]