[{"id":18134,"web_url":"https://patchwork.libcamera.org/comment/18134/","msgid":"<94dfced4-ebde-2080-0292-5fb4c7d8b986@ideasonboard.com>","date":"2021-07-12T15:50:01","subject":"Re: [libcamera-devel] [PATCH 22/30] cam: Make CamApp::cameraName()\n\tstatic","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/07/2021 03:19, Laurent Pinchart wrote:\n> The CamApp::cameraName() doesn't need to access any member of the CamApp\n> class. Make is static. While at is, drop an unneded const from the\n\ns/is/it/\n\n/unneded/unneeded/\n\n\n> return value.\n\nHrm ... if this was the return value being const I would have expected\n const std::string.\n\nIs this const supposed to be declaring the member function as const on\nthe class (not modifying the class) and perhaps misplaced?\n\nEither-way,\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/main.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 19ed9837cf4f..03e62f305f24 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -44,7 +44,7 @@ private:\n> \tint infoConfiguration();\n> \tint run();\n> \n> -\tstd::string const cameraName(const Camera *camera);\n> +\tstatic std::string cameraName(const Camera *camera);\n> \n> \tstatic CamApp *app_;\n> \tOptionsParser::Options options_;\n> @@ -319,7 +319,7 @@ int CamApp::run()\n> \treturn 0;\n> }\n> \n> -std::string const CamApp::cameraName(const Camera *camera)\n> +std::string CamApp::cameraName(const Camera *camera)\n> {\n> \tconst ControlList &props = camera->properties();\n> \tbool addModel = true;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C8D7C3225\n\tfor ;\n\tMon, 12 Jul 2021 15:50:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D636568524;\n\tMon, 12 Jul 2021 17:50:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E1FB68513\n\tfor ;\n\tMon, 12 Jul 2021 17:50:04 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F14F5CC;\n\tMon, 12 Jul 2021 17:50:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GgG59srx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626105004;\n\tbh=6zbdLYuxwYTPSYvqniVSz/t+YW6Evou48Mke4c+arNo=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=GgG59srxnXe7vcZog6WE/PMJ6lqAKJKYKzazqVyDONrAbKWgSd6UpEDK23aCKF0oe\n\tnpKH1mUrezfOF/dXAq0Guy/HouLAeXXOIKM1zIJexbkYD0B4i2bd7ekMI3iVn3ouoe\n\tyNMozmHUEOyY2RJSJQZ0w4T6e/fiCzmXyKEFmCcY=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>\n\t<20210707021941.20804-23-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<94dfced4-ebde-2080-0292-5fb4c7d8b986@ideasonboard.com>","Date":"Mon, 12 Jul 2021 16:50:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210707021941.20804-23-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 22/30] cam: Make CamApp::cameraName()\n\tstatic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18150,"web_url":"https://patchwork.libcamera.org/comment/18150/","msgid":"","date":"2021-07-12T18:44:17","subject":"Re: [libcamera-devel] [PATCH 22/30] cam: Make CamApp::cameraName()\n\tstatic","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Jul 12, 2021 at 04:50:01PM +0100, Kieran Bingham wrote:\n> On 07/07/2021 03:19, Laurent Pinchart wrote:\n> > The CamApp::cameraName() doesn't need to access any member of the CamApp\n> > class. Make is static. While at is, drop an unneded const from the\n> \n> s/is/it/\n> \n> /unneded/unneeded/\n> \n> > return value.\n> \n> Hrm ... if this was the return value being const I would have expected\n> const std::string.\n> \n> Is this const supposed to be declaring the member function as const on\n> the class (not modifying the class) and perhaps misplaced?\n\nIt's misplaced indeed (not according to the C++ standard, but according\nto our coding style), but qualifies the return value and should thus\nhave come first.\n\n> Either-way,\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/main.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index 19ed9837cf4f..03e62f305f24 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -44,7 +44,7 @@ private:\n> > \tint infoConfiguration();\n> > \tint run();\n> > \n> > -\tstd::string const cameraName(const Camera *camera);\n> > +\tstatic std::string cameraName(const Camera *camera);\n> > \n> > \tstatic CamApp *app_;\n> > \tOptionsParser::Options options_;\n> > @@ -319,7 +319,7 @@ int CamApp::run()\n> > \treturn 0;\n> > }\n> > \n> > -std::string const CamApp::cameraName(const Camera *camera)\n> > +std::string CamApp::cameraName(const Camera *camera)\n> > {\n> > \tconst ControlList &props = camera->properties();\n> > \tbool addModel = true;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B54AC3226\n\tfor ;\n\tMon, 12 Jul 2021 18:45:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46F2A68524;\n\tMon, 12 Jul 2021 20:45:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 927A068513\n\tfor ;\n\tMon, 12 Jul 2021 20:45:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 068F6CC;\n\tMon, 12 Jul 2021 20:45:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C5XBZ6sT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626115504;\n\tbh=okd1lz6NXx0+BqQ170T85U9dLfENBk8ldmmHElw7dTk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C5XBZ6sT1Xou1x03m377XqwdzIlIt1eb/krt8LX2xp1T4QlnM6l2Bztxu+ubRiwPx\n\tpBNxYYG+CXtace1NQPEpvCWC3JlUpmcQYjJb5IQI/kqqGMP0zRRDWegZcM0xrats8C\n\tzmYXDiu4O7u6/rrkW89jGtcrKXGkB9LbXJ+I7Kpw=","Date":"Mon, 12 Jul 2021 21:44:17 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>\n\t<20210707021941.20804-23-laurent.pinchart@ideasonboard.com>\n\t<94dfced4-ebde-2080-0292-5fb4c7d8b986@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<94dfced4-ebde-2080-0292-5fb4c7d8b986@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 22/30] cam: Make CamApp::cameraName()\n\tstatic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]