[{"id":18133,"web_url":"https://patchwork.libcamera.org/comment/18133/","msgid":"","date":"2021-07-12T15:47:05","subject":"Re: [libcamera-devel] [PATCH 21/30] cam: Drop unneeded error check\n\tand message","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/07/2021 03:19, Laurent Pinchart wrote:\n> The EventLoop::exec() function returns the exit code of the event loop,\n> not an error status. Drop the corresponding error check and error\n> message.\n\nShould the event loop return code be propagated to the application\nreturn code though?\n\nIt doesn't currently anyway so:\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/main.cpp | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 2ef26353e712..19ed9837cf4f 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -313,9 +313,7 @@ int CamApp::run()\n> \n> \tif (options_.isSet(OptMonitor)) {\n> \t\tstd::cout << \"Press Ctrl-C to interrupt\" << std::endl;\n> -\t\tret = loop_.exec();\n> -\t\tif (ret)\n> -\t\t\tstd::cout << \"Failed to run monitor loop\" << std::endl;\n> +\t\tloop_.exec();\n> \t}\n> \n> \treturn 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC58DC3225\n\tfor ;\n\tMon, 12 Jul 2021 15:47:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47EA668524;\n\tMon, 12 Jul 2021 17:47:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C8368513\n\tfor ;\n\tMon, 12 Jul 2021 17:47:08 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D85C8CC;\n\tMon, 12 Jul 2021 17:47:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QZDW8a+g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626104828;\n\tbh=w21ZRTMPZXBoATCeVejrmuqqFnQeLVejcrnEjNH3RJU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QZDW8a+g5WcE8kcpHs/tay+J0WZ4YR+Q1q/W9uRCJ4NPh7FytqxwUJVhmz7SNeBhX\n\t/EOG8GaIpbbzxjfm2ekQjQ4U9RI4FZjfDy35EK/d3IC3KUor8asISezYuwUJeF+ZzH\n\tIDZnVcE2W96xhI9gg7Dls3XmWvPF2fZa1dpE50mU=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>\n\t<20210707021941.20804-22-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Mon, 12 Jul 2021 16:47:05 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210707021941.20804-22-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 21/30] cam: Drop unneeded error check\n\tand message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18149,"web_url":"https://patchwork.libcamera.org/comment/18149/","msgid":"","date":"2021-07-12T18:41:37","subject":"Re: [libcamera-devel] [PATCH 21/30] cam: Drop unneeded error check\n\tand message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Jul 12, 2021 at 04:47:05PM +0100, Kieran Bingham wrote:\n> On 07/07/2021 03:19, Laurent Pinchart wrote:\n> > The EventLoop::exec() function returns the exit code of the event loop,\n> > not an error status. Drop the corresponding error check and error\n> > message.\n> \n> Should the event loop return code be propagated to the application\n> return code though?\n\nThat's entirely up to us, if we consider there's a need to do so. It\nwouldn't really serve any purpose right now.\n\n> It doesn't currently anyway so:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/main.cpp | 4 +---\n> > 1 file changed, 1 insertion(+), 3 deletions(-)\n> > \n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index 2ef26353e712..19ed9837cf4f 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -313,9 +313,7 @@ int CamApp::run()\n> > \n> > \tif (options_.isSet(OptMonitor)) {\n> > \t\tstd::cout << \"Press Ctrl-C to interrupt\" << std::endl;\n> > -\t\tret = loop_.exec();\n> > -\t\tif (ret)\n> > -\t\t\tstd::cout << \"Failed to run monitor loop\" << std::endl;\n> > +\t\tloop_.exec();\n> > \t}\n> > \n> > \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB827C3226\n\tfor ;\n\tMon, 12 Jul 2021 18:42:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 725FE68526;\n\tMon, 12 Jul 2021 20:42:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83C8268513\n\tfor ;\n\tMon, 12 Jul 2021 20:42:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18490CC;\n\tMon, 12 Jul 2021 20:42:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F1cLkxRG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626115344;\n\tbh=uhBIgMtfMx+gOLVqk2xfmxuyptGi4Sdmg1znF2cpjtk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F1cLkxRG6k/Rj7lp6IWfgiDsXv+xOAAbNm3wEc6SgZTCZjf6wDeSV0FQrGryVGlbU\n\t7JrJ9me6O0IB9FZycJoS6ZCdyCdgJxKpMa3C7bVaS+edKQ/XGnks9EmUYWvWfY3gW6\n\tkozilIGNG633yLIeyKCPmz7i1GDsDOLNq8Bh+u6A=","Date":"Mon, 12 Jul 2021 21:41:37 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>\n\t<20210707021941.20804-22-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 21/30] cam: Drop unneeded error check\n\tand message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]