[{"id":18117,"web_url":"https://patchwork.libcamera.org/comment/18117/","msgid":"<1057fe73-c073-6744-9187-8c5c482499e4@ideasonboard.com>","date":"2021-07-12T13:39:09","subject":"Re: [libcamera-devel] [PATCH 07/30] cam: options: Disable copy for\n\tparsers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/07/2021 03:19, Laurent Pinchart wrote:\n> Copying the OptionsParser class would result in the optionsMap_ entries\n> pointing to Option entries of the original instance. As there's no use\n> case for copying the class, disable copying.\n> \n> Disable copying of KeyValueParser as well for consistency as there's no\n> use case either.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/options.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 01a5d36a63fb..4418e201bf1f 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -68,6 +68,9 @@ public:\n> \tvirtual Options parse(const char *arguments);\n> \n> private:\n\nI will always think these implementations deserve an easily human\nreadable comment to make sure the intention is clear to the casual reader.\n\n\t/* Disable copying of the class. */\n> +\tKeyValueParser(const KeyValueParser &) = delete;\n> +\tKeyValueParser &operator=(const KeyValueParser &) = delete;\n> +\n> \tfriend class OptionsParser;\n> \tvoid usage(int indent);\n> \n> @@ -95,6 +98,9 @@ public:\n> \tvoid usage();\n> \n> private:\n> +\tOptionsParser(const OptionsParser &) = delete;\n> +\tOptionsParser &operator=(const OptionsParser &) = delete;\n> +\n> \tvoid usageOptions(const std::list