[{"id":18116,"web_url":"https://patchwork.libcamera.org/comment/18116/","msgid":"<32e4460d-a25a-0527-c853-d4c3ea84745d@ideasonboard.com>","date":"2021-07-12T13:33:31","subject":"Re: [libcamera-devel] [PATCH 06/30] cam: options: Slit\n\tOptionsParser::usage() in two functions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"In $SUBJECT : s/Slit/Split/\n\nOn 07/07/2021 03:19, Laurent Pinchart wrote:\n> To prepare for code reuse, split the printing of options out of\n> OptionsParser::usage() to a separate function.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/options.cpp | 12 +++++++++---\n> src/cam/options.h | 2 ++\n> 2 files changed, 11 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 2f71860d0466..f4fd8973f97a 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -903,8 +903,6 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n> */\n> void OptionsParser::usage()\n> {\n> -\tstd::cerr << \"Options:\" << std::endl;\n> -\n> \tunsigned int indent = 0;\n> \n> \tfor (const Option &option : options_) {\n> @@ -924,7 +922,15 @@ void OptionsParser::usage()\n> \n> \tindent = (indent + 7) / 8 * 8;\n> \n> -\tfor (const Option &option : options_) {\n> +\tstd::cerr << \"Options:\" << std::endl;\n> +\n> +\tusageOptions(options_, indent);\n> +}\n> +\n> +void OptionsParser::usageOptions(const std::list