{"id":12819,"url":"https://patchwork.libcamera.org/api/patches/12819/?format=json","web_url":"https://patchwork.libcamera.org/patch/12819/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210707021941.20804-7-laurent.pinchart@ideasonboard.com>","date":"2021-07-07T02:19:17","name":"[libcamera-devel,06/30] cam: options: Slit OptionsParser::usage() in two functions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c9c707c528450645dcaa5b2f1fc544d72e2a06a9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12819/mbox/","series":[{"id":2213,"url":"https://patchwork.libcamera.org/api/series/2213/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2213","date":"2021-07-07T02:19:12","name":"Multi-camera support in the cam application","version":1,"mbox":"https://patchwork.libcamera.org/series/2213/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12819/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12819/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4474DBD794\n\tfor ;\n\tWed, 7 Jul 2021 02:20:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B15F968513;\n\tWed, 7 Jul 2021 04:20:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD2CE6850C\n\tfor ;\n\tWed, 7 Jul 2021 04:20:33 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44CF82E4\n\tfor ;\n\tWed, 7 Jul 2021 04:20:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZtC4IZLj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625624433;\n\tbh=Utm5q6KQgIxi3/lEAP5+l8XceFv653XIHrowNEgmRNg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZtC4IZLjN3EJzFczgAqlk8g1ovsPIBTJytt3rD9Gon7boHbjO+RR8XbmHLQh6LGwG\n\tww6FNpOfgSClGS9981sUqU3QuozRz3gRgFpRW8eYyysT+GDXypb77teHwYz+wquRGd\n\tX8papCkJOuSAot2a2IwstHkPDmoVrbeaWAHwTnOo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Jul 2021 05:19:17 +0300","Message-Id":"<20210707021941.20804-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 06/30] cam: options: Slit\n\tOptionsParser::usage() in two functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To prepare for code reuse, split the printing of options out of\nOptionsParser::usage() to a separate function.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/options.cpp | 12 +++++++++---\n src/cam/options.h | 2 ++\n 2 files changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 2f71860d0466..f4fd8973f97a 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -903,8 +903,6 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n */\n void OptionsParser::usage()\n {\n-\tstd::cerr << \"Options:\" << std::endl;\n-\n \tunsigned int indent = 0;\n \n \tfor (const Option &option : options_) {\n@@ -924,7 +922,15 @@ void OptionsParser::usage()\n \n \tindent = (indent + 7) / 8 * 8;\n \n-\tfor (const Option &option : options_) {\n+\tstd::cerr << \"Options:\" << std::endl;\n+\n+\tusageOptions(options_, indent);\n+}\n+\n+void OptionsParser::usageOptions(const std::list