[{"id":18114,"web_url":"https://patchwork.libcamera.org/comment/18114/","msgid":"<02a9b8f1-cc0a-3443-1587-33db23a7e3f2@ideasonboard.com>","date":"2021-07-12T13:30:16","subject":"Re: [libcamera-devel] [PATCH 04/30] cam: options: Move OptionValue\n\tclass after OptionsParser","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/07/2021 03:19, Laurent Pinchart wrote:\n> To prepare for usage of the OptionsParser::Options class in OptionValue,\n> move the definition of the OptionValue class after OptionsParser. There\n> is not functional change.\n\ns/not/no/\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/options.h | 54 +++++++++++++++++++++++------------------------\n> 1 file changed, 27 insertions(+), 27 deletions(-)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 688fe26011f8..a3b18bb6c4ea 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -74,6 +74,33 @@ private:\n> \tstd::map optionsMap_;\n> };\n> \n> +class OptionsParser\n> +{\n> +public:\n> +\tclass Options : public OptionsBase\n> +\t{\n> +\t};\n> +\n> +\tOptionsParser();\n> +\t~OptionsParser();\n> +\n> +\tbool addOption(int opt, OptionType type, const char *help,\n> +\t\t const char *name = nullptr,\n> +\t\t OptionArgument argument = ArgumentNone,\n> +\t\t const char *argumentName = nullptr, bool array = false);\n> +\tbool addOption(int opt, KeyValueParser *parser, const char *help,\n> +\t\t const char *name = nullptr, bool array = false);\n> +\n> +\tOptions parse(int argc, char *argv[]);\n> +\tvoid usage();\n> +\n> +private:\n> +\tvoid parseValueError(const Option &option);\n> +\n> +\tstd::list