[{"id":18113,"web_url":"https://patchwork.libcamera.org/comment/18113/","msgid":"<62044c9a-3f77-660f-6730-7d603ab696d6@ideasonboard.com>","date":"2021-07-12T13:29:36","subject":"Re: [libcamera-devel] [PATCH 01/30] cam: options: Make\n\tKeyValueParser::usage() private","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/07/2021 03:19, Laurent Pinchart wrote:\n> The KeyValueParser::usage() function is meant to be called from an\n> OptionsParser or another KeyValueParser only. Make it private, and set\n> the OptionsParser class as a friend of the KeyValueParser class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/options.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index f02eeca2eef9..d0defb4bd665 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -79,9 +79,11 @@ public:\n> \t\t OptionArgument argument = ArgumentNone);\n> \n> \tvirtual Options parse(const char *arguments);\n> +\n> +private:\n> +\tfriend class OptionsParser;\n> \tvoid usage(int indent);\n> \n> -private:\n> \tstd::map optionsMap_;\n> };\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C00C8C3226\n\tfor ;\n\tMon, 12 Jul 2021 13:29:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E8B368524;\n\tMon, 12 Jul 2021 15:29:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCDC868513\n\tfor ;\n\tMon, 12 Jul 2021 15:29:38 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75685CC;\n\tMon, 12 Jul 2021 15:29:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cRFSglO3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626096578;\n\tbh=QHA3SWRAApQXtR8lVZicxbUdGEvvNFL+OWarut3NRBM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=cRFSglO3RrAEyncjTZLaHK/zYBE0qiN0NWr2hDBlToRUMnU2VYZRXeGoWC2P96ik4\n\twaYh3QgmuFFaw4xpZKBVQ8UoDlSvLKra8K/jVa2RejMDzCO7rlv65iorlzlnm29rqB\n\tXfuGkSywAZQtDQliYPnlFQKIQI3Ioikj7Ruw8IoE=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>\n\t<20210707021941.20804-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<62044c9a-3f77-660f-6730-7d603ab696d6@ideasonboard.com>","Date":"Mon, 12 Jul 2021 14:29:36 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210707021941.20804-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 01/30] cam: options: Make\n\tKeyValueParser::usage() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]