{"id":12809,"url":"https://patchwork.libcamera.org/api/patches/12809/?format=json","web_url":"https://patchwork.libcamera.org/patch/12809/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210705160120.86313-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-07-05T16:01:20","name":"[libcamera-devel] ipa: libipa: Fix ov5670 analogue gain parameters","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1b06baa56e687e13cfe00d334cf26a77a89629d4","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12809/mbox/","series":[{"id":2209,"url":"https://patchwork.libcamera.org/api/series/2209/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2209","date":"2021-07-05T16:01:20","name":"[libcamera-devel] ipa: libipa: Fix ov5670 analogue gain parameters","version":1,"mbox":"https://patchwork.libcamera.org/series/2209/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12809/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12809/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 682A7BD794\n\tfor ;\n\tMon, 5 Jul 2021 16:01:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5E25684E4;\n\tMon, 5 Jul 2021 18:01:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1A4E6050A\n\tfor ;\n\tMon, 5 Jul 2021 18:01:23 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:1d16:e950:dd18:abef])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 520B38C8;\n\tMon, 5 Jul 2021 18:01:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eU6bXk5D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625500883;\n\tbh=HMEOn/xWN2yswRCAw8Amp/m+jmoqUaVnX9OOk+tQabI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=eU6bXk5DFek9nIHF6eXJIUjyroLyj1I69MQ4Ada3dfOuKudrE8tr6RFOSdV2SL1+L\n\t25jH+JhvYuwfjGdOIPaKg8CdP0kPFK9fOSPmD/ACZfKlJY+utpOKEtXpLk02bs1gy3\n\tNHtqZzeSHjAKD6JbKLZhjcJCYF5IOGoqpmhq0O+Y=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 5 Jul 2021 18:01:20 +0200","Message-Id":"<20210705160120.86313-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: libipa: Fix ov5670 analogue gain\n\tparameters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Based on datasheet, the gain multiplier is 128 and not 256 (the\nfraction bits are the 7 lower bits). Fix it.\n\nSigned-off-by: Jean-Michel Hautbois \nChange-Id: I87e4b078f65c68da005a3ad4f1216256b8487df7\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 23335ed6..cd0a19bb 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -294,7 +294,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv5670()\n \t{\n-\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n \t}\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n","prefixes":["libcamera-devel"]}