[{"id":17959,"web_url":"https://patchwork.libcamera.org/comment/17959/","msgid":"<20210705030937.GB2510@pyrite.rasen.tech>","date":"2021-07-05T03:09:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Rename\n\tvalid() function to isValid()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Jul 05, 2021 at 02:43:44AM +0300, Laurent Pinchart wrote:\n> We use isValid() instead of valid() through the code base, make\n> MediaDevice consistent.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/media_device.h | 2 +-\n> src/libcamera/media_device.cpp | 6 +++---\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index 8424611d7eda..3a7722c2a215 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -35,7 +35,7 @@ public:\n> \tvoid unlock();\n> \n> \tint populate();\n> -\tbool valid() const { return valid_; }\n> +\tbool isValid() const { return valid_; }\n> \n> \tconst std::string driver() const { return driver_; }\n> \tconst std::string deviceNode() const { return deviceNode_; }\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index e12ab1abb10d..fa50264fa253 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -44,7 +44,7 @@ LOG_DEFINE_CATEGORY(MediaDevice)\n> * MediaEntity, MediaPad and MediaLink are created to model the media graph,\n> * and stored in a map indexed by object id.\n> *\n> - * The graph is valid once successfully populated, as reported by the valid()\n> + * The graph is valid once successfully populated, as reported by the isValid()\n> * function. It can be queried to list all entities(), or entities can be\n> * looked up by name with getEntityByName(). The graph can be traversed from\n> * entity to entity through pads and links as exposed by the corresponding\n> @@ -292,7 +292,7 @@ done:\n> }\n> \n> /**\n> - * \\fn MediaDevice::valid()\n> + * \\fn MediaDevice::isValid()\n> * \\brief Query whether the media graph has been populated and is valid\n> * \\return true if the media graph is valid, false otherwise\n> */\n> @@ -571,7 +571,7 @@ bool MediaDevice::addObject(MediaObject *object)\n> *\n> * The media device graph state is reset to invalid when the graph is cleared.\n> *\n> - * \\sa valid()\n> + * \\sa isValid()\n> */\n> void MediaDevice::clear()\n> {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F02DDBD794\n\tfor ;\n\tMon, 5 Jul 2021 03:09:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 531D468503;\n\tMon, 5 Jul 2021 05:09:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35AE760285\n\tfor ;\n\tMon, 5 Jul 2021 05:09:45 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7672E7;\n\tMon, 5 Jul 2021 05:09:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZwziBKcS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625454584;\n\tbh=t/OsZ26294FFEZlT0/VUU2FczEeY+JvLojLgTLjEd44=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZwziBKcSqD4u0a7MGIZdYsEsMLnX4DZtbrtwjOEWer8/IKjvt1IgivVZm2QoS+cic\n\tNEGal/KzTfa5lNVFmZmHp+LhR1bouLm5ts7MBbWEIP3ZCEs1k+GaRHEu3d2Ihw6vDs\n\trW+CwvPKHtjKJ7t2ZOkAymSY1pIIToEaWiP5AfXU=","Date":"Mon, 5 Jul 2021 12:09:37 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210705030937.GB2510@pyrite.rasen.tech>","References":"<20210704234344.10765-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210704234344.10765-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Rename\n\tvalid() function to isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17963,"web_url":"https://patchwork.libcamera.org/comment/17963/","msgid":"<5ad51714-8f81-f98e-3aad-2e02ad07aff3@ideasonboard.com>","date":"2021-07-05T04:44:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Rename\n\tvalid() function to isValid()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 7/5/21 5:13 AM, Laurent Pinchart wrote:\n> We use isValid() instead of valid() through the code base, make\n> MediaDevice consistent.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> include/libcamera/internal/media_device.h | 2 +-\n> src/libcamera/media_device.cpp | 6 +++---\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index 8424611d7eda..3a7722c2a215 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -35,7 +35,7 @@ public:\n> \tvoid unlock();\n> \n> \tint populate();\n> -\tbool valid() const { return valid_; }\n> +\tbool isValid() const { return valid_; }\n> \n> \tconst std::string driver() const { return driver_; }\n> \tconst std::string deviceNode() const { return deviceNode_; }\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index e12ab1abb10d..fa50264fa253 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -44,7 +44,7 @@ LOG_DEFINE_CATEGORY(MediaDevice)\n> * MediaEntity, MediaPad and MediaLink are created to model the media graph,\n> * and stored in a map indexed by object id.\n> *\n> - * The graph is valid once successfully populated, as reported by the valid()\n> + * The graph is valid once successfully populated, as reported by the isValid()\n> * function. It can be queried to list all entities(), or entities can be\n> * looked up by name with getEntityByName(). The graph can be traversed from\n> * entity to entity through pads and links as exposed by the corresponding\n> @@ -292,7 +292,7 @@ done:\n> }\n> \n> /**\n> - * \\fn MediaDevice::valid()\n> + * \\fn MediaDevice::isValid()\n> * \\brief Query whether the media graph has been populated and is valid\n> * \\return true if the media graph is valid, false otherwise\n> */\n> @@ -571,7 +571,7 @@ bool MediaDevice::addObject(MediaObject *object)\n> *\n> * The media device graph state is reset to invalid when the graph is cleared.\n> *\n> - * \\sa valid()\n> + * \\sa isValid()\n> */\n> void MediaDevice::clear()\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8708C0100\n\tfor ;\n\tMon, 5 Jul 2021 04:44:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0232768500;\n\tMon, 5 Jul 2021 06:44:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF1E260285\n\tfor ;\n\tMon, 5 Jul 2021 06:44:12 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.59])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCCF8E7;\n\tMon, 5 Jul 2021 06:44:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BL91VThd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625460252;\n\tbh=DU+kDBdxDZTc0IRUKmheq9/hiN5yrpgJBWSLxBxplvM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BL91VThdrsQXEeRSy3vLPBzxMBxHLP5fhuaxyVD0+Xvtjzp0wdD2ZjujdDyjnU8yX\n\tJD212VhqU+x7pMyUUj9xer8Tajw0KXGJaHg9etUpwJXElsukLhEqu2GiLvE6uAvSID\n\tTJ9M7pUOtU5iQmVgIdM9+Tk3lO3uA9A1rKO5LAbg=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210704234344.10765-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<5ad51714-8f81-f98e-3aad-2e02ad07aff3@ideasonboard.com>","Date":"Mon, 5 Jul 2021 10:14:07 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210704234344.10765-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Rename\n\tvalid() function to isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]