{"id":12806,"url":"https://patchwork.libcamera.org/api/patches/12806/?format=json","web_url":"https://patchwork.libcamera.org/patch/12806/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210704233620.9145-1-laurent.pinchart@ideasonboard.com>","date":"2021-07-04T23:36:19","name":"[libcamera-devel,1/2] android: Disable copy and move for CameraHalManager","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4832c40c3c57a5b6082598201e0c28f1543088c0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12806/mbox/","series":[{"id":2207,"url":"https://patchwork.libcamera.org/api/series/2207/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2207","date":"2021-07-04T23:36:19","name":"[libcamera-devel,1/2] android: Disable copy and move for CameraHalManager","version":1,"mbox":"https://patchwork.libcamera.org/series/2207/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12806/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12806/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5055CBD794\n\tfor ;\n\tSun, 4 Jul 2021 23:37:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD49968505;\n\tMon, 5 Jul 2021 01:37:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B28D60285\n\tfor ;\n\tMon, 5 Jul 2021 01:37:05 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 030B1E7\n\tfor ;\n\tMon, 5 Jul 2021 01:37:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gN4EVPlL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625441825;\n\tbh=XivCoNKTWVaT/INeuUZM0xn9Pp5F12dY5WHcylk+o9c=;\n\th=From:To:Subject:Date:From;\n\tb=gN4EVPlLq125Ka1wHCK2fUuBshl2y5RUNNU8HkpeYig1uHUQYWTTz4JPogEktfnV8\n\tX+2vKQ+Vhruk4no9nayOVxhCDOMyBSp4t3tPOJ4HnZyHutgXMcTB7wCxi4KXMJsk/+\n\t+1TKS0pD0dSrvouMbLYjN3NWYdb8QszeDjqR6iVE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 5 Jul 2021 02:36:19 +0300","Message-Id":"<20210704233620.9145-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] android: Disable copy and move for\n\tCameraHalManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraHalManager should be instantiated once only, and never copied\nor moved. Disable copying and moving.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_manager.h | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex db9354a73140..ee3fb3ad48e9 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -18,6 +18,7 @@\n #include \n \n #include \n+#include \n \n #include \"camera_hal_config.h\"\n \n@@ -40,6 +41,8 @@ public:\n \tvoid setCallbacks(const camera_module_callbacks_t *callbacks);\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraHalManager)\n+\n \tusing Mutex = std::mutex;\n \tusing MutexLocker = std::unique_lock;\n \n","prefixes":["libcamera-devel","1/2"]}