[{"id":17964,"web_url":"https://patchwork.libcamera.org/comment/17964/","msgid":"","date":"2021-07-05T04:51:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Drop\n\tinclusion of linux/media.h","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 7/5/21 3:40 AM, Laurent Pinchart wrote:\n> device_enumerator.h doesn't need to include linux/media.h. Drop\n> inclusion of the header.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \nTested-by: Umang Jain \n\n> ---\n> include/libcamera/internal/device_enumerator.h | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\n> index 222caf75a0db..baccfc000d87 100644\n> --- a/include/libcamera/internal/device_enumerator.h\n> +++ b/include/libcamera/internal/device_enumerator.h\n> @@ -11,8 +11,6 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> \n> namespace libcamera {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60494BD794\n\tfor ;\n\tMon, 5 Jul 2021 04:51:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D84F968503;\n\tMon, 5 Jul 2021 06:51:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2852260285\n\tfor ;\n\tMon, 5 Jul 2021 06:51:10 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.59])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2ED8AE7;\n\tMon, 5 Jul 2021 06:51:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g2/EVzYg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625460669;\n\tbh=y20/owz54wLm9iUmGanVNiMKaVff9KkVaB54QtWQZ0Q=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=g2/EVzYgqCgBl1yFa15I4XDhOQ+by2p0R7FmVVod4fRQUjHeuPRgG+ckN1KLpjUPv\n\tQDTLKRdGDr4zDf+uVxeQwRoSDCFnM3nLVkZeSavGK6tB5EM38LGSD0xWhYRYy0fwAK\n\tSumTO9fM3krYSCLNyIC0OQ6FJ8OpAEdhYWWBvZPk=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210704221028.30551-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 5 Jul 2021 10:21:05 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210704221028.30551-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Drop\n\tinclusion of linux/media.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17969,"web_url":"https://patchwork.libcamera.org/comment/17969/","msgid":"<20210705101627.muk5pd4huu7ziz36@uno.localdomain>","date":"2021-07-05T10:16:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Drop\n\tinclusion of linux/media.h","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jul 05, 2021 at 01:10:28AM +0300, Laurent Pinchart wrote:\n> device_enumerator.h doesn't need to include linux/media.h. Drop\n> inclusion of the header.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/device_enumerator.h | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\n> index 222caf75a0db..baccfc000d87 100644\n> --- a/include/libcamera/internal/device_enumerator.h\n> +++ b/include/libcamera/internal/device_enumerator.h\n> @@ -11,8 +11,6 @@\n> #include \n> #include \n>\n> -#include \n> -\n> #include \n>\n> namespace libcamera {\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0025BD794\n\tfor ;\n\tMon, 5 Jul 2021 10:15:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20A49684F9;\n\tMon, 5 Jul 2021 12:15:40 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE9836050A\n\tfor ;\n\tMon, 5 Jul 2021 12:15:38 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 23766FF80B;\n\tMon, 5 Jul 2021 10:15:37 +0000 (UTC)"],"Date":"Mon, 5 Jul 2021 12:16:27 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210705101627.muk5pd4huu7ziz36@uno.localdomain>","References":"<20210704221028.30551-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210704221028.30551-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Drop\n\tinclusion of linux/media.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]