{"id":12799,"url":"https://patchwork.libcamera.org/api/patches/12799/?format=json","web_url":"https://patchwork.libcamera.org/patch/12799/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702150940.226941-9-naush@raspberrypi.com>","date":"2021-07-02T15:09:40","name":"[libcamera-devel,v3,8/8] ipa: raspberrypi: Make variable names consistent","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f31a50c0338dff5ce2c47fc852d5e1f000206f7f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12799/mbox/","series":[{"id":2203,"url":"https://patchwork.libcamera.org/api/series/2203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2203","date":"2021-07-02T15:09:32","name":"Raspberry Pi: Enable imx477 long exposure modes","version":3,"mbox":"https://patchwork.libcamera.org/series/2203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12799/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12799/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36D15C0100\n\tfor ;\n\tFri, 2 Jul 2021 15:09:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B324868511;\n\tFri, 2 Jul 2021 17:09:58 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00F526850A\n\tfor ;\n\tFri, 2 Jul 2021 17:09:57 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id w13so6876737wmc.3\n\tfor ;\n\tFri, 02 Jul 2021 08:09:57 -0700 (PDT)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tn4sm3619335wrw.21.2021.07.02.08.09.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jul 2021 08:09:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Y4SdoOsU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=Y4SdoOsUmxqctbpdZQyGGbT1nbZQW4qgsUXMA55WDXQP5x3daS7CkC4dZvDccoMFkp\n\t/uO8e0++zeAs0pCWEe2vYojwSonQQw54CGuuPWjV7R+F+SNpxyvQuKRgAUZ/3YhtbGeT\n\tA8OwHdD8Y3TV65cL9mD73Y6/JJBdhqYU/HpVtXUAyQOvPVOMp9rWNWZJz/UP/QgsiXnQ\n\tWwuHjlmDABnO6ed7vA+jwaquGcLYlv2CkTHaDmgwxx+b75DYIFRFsnGQl/GItJtxz2AV\n\tRsDRPhPO2WFygaAp3/yW5eVUOUIB2vkeaAwHk5qtfn91cOGBg/VQlWbLpvOMpJizMN6c\n\tqUyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XRqliTz93DSGGSQlWnMS4j2UEugn1xX6LG8wnraWzSo=;\n\tb=PjoYB9pBrOkEnlkqrdKtvHaMGLghC3sBjv7e/LFMmyDHKPPGOGxnJso8vzp6Y/H8KZ\n\tnDzm4DLCtNtUQ+U4doKzrits31JMiWrWQKZvOtq3SgphdT61uf9j7Tud3vNzw3tzOe0i\n\tVeQykSevqUIg0E8Ksgyb6fPxPH1EmuwHlb+p6rV+TATTQ0wQQBDyclVvUWo+YStBvDyY\n\tJbblpCdT2VUft0TOPD5L+qPBglNLK22ls9pYCKVBbQjVG8pB8+kpha+bZbvjEsGQjZe3\n\tNyjpDaVG7m8Z4QmkcKexJCLJ2Knbo7VyDrbWYEkxpcNlIq/oHQBxF9N7YlFLK1SpCojD\n\tYN7A==","X-Gm-Message-State":"AOAM531d2ohCZcDylbyllPSTSACIgII3uOav3vgFOSubmRbzIWFjYRgZ\n\tvO1MYQUsuqE9LR+sGsxZFZsnFoed06w1tw==","X-Google-Smtp-Source":"ABdhPJx8EcTIrVVmst9jVYK0irij2f0jF2ujpLXYoWBbbLW8bF0y4BtiICfs1xyWWg0Q4bUsWY2pMQ==","X-Received":"by 2002:a1c:7410:: with SMTP id p16mr5841wmc.24.1625238596534;\n\tFri, 02 Jul 2021 08:09:56 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 16:09:40 +0100","Message-Id":"<20210702150940.226941-9-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210702150940.226941-1-naush@raspberrypi.com>","References":"<20210702150940.226941-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 8/8] ipa: raspberrypi: Make variable\n\tnames consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8fb98a49da63..1dd7fd68c3e9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n","prefixes":["libcamera-devel","v3","8/8"]}