[{"id":17953,"web_url":"https://patchwork.libcamera.org/comment/17953/","msgid":"","date":"2021-07-02T15:36:22","subject":"Re: [libcamera-devel] [PATCH v3 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch. LGTM!\n\nOn Fri, 2 Jul 2021 at 16:09, Naushir Patuck wrote:\n>\n> This header file is no longer C compatible, so remove the extern \"C\"\n> declaration.\n>\n> Replace C++ style comments with C style based on libcamera guidelines.\n>\n> There are no functional changes in this commit.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nDavid\n\n> ---\n> .../raspberrypi/controller/device_status.h | 24 +++++++------------\n> 1 file changed, 9 insertions(+), 15 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\n> index f74235248b12..733378dbfa27 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.h\n> +++ b/src/ipa/raspberrypi/controller/device_status.h\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> *\n> * device_status.h - device (image sensor) status\n> */\n> @@ -8,25 +8,19 @@\n>\n> #include \n>\n> -// Definition of \"device metadata\" which stores things like shutter time and\n> -// analogue gain that downstream control algorithms will want to know.\n> -\n> -#ifdef __cplusplus\n> -extern \"C\" {\n> -#endif\n> +/*\n> + * Definition of \"device metadata\" which stores things like shutter time and\n> + * analogue gain that downstream control algorithms will want to know.\n> + */\n>\n> struct DeviceStatus {\n> - // time shutter is open\n> + /* time shutter is open */\n> libcamera::utils::Duration shutter_speed;\n> double analogue_gain;\n> - // 1.0/distance-in-metres, or 0 if unknown\n> + /* 1.0/distance-in-metres, or 0 if unknown */\n> double lens_position;\n> - // 1/f so that brightness quadruples when this doubles, or 0 if unknown\n> + /* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n> double aperture;\n> - // proportional to brightness with 0 = no flash, 1 = maximum flash\n> + /* proportional to brightness with 0 = no flash, 1 = maximum flash */\n> double flash_intensity;\n> };\n> -\n> -#ifdef __cplusplus\n> -}\n> -#endif\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BFD1C0100\n\tfor ;\n\tFri, 2 Jul 2021 15:36:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C64768500;\n\tFri, 2 Jul 2021 17:36:35 +0200 (CEST)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2A91684E6\n\tfor ;\n\tFri, 2 Jul 2021 17:36:33 +0200 (CEST)","by mail-wr1-x42d.google.com with SMTP id a13so12930661wrf.10\n\tfor ;\n\tFri, 02 Jul 2021 08:36:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CvjD0o4X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=W5+KnGjzBTUJ+4Z1NxCoA60ik752ZajQOY+D7q/y8l0=;\n\tb=CvjD0o4X04LLZK+TuB19ZzDvUG73TouftKseijOm7XDg5c89sgLK/Je2bVzxtgTZXw\n\t6KieN5aHNFaojl90LQcK1e2b4hzFkYw8D1QUK3f38ixhHO+qSx+A1SKqK16CxJpHdGKc\n\t6VIsbm6uaQ75wMYHYZmqsE9vTjOwFIbJ2Lemm0sN94AgBOWZAIE6+MY6AwVN0FKAX7Um\n\tITmLP0LBCDL7VmKt6TSHLdz9B7spJcNkBM09W8oHRljb2c/jxOIbptc6Oo5Wy7baY9Cj\n\tOvLJX5aIzHhiKcatLqCgO/97gLnRIpYK6dKePNksRkwl//ll8ul0js5KjbPb4kxm8508\n\tmWhQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=W5+KnGjzBTUJ+4Z1NxCoA60ik752ZajQOY+D7q/y8l0=;\n\tb=BjmfeK3R4ysc9Q5fsSPQIu7Ln0F/Y7CUGJapxstu/BujWsaptI1d3ZoE64eVMkkNWs\n\tQ9R3BD4J1YFdFV/96wgKRkVOakfjs1O6PHrtXK+skk4mF+DOoyM7RbJNvh2Fbhtz4wbS\n\tzRGqz99B/4Lftl/YrMq0KTKH+GpCK41AtH2BXMZJpxY5OaVexi+cbdM9GmZ53Vs8gMCc\n\t59DdX02+O0Fi1yICqRldbPhtMXj8vIIA9Gg6NdvHQfLgoSN31WhtvuvAdpY7Mrzy3XSz\n\tXDDZj6vWw2tZVxrE3C4tcgWB9IHqXBPb09hrLU7FQlP3ojqkb35VYhxsbrBCOeb9PAkx\n\t9KNg==","X-Gm-Message-State":"AOAM531ISmxLT/J8vFcaiMK8s0NvCLF2JkK6FnJtmXi5aoTDKUJmyh+B\n\trENJlXfol1/ExVEf4c14vr5QfqzE3PUpuEpYlRBbag==","X-Google-Smtp-Source":"ABdhPJy62zavMgN1w4vgAEardPdGBdii7bOTSLlTj6qu67QLaf/RTmyfAX9uX9YyUy90+ZIDGypeirsKrA70mBJJ8eo=","X-Received":"by 2002:a5d:4bca:: with SMTP id l10mr279092wrt.236.1625240193621;\n\tFri, 02 Jul 2021 08:36:33 -0700 (PDT)","MIME-Version":"1.0","References":"<20210702150940.226941-1-naush@raspberrypi.com>\n\t<20210702150940.226941-2-naush@raspberrypi.com>","In-Reply-To":"<20210702150940.226941-2-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 2 Jul 2021 16:36:22 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]