{"id":12792,"url":"https://patchwork.libcamera.org/api/patches/12792/?format=json","web_url":"https://patchwork.libcamera.org/patch/12792/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702150940.226941-2-naush@raspberrypi.com>","date":"2021-07-02T15:09:33","name":"[libcamera-devel,v3,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fc4c198c499d9ada202e2973a56da03a2b14301","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12792/mbox/","series":[{"id":2203,"url":"https://patchwork.libcamera.org/api/series/2203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2203","date":"2021-07-02T15:09:32","name":"Raspberry Pi: Enable imx477 long exposure modes","version":3,"mbox":"https://patchwork.libcamera.org/series/2203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12792/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12792/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B685DC0100\n\tfor ;\n\tFri, 2 Jul 2021 15:09:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9168468506;\n\tFri, 2 Jul 2021 17:09:52 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52FC1684EA\n\tfor ;\n\tFri, 2 Jul 2021 17:09:51 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id j2so12833902wrs.12\n\tfor ;\n\tFri, 02 Jul 2021 08:09:51 -0700 (PDT)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tn4sm3619335wrw.21.2021.07.02.08.09.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jul 2021 08:09:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"bn8u61qN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=C0gP47j5UgDK8yhhXHaI9V3iumMujPU1ZTL7xRjpncw=;\n\tb=bn8u61qNrI4phw/d3UQJpZ0mvTCZTVirrN4iXvZV8juVuAKqeGKZvaSlGpqEQemEoj\n\txcQC8DOj5eHw8a6Tj6fvk48YCtXJbnEMQE21qKK4WQcJJTOn43uLdRyU/P4TAaaCqSyB\n\tq/+pGevz/Sd7ZI96Al+i1y8/JaFUwsMAvn0S04+6U6X3U0gDOgA+7fc4sMsFXH7rZbfs\n\tBeCUDwVxehSSzAM46ElQlN4sHTXzYx1jNfmbLLs/P3lzcI/G6gWsNSh21owETitZQ9s/\n\tx0U65cMUvs1x5eaN1YJjMo3W03NBhWYuEaJ1sD3PRY7SpF5yOLBK54QO7ccYMYk6bYKJ\n\tVpdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=C0gP47j5UgDK8yhhXHaI9V3iumMujPU1ZTL7xRjpncw=;\n\tb=dOVNOMcE/B5+EFkMFrU+2PHqon8XwGHXn+NlXT7uSlzLSD0NN53/25X3nTaUXvYibC\n\tdZMBLiRecn0S53VvXZu6FlBB3f2wSXy1eJSRm/0SvmLaupjBZ5K5PlGlwaA/LsAslz7M\n\t5mp//zAzCuWUVSCn2N5m2PKG42MzAQJg+gD2DtcPuZWRsvP8c7hJ62Io29uDJk8MOTUx\n\tgdc3wZPKOrDUnLcu+ZBqbm8i5lgeutNFHZOmzU/fQJPmJQ3GTPjUK8L7Q/DgN2xnLRfq\n\t7ZBkz7+whKNJ+Q7FtPd/b0wHwPOWmttMnW+4aj+I0683+sNmYmp5G2xOMIZbd2cxVsgl\n\tTa/w==","X-Gm-Message-State":"AOAM533Q+pnbR8xU4so2p3q03S8axcwE4YFpcxyupiUfEjIxMr4IRFDo\n\tp92P0B3nBJ8g3wYSE7s7PBhpc556KtbfTw==","X-Google-Smtp-Source":"ABdhPJxMQWcAlGyOtqqD5pSE8LN3n/xrydOBodjXFlw3D9m5uyjJ+EdVY3HVIioMEQEvFtfx5Snx/w==","X-Received":"by 2002:adf:e384:: with SMTP id e4mr84967wrm.317.1625238590876; \n\tFri, 02 Jul 2021 08:09:50 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 16:09:33 +0100","Message-Id":"<20210702150940.226941-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210702150940.226941-1-naush@raspberrypi.com>","References":"<20210702150940.226941-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This header file is no longer C compatible, so remove the extern \"C\"\ndeclaration.\n\nReplace C++ style comments with C style based on libcamera guidelines.\n\nThere are no functional changes in this commit.\n\nSigned-off-by: Naushir Patuck \n---\n .../raspberrypi/controller/device_status.h | 24 +++++++------------\n 1 file changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex f74235248b12..733378dbfa27 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-2-Clause */\n /*\n- * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n *\n * device_status.h - device (image sensor) status\n */\n@@ -8,25 +8,19 @@\n \n #include \n \n-// Definition of \"device metadata\" which stores things like shutter time and\n-// analogue gain that downstream control algorithms will want to know.\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n+/*\n+ * Definition of \"device metadata\" which stores things like shutter time and\n+ * analogue gain that downstream control algorithms will want to know.\n+ */\n \n struct DeviceStatus {\n-\t// time shutter is open\n+\t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\n-\t// 1.0/distance-in-metres, or 0 if unknown\n+\t/* 1.0/distance-in-metres, or 0 if unknown */\n \tdouble lens_position;\n-\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n+\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n \tdouble aperture;\n-\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n+\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n \tdouble flash_intensity;\n };\n-\n-#ifdef __cplusplus\n-}\n-#endif\n","prefixes":["libcamera-devel","v3","1/8"]}