[{"id":17952,"web_url":"https://patchwork.libcamera.org/comment/17952/","msgid":"","date":"2021-07-02T13:18:04","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Drop unneeded\n\t[[maybe_unused]]","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your patch.\n\nOn Fri, 2 Jul 2021 at 14:07, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The [[maybe_unused]] in the IMX477 camera helper isn't needed. This had\n> been pointed out by Naush during review, but I failed to update the code\n> before pushing.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Naushir Patuck \n\nI was just preparing a patch with the very same change as part of the\nimx477 long exposure\nseries :-)\n\n\n> ---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> index 4098fde6f322..efd1a5893db8 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> @@ -23,7 +23,7 @@ constexpr uint32_t expHiReg = 0x0202;\n> constexpr uint32_t expLoReg = 0x0203;\n> constexpr uint32_t gainHiReg = 0x0204;\n> constexpr uint32_t gainLoReg = 0x0205;\n> -constexpr std::initializer_list registerList [[maybe_unused]] =\n> { expHiReg, expLoReg, gainHiReg, gainLoReg };\n> +constexpr std::initializer_list registerList = { expHiReg,\n> expLoReg, gainHiReg, gainLoReg };\n>\n> class CamHelperImx477 : public CamHelper\n> {\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B788C3222\n\tfor ;\n\tFri, 2 Jul 2021 13:18:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0F7468500;\n\tFri, 2 Jul 2021 15:18:22 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3536684E6\n\tfor ;\n\tFri, 2 Jul 2021 15:18:20 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id u20so13208118ljo.12\n\tfor ;\n\tFri, 02 Jul 2021 06:18:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QZAP8sj3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=26yf4dVP3NKThIuF3w+mvp1jjjsCJOBb0Z0jBy3Mfr8=;\n\tb=QZAP8sj3xlQEnxRlFg2lIZgPWqED0M/64RLNRaAA7SSeqUXe6NklI6wgc14Ts3lmNo\n\tg6hE8XR2MITgxI72TOb/czAKiGiksHkqMQ9N/yReH0wUGUgM7Gh+Ys2iV2fOgthKDhJ1\n\tXn5uQ5EdRa21cNhhbTOqYeR+ECCg7EMGyR1euxlp8kUnus9TfxJs8pbdmt36PRuDNI0v\n\tSnlTznaluUUHwgGhhGZrk40rmc1phTYNG+78xQNzVEHNpc12G/sMkgeem8+1KQzKttZA\n\t7JULMfW860ytA/OPholENGSJZ3PAk1XmOAvo4509QE9rJfdeLek5HJFiN+2fk5Md3Edk\n\t8s6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=26yf4dVP3NKThIuF3w+mvp1jjjsCJOBb0Z0jBy3Mfr8=;\n\tb=bQZdkF9w8dhbJKBwfnI+odarO7KRBDJw5lY9RzIVuPHaQgH//hfbcfxoP+G+CQHAF8\n\t5wLWBJSordytZuTMjdGKUO2AjimYW6Tz+Bc8YBjBrLLaBxZzZlXXvnbpCH2L8uCUHuuW\n\tTT127q+0a86FCCK1ZIVj1KPorTEffQqWnelwEjSBvhyJbG45NIzBFcO6p8aUPRMiLXpf\n\t7PJvkiQw65cEzDTbtM4j4OXhyBtFkqTLuZiEy7PGzngP19bhcHj5kxQ/Fh+PCfkQLxBJ\n\tugc3tr/pdakPIG6hIlwiN7/am+5M4BROmnJZuAPyblC8mX5EOEkJY6yPW2OdPHrK7f5V\n\tUsmA==","X-Gm-Message-State":"AOAM532P9k8GBPEPB/mtlXzQf+yvWkiR0fSszNH8ktkWymwZ8hgapLEg\n\tjMwR63ECdGPE7p6Cwq5krQq4wBaQ0VIoHb1sJrohaA==","X-Google-Smtp-Source":"ABdhPJzwvoxIu+LXyBqdhn7huizcoYd0zt67W+KtOmhX1EPreEm1h7EkQcQ6/ZmQEpq0u5TEgsU2VzdnOXPTdqRgc3w=","X-Received":"by 2002:a2e:9f11:: with SMTP id u17mr3707225ljk.48.1625231900059;\n\tFri, 02 Jul 2021 06:18:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20210702130707.25345-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210702130707.25345-1-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 2 Jul 2021 14:18:04 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000014bdb105c623caf0\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Drop unneeded\n\t[[maybe_unused]]","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]