[{"id":17996,"web_url":"https://patchwork.libcamera.org/comment/17996/","msgid":"<20210706100509.GF2510@pyrite.rasen.tech>","date":"2021-07-06T10:05:09","subject":"Re: [libcamera-devel] [PATCH v1 2/2] libcamera: Adds pixel format\n\tBGRX8888","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\ns/Adds/add/ in the subject.\n\nOn Fri, Jul 02, 2021 at 05:38:50PM +0530, Vedant Paranjape wrote:\n> This patch adds pixel format BGRX8888 to libcamera. Additionally adds\n> mapping of V4L2 pixel format (V4L2_PIX_FMT_XRGB32) to BGRX8888.\n> \n> Signed-off-by: Vedant Paranjape \n\nOther than that, looks good.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/formats.cpp | 10 ++++++++++\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> 2 files changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 578ac4af..8f1197de 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -205,6 +205,16 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::BGRX8888, {\n> +\t\t.name = \"BGRX8888\",\n> +\t\t.format = formats::BGRX8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::ABGR8888, {\n> \t\t.name = \"ABGR8888\",\n> \t\t.format = formats::ABGR8888,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 59a01e02..93fc4446 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -52,6 +52,7 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::BGRX8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09350C3224\n\tfor ;\n\tTue, 6 Jul 2021 10:05:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDA2368502;\n\tTue, 6 Jul 2021 12:05:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E6E660288\n\tfor ;\n\tTue, 6 Jul 2021 12:05:17 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72E40547;\n\tTue, 6 Jul 2021 12:05:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XqsD9N66\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625565917;\n\tbh=smMPawuG1JOaGi5vUiB8qe78PWTx8i9lnHykUwr9/p8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XqsD9N662USdyxnV0Qze0XSumJD83kXAfia9hQCW9nu4mDcMyZlQr0P7ooOK6jcAa\n\tX2X3EZENBZ4IOye7S/gJeR51c2iP1LIaL5Qly6QqC4Pwm10thSa0bARCUZD0FLCGwE\n\t0WILIuEabffDfgMH8QmOOGhSm30emjteXDJB0KOc=","Date":"Tue, 6 Jul 2021 19:05:09 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210706100509.GF2510@pyrite.rasen.tech>","References":"<20210702120850.457492-1-vedantparanjape160201@gmail.com>\n\t<20210702120850.457492-2-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210702120850.457492-2-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] libcamera: Adds pixel format\n\tBGRX8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18157,"web_url":"https://patchwork.libcamera.org/comment/18157/","msgid":"","date":"2021-07-13T01:11:17","subject":"Re: [libcamera-devel] [PATCH v1 2/2] libcamera: Adds pixel format\n\tBGRX8888","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nOn Tue, Jul 06, 2021 at 07:05:09PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Vedant,\n> \n> s/Adds/add/ in the subject.\n> \n> On Fri, Jul 02, 2021 at 05:38:50PM +0530, Vedant Paranjape wrote:\n> > This patch adds pixel format BGRX8888 to libcamera. Additionally adds\n> > mapping of V4L2 pixel format (V4L2_PIX_FMT_XRGB32) to BGRX8888.\n> > \n> > Signed-off-by: Vedant Paranjape \n> \n> Other than that, looks good.\n> \n> Reviewed-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\nCan you send a v2 of the series ? We'll then apply it.\n\n> > ---\n> > src/libcamera/formats.cpp | 10 ++++++++++\n> > src/libcamera/v4l2_pixelformat.cpp | 1 +\n> > 2 files changed, 11 insertions(+)\n> > \n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index 578ac4af..8f1197de 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -205,6 +205,16 @@ const std::map pixelFormatInfo{\n> > \t\t.pixelsPerGroup = 1,\n> > \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> > \t} },\n> > +\t{ formats::BGRX8888, {\n> > +\t\t.name = \"BGRX8888\",\n> > +\t\t.format = formats::BGRX8888,\n> > +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> > +\t\t.bitsPerPixel = 32,\n> > +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +\t\t.packed = false,\n> > +\t\t.pixelsPerGroup = 1,\n> > +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t} },\n> > \t{ formats::ABGR8888, {\n> > \t\t.name = \"ABGR8888\",\n> > \t\t.format = formats::ABGR8888,\n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index 59a01e02..93fc4446 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -52,6 +52,7 @@ const std::map vpf2pf{\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::BGRX8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E112FC3225\n\tfor ;\n\tTue, 13 Jul 2021 01:12:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8185968525;\n\tTue, 13 Jul 2021 03:12:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 415926027F\n\tfor ;\n\tTue, 13 Jul 2021 03:12:05 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2D90CC;\n\tTue, 13 Jul 2021 03:12:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cLHRmky0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626138724;\n\tbh=8wl7bVrK2naZN5pP/OUynPIhGnoz/Igsm8C8ZxgDDPc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cLHRmky0e+FugnM9G0SuPC/HIJ4HqkflJ71zy0/LxJ+kI5qCbfL+R4ibtamwhFDLp\n\tfTKLA8BMJkMMofeKiFpOW/QFd/Jy5YSgWlJImsgYtNl8YZ5+oGNXPCxHcvb6Sxh8i5\n\t621I97FHWveo/l2PoPW0rU7nsZei6xNa5BEB2JSk=","Date":"Tue, 13 Jul 2021 04:11:17 +0300","From":"Laurent Pinchart ","To":"Vedant Paranjape ","Message-ID":"","References":"<20210702120850.457492-1-vedantparanjape160201@gmail.com>\n\t<20210702120850.457492-2-vedantparanjape160201@gmail.com>\n\t<20210706100509.GF2510@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210706100509.GF2510@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] libcamera: Adds pixel format\n\tBGRX8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]