[{"id":17991,"web_url":"https://patchwork.libcamera.org/comment/17991/","msgid":"<20210705155611.7aqsh2zovnwvupiy@uno.localdomain>","date":"2021-07-05T15:56:11","subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Jul 02, 2021 at 07:37:56PM +0900, Paul Elder wrote:\n> We want the IPU3 IPA to support setting MaxLatency, so initialize the\n> MaxLatency ControlInfo in the IPU3 pipeline handler.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n>\n\nI wish... isn't it a bie early to claim so ? :)\n\n> ---\n> No change in v3\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 76c3bb3d..d3dafd98 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -49,6 +49,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n> static constexpr Size IPU3ViewfinderSize(1280, 720);\n>\n> static const ControlInfoMap::Map IPU3Controls = {\n> +\t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n> };\n>\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1CD8C0100\n\tfor ;\n\tMon, 5 Jul 2021 15:55:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 387FB684F9;\n\tMon, 5 Jul 2021 17:55:24 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7751C6050A\n\tfor ;\n\tMon, 5 Jul 2021 17:55:23 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C5B5024000E;\n\tMon, 5 Jul 2021 15:55:22 +0000 (UTC)"],"Date":"Mon, 5 Jul 2021 17:56:11 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210705155611.7aqsh2zovnwvupiy@uno.localdomain>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>\n\t<20210702103800.41291-13-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210702103800.41291-13-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18091,"web_url":"https://patchwork.libcamera.org/comment/18091/","msgid":"","date":"2021-07-11T22:39:29","subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Jul 05, 2021 at 05:56:11PM +0200, Jacopo Mondi wrote:\n> On Fri, Jul 02, 2021 at 07:37:56PM +0900, Paul Elder wrote:\n> > We want the IPU3 IPA to support setting MaxLatency, so initialize the\n> > MaxLatency ControlInfo in the IPU3 pipeline handler.\n> >\n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n> \n> I wish... isn't it a bie early to claim so ? :)\n\nLet's say that the patch itself is fine, but more changes are needed if\nwe don't want to lie :-)\n\nDo you think we should delay merging this ?\n\n> > ---\n> > No change in v3\n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 76c3bb3d..d3dafd98 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -49,6 +49,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n> > static constexpr Size IPU3ViewfinderSize(1280, 720);\n> >\n> > static const ControlInfoMap::Map IPU3Controls = {\n> > +\t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> > \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n> > };\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED62AC3224\n\tfor ;\n\tSun, 11 Jul 2021 22:40:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50CD168524;\n\tMon, 12 Jul 2021 00:40:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1556A60280\n\tfor ;\n\tMon, 12 Jul 2021 00:40:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CD5FCC;\n\tMon, 12 Jul 2021 00:40:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qh5RsFiP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626043215;\n\tbh=JUP1e7nAQq+1YljEZzJv3Pq5tYgyVDUOEflUpL2R1/A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qh5RsFiP8biwCOHoef5NEUeFrymXKLkj+LygUeGbfIZjWVd8MVd2j+32R87ofiTqq\n\tTRVJ+Ko1XLdYxFtVJLhxcDzEwgE3QFJzDxaBKhcDiJT5pAZm5tw/YFwc6wOVGwiKJI\n\tXen8XzmekEjXrVnoTPrHvaNTVClaZrUwaitmcGa8=","Date":"Mon, 12 Jul 2021 01:39:29 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>\n\t<20210702103800.41291-13-paul.elder@ideasonboard.com>\n\t<20210705155611.7aqsh2zovnwvupiy@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210705155611.7aqsh2zovnwvupiy@uno.localdomain>","Subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18095,"web_url":"https://patchwork.libcamera.org/comment/18095/","msgid":"<20210712075123.t5mtipires7egfht@uno.localdomain>","date":"2021-07-12T07:51:23","subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jul 12, 2021 at 01:39:29AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Mon, Jul 05, 2021 at 05:56:11PM +0200, Jacopo Mondi wrote:\n> > On Fri, Jul 02, 2021 at 07:37:56PM +0900, Paul Elder wrote:\n> > > We want the IPU3 IPA to support setting MaxLatency, so initialize the\n> > > MaxLatency ControlInfo in the IPU3 pipeline handler.\n> > >\n> > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> > > Signed-off-by: Paul Elder \n> > > Reviewed-by: Laurent Pinchart \n> >\n> > I wish... isn't it a bie early to claim so ? :)\n>\n> Let's say that the patch itself is fine, but more changes are needed if\n> we don't want to lie :-)\n>\n> Do you think we should delay merging this ?\n\nAs long as FULL is not enabled this should make a difference, so it\ncan go in earlier.\n\nThanks\n j\n\n>\n> > > ---\n> > > No change in v3\n> > > ---\n> > > src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > index 76c3bb3d..d3dafd98 100644\n> > > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > @@ -49,6 +49,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n> > > static constexpr Size IPU3ViewfinderSize(1280, 720);\n> > >\n> > > static const ControlInfoMap::Map IPU3Controls = {\n> > > +\t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> > > \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n> > > };\n> > >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFC7FC3224\n\tfor ;\n\tMon, 12 Jul 2021 07:50:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9B7968524;\n\tMon, 12 Jul 2021 09:50:36 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DAD168506\n\tfor ;\n\tMon, 12 Jul 2021 09:50:35 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 316B76000D;\n\tMon, 12 Jul 2021 07:50:33 +0000 (UTC)"],"Date":"Mon, 12 Jul 2021 09:51:23 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210712075123.t5mtipires7egfht@uno.localdomain>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>\n\t<20210702103800.41291-13-paul.elder@ideasonboard.com>\n\t<20210705155611.7aqsh2zovnwvupiy@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH v3 12/16] pipeline: ipu3: Set\n\tMaxLatency ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]