{"id":12776,"url":"https://patchwork.libcamera.org/api/patches/12776/?format=json","web_url":"https://patchwork.libcamera.org/patch/12776/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702103800.41291-12-paul.elder@ideasonboard.com>","date":"2021-07-02T10:37:55","name":"[libcamera-devel,RFC,v3,11/16] android: Plumb AwbLock control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d056b520721be82f8197d5f384e4efb0bf100274","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12776/mbox/","series":[{"id":2199,"url":"https://patchwork.libcamera.org/api/series/2199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2199","date":"2021-07-02T10:37:44","name":"Preliminary FULL plumbing","version":3,"mbox":"https://patchwork.libcamera.org/series/2199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12776/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12776/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38F55C3222\n\tfor ;\n\tFri, 2 Jul 2021 10:38:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5CDE684FB;\n\tFri, 2 Jul 2021 12:38:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E964684F2\n\tfor ;\n\tFri, 2 Jul 2021 12:38:34 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1FB84AB;\n\tFri, 2 Jul 2021 12:38:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M8H0ajIA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222313;\n\tbh=iN69RLAK1D2meF3e9tUqtevbFTdsyHTS14qo31Nl9Mw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M8H0ajIAJrQ4TNPFhQoryi/DpnoZp6xE02CxByMu9tqecTur75WI1dZ4j8ToSkafB\n\tycyS7Pl/+W0QNk/Sk+x36fcAjzQFew5NlzZmLR/xBV/rEYXnObCr5u0kP1/F7DcB6e\n\t7TJo11Gh/u4TL9+c9COc0n2GJaq395S7FWx+nbsA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 19:37:55 +0900","Message-Id":"<20210702103800.41291-12-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v3 11/16] android: Plumb AwbLock\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb the AwbLock control into the HAL for\nCONTROL_AWB_LOCK_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=45\nSigned-off-by: Paul Elder \n\n---\nChanges in v3:\n- use new setMetadata\n- rebase on camera capabilities refactor\n\nTODO: plumb result metadata\n---\n src/android/camera_capabilities.cpp | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex a1674eae..cb9a49c7 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -572,7 +572,6 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\t ANDROID_CONTROL_AE_MODE_OFF) == aeModes.end()) {\n \t\tLOG(HAL, Info) << \"AE cannot be turned off\";\n \t\thwLevels.erase(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL);\n-\t\t/* \\todo Double check if this is the correct capability */\n \t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n \t}\n \n@@ -700,9 +699,17 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n \t}\n \n-\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n-\t\t\t\t awbLockAvailable);\n+\tuint8_t awbLockAvailable = setMetadata(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n+\t\tcontrolsInfo, &controls::AwbLock,\n+\t\tControlRange::Max,\n+\t\t(uint8_t)ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE);\n+\tif (awbLockAvailable != ANDROID_CONTROL_AWB_LOCK_AVAILABLE_TRUE) {\n+\t\tLOG(HAL, Info) << \"AWB lock is unavailable\";\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE);\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n+\t}\n \n \tchar availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n","prefixes":["libcamera-devel","RFC","v3","11/16"]}