{"id":12775,"url":"https://patchwork.libcamera.org/api/patches/12775/?format=json","web_url":"https://patchwork.libcamera.org/patch/12775/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702103800.41291-11-paul.elder@ideasonboard.com>","date":"2021-07-02T10:37:54","name":"[libcamera-devel,RFC,v3,10/16] android: Plumb AwbMode control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c46ffffb23dc93b9663e3bd198f78009c4fe4321","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12775/mbox/","series":[{"id":2199,"url":"https://patchwork.libcamera.org/api/series/2199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2199","date":"2021-07-02T10:37:44","name":"Preliminary FULL plumbing","version":3,"mbox":"https://patchwork.libcamera.org/series/2199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12775/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12775/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5274C3222\n\tfor ;\n\tFri, 2 Jul 2021 10:38:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C882684F3;\n\tFri, 2 Jul 2021 12:38:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33E79684FA\n\tfor ;\n\tFri, 2 Jul 2021 12:38:32 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C06BA4AB;\n\tFri, 2 Jul 2021 12:38:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KrcAjf5I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222312;\n\tbh=1oNaV1COmX83StINoM4E3rLeScTiGuSt00wkeJqpDi8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KrcAjf5I/QYPFz5Ip1HuGiuDJhlanks39L8mzbSpSllvTrQC74ts1VTLdfp1NdUya\n\t+nS1lD8FE94RuYNtRxOV5bArSTZDTrBhZboPlshBz4E4nYin3OSfXGFcy0rrS8QRV+\n\t56Ltw8War9FLs7D7NxqTsTj4MqBuao4A9tJEz77w=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 19:37:54 +0900","Message-Id":"<20210702103800.41291-11-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v3 10/16] android: Plumb AwbMode\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb the AwbMode control into the HAL for\nCONTROL_AWB_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=44\nSigned-off-by: Paul Elder \n\n---\nChanges in v3:\n- use new setMetadata\n- rebase on camera capabilities refactor\n\nTODO: plumb result metadata\n---\n src/android/camera_capabilities.cpp | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 5896d61d..a1674eae 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -662,15 +662,17 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n \t\t\t\t availableStabilizationModes);\n \n-\t/*\n-\t * \\todo Inspect the camera capabilities to report the available\n-\t * AWB modes. Default to AUTO as CTS tests require it.\n-\t */\n-\tstd::vector availableAwbModes = {\n-\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n-\t\t\t\t availableAwbModes);\n+\tstd::vector awbModes = setMetadata(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AWB_AVAILABLE_MODES,\n+\t\tcontrolsInfo, &controls::AwbMode,\n+\t\tstd::vector({ ANDROID_CONTROL_AWB_MODE_AUTO }));\n+\tif (std::find(awbModes.begin(), awbModes.end(),\n+\t\t ANDROID_CONTROL_AWB_MODE_OFF) == awbModes.end()) {\n+\t\tLOG(HAL, Info) << \"AWB cannot be turned off\";\n+\t\thwLevels.erase(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL);\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n+\t}\n \n \tstd::vector availableMaxRegions = {\n \t\t0, 0, 0,\n","prefixes":["libcamera-devel","RFC","v3","10/16"]}