{"id":12774,"url":"https://patchwork.libcamera.org/api/patches/12774/?format=json","web_url":"https://patchwork.libcamera.org/patch/12774/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702103800.41291-10-paul.elder@ideasonboard.com>","date":"2021-07-02T10:37:53","name":"[libcamera-devel,RFC,v3,09/16] android: Plumb AeLock control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"617700199b6ff6dc4edd272c9911b1e7653fd6ed","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12774/mbox/","series":[{"id":2199,"url":"https://patchwork.libcamera.org/api/series/2199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2199","date":"2021-07-02T10:37:44","name":"Preliminary FULL plumbing","version":3,"mbox":"https://patchwork.libcamera.org/series/2199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12774/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12774/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 462A3C3222\n\tfor ;\n\tFri, 2 Jul 2021 10:38:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F35B2684F2;\n\tFri, 2 Jul 2021 12:38:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F640684EA\n\tfor ;\n\tFri, 2 Jul 2021 12:38:30 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCA6B4AB;\n\tFri, 2 Jul 2021 12:38:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o0nc2LLs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222310;\n\tbh=pea6CLApvUCw4iHgN4LrzPdMmrovxBTWZ3iURRQT+3k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o0nc2LLsxb32/g4ajierppvbkDor0YgJOyXOdWBnP3tfyDkpvKlBUtFO9kNbq4HMW\n\tNaXq6+3jiG26H1zNRVMPUS2Hf/MLRJy38z86NMzGLb7CgrcrIBXCyfy+pcbpG/4BwV\n\tBSCdterBh0GL7l36+7G9xqcvRVarIEqHTJXSpmYE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 19:37:53 +0900","Message-Id":"<20210702103800.41291-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v3 09/16] android: Plumb AeLock control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb the AeLock control into the HAL for\nCONTROL_AE_LOCK_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=43\nSigned-off-by: Paul Elder \n\n---\nChanges in v3:\n- use new setMetadata\n- rebase on camera capabilities refactor\n\nTODO: plumb result metadata\n---\n src/android/camera_capabilities.cpp | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 21ba791a..5896d61d 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -686,9 +686,17 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n \t\t\t\t sceneModesOverride);\n \n-\tuint8_t aeLockAvailable = ANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE;\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n-\t\t\t\t aeLockAvailable);\n+\tuint8_t aeLockAvailable = setMetadata(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n+\t\tcontrolsInfo, &controls::AeLock,\n+\t\tControlRange::Max,\n+\t\t(uint8_t)ANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE);\n+\tif (aeLockAvailable != ANDROID_CONTROL_AE_LOCK_AVAILABLE_TRUE) {\n+\t\tLOG(HAL, Info) << \"AE lock is unavailable\";\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE);\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n+\t}\n \n \tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n","prefixes":["libcamera-devel","RFC","v3","09/16"]}