{"id":12769,"url":"https://patchwork.libcamera.org/api/patches/12769/?format=json","web_url":"https://patchwork.libcamera.org/patch/12769/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702103800.41291-5-paul.elder@ideasonboard.com>","date":"2021-07-02T10:37:48","name":"[libcamera-devel,RFC,v3,04/16] android, controls: Add and plumb MaxLatency control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4e14a44325cb7d1280b27d41a4ec03b86ae4e5d1","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12769/mbox/","series":[{"id":2199,"url":"https://patchwork.libcamera.org/api/series/2199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2199","date":"2021-07-02T10:37:44","name":"Preliminary FULL plumbing","version":3,"mbox":"https://patchwork.libcamera.org/series/2199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12769/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12769/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C17DC3222\n\tfor ;\n\tFri, 2 Jul 2021 10:38:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37608684EA;\n\tFri, 2 Jul 2021 12:38:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEA9D684F2\n\tfor ;\n\tFri, 2 Jul 2021 12:38:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB65E4AB;\n\tFri, 2 Jul 2021 12:38:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d/jr0b6R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222300;\n\tbh=AYcneyqdlXVNb+KfsqqK/l6a6Fv5IopjSTuCKdlKpgo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d/jr0b6RqcCy+4VyxTOHPlQig4EVV6HWlErAcyIbMvDcIh6GlDWKk7laUXywpgI7l\n\tzAyaDxP98rc4qZ61Bjic6x2/bzvhltI8Hee3GJbmTUU0BaDNUgvGJR1KUcJHOYaWLb\n\t+BiLKzqKqKqzGnI7MZ+jio+456z5C8IXB+0YQboM=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 19:37:48 +0900","Message-Id":"<20210702103800.41291-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v3 04/16] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a MaxLatency control, and plumb it into the HAL accordingly.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=50\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v3:\n- use v3 setMetadata\n- add comment to explain 4\n- remove todo\n\nChanges in v2:\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 13 +++++++++++--\n src/libcamera/control_ids.yaml | 10 ++++++++++\n 2 files changed, 21 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 1d4c44ce..530167de 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -870,8 +870,17 @@ int CameraCapabilities::initializeStaticMetadata()\n \t}\n \n \t/* Sync static metadata. */\n-\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n-\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n+\tint32_t maxLatency = setMetadata(\n+\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n+\t\tcontrolsInfo, &controls::draft::MaxLatency,\n+\t\tControlRange::Def,\n+\t\t(int32_t)ANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n+\tLOG(HAL, Info) << \"Max sync latency is \" << maxLatency;\n+\t/* CTS allows a sync latency of up to 4 for burst capture capability */\n+\tif (maxLatency < 0 || 4 < maxLatency)\n+\t\tcapabilities.erase(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE);\n+\tif (maxLatency != 0)\n+\t\thwLevels.erase(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL);\n \n \t/* Flash static metadata. */\n \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex d92f29f5..9d4638ae 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -622,6 +622,16 @@ controls:\n detection, additional format conversions etc) count as an additional\n pipeline stage.\n \n+ - MaxLatency:\n+ type: int32_t\n+ draft: true\n+ description: |\n+ The maximum number of frames that can occur after a request (different\n+ than the previous) has been submitted, and before the result's state\n+ becomes synchronized. A value of -1 indicates unknown latency, and 0\n+ indicates per-frame control. Currently identical to\n+ ANDROID_SYNC_MAX_LATENCY.\n+\n - TestPatternMode:\n type: int32_t\n draft: true\n","prefixes":["libcamera-devel","RFC","v3","04/16"]}