[{"id":17944,"web_url":"https://patchwork.libcamera.org/comment/17944/","msgid":"","date":"2021-07-01T23:57:08","subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Make\n\tvariable names consistent","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Jul 01, 2021 at 12:34:42PM +0100, Naushir Patuck wrote:\n> s/DefaultAnalogueGain/defaultAnalogueGain/\n> s/DefaultExposureTime/defaultExposureTime/\n> \n> Change these for consistency with the other static const variables.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index dd20c854c788..e9bd724f5eac 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n> using utils::Duration;\n> \n> /* Configure the sensor with these values initially. */\n> -constexpr double DefaultAnalogueGain = 1.0;\n> -constexpr Duration DefaultExposureTime = 20.0ms;\n> +constexpr double defaultAnalogueGain = 1.0;\n> +constexpr Duration defaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> constexpr Duration defaultMaxFrameDuration = 250.0s;\n> \n> @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n> \t\t/* Supply initial values for gain and exposure. */\n> \t\tControlList ctrls(sensorCtrls_);\n> \t\tAgcStatus agcStatus;\n> -\t\tagcStatus.shutter_time = DefaultExposureTime;\n> -\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n> +\t\tagcStatus.shutter_time = defaultExposureTime;\n> +\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n> \t\tapplyAGC(&agcStatus, ctrls);\n> \n> \t\tASSERT(controls);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09DD4C3222\n\tfor ;\n\tThu, 1 Jul 2021 23:57:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BACDD684E3;\n\tFri, 2 Jul 2021 01:57:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6280960288\n\tfor ;\n\tFri, 2 Jul 2021 01:57:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E42314AB;\n\tFri, 2 Jul 2021 01:57:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lx3NeikO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625183867;\n\tbh=D47aqFQjkHQF+AaYeCjMK8eq1YtVxKtJABneRBbe2Pk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Lx3NeikONn8z0WdZMudDqzYGemSoRd8cnBxdLS/OhoP+lOuuaUDEirqiZvbwww9Xh\n\tB/uNC0YkY+BXlaKr7ZDIOKF/OJD3B4oL7XBrwkUqz1iY7C6d7nz59Y0UR4rL5px3Ch\n\tm6F8WFHRSr87uSlICtvoH8aVeyxeSyb2/b+BwSDY=","Date":"Fri, 2 Jul 2021 02:57:08 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210701113442.111718-1-naush@raspberrypi.com>\n\t<20210701113442.111718-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210701113442.111718-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Make\n\tvariable names consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]