[{"id":17943,"web_url":"https://patchwork.libcamera.org/comment/17943/","msgid":"","date":"2021-07-01T23:56:32","subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Jul 01, 2021 at 12:34:41PM +0100, Naushir Patuck wrote:\n> With the recent change to allow long exposures on the imx477, the existing 100s\n> limit was not adequate.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 4d09a84f6532..dd20c854c788 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -62,7 +62,7 @@ using utils::Duration;\n> constexpr double DefaultAnalogueGain = 1.0;\n> constexpr Duration DefaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> -constexpr Duration defaultMaxFrameDuration = 100.0s;\n> +constexpr Duration defaultMaxFrameDuration = 250.0s;\n\nI'll trust you that this is the correct value :-)\n\nReviewed-by: Laurent Pinchart \n\n> \n> /*\n> * Determine the minimum allowable inter-frame duration to run the controller","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C80DC3222\n\tfor ;\n\tThu, 1 Jul 2021 23:57:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA73B684E7;\n\tFri, 2 Jul 2021 01:57:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2321960288\n\tfor ;\n\tFri, 2 Jul 2021 01:57:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC09E4AB;\n\tFri, 2 Jul 2021 01:57:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u3/pKLOZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625183832;\n\tbh=ggDdk3tUDKNWbvuMLwPsEYl0CQQabDcJzqjRC6tezb8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u3/pKLOZhpr00PeTTLB8pvqspQINUhKm1RK2mx4y4PxXqkuIgHC+KwmFpYODvE0Dg\n\t0cjf9DipZNP91DCc2oPFy18A6K4NPXkf0Ake9Djf9kdboTFny1iMxQeAoNW4bcn4BJ\n\tZLU4o6szrSTYA835K90SyLS1JO3+6l/E7yviy65c=","Date":"Fri, 2 Jul 2021 02:56:32 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210701113442.111718-1-naush@raspberrypi.com>\n\t<20210701113442.111718-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210701113442.111718-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]