[{"id":17925,"web_url":"https://patchwork.libcamera.org/comment/17925/","msgid":"","date":"2021-06-29T21:51:16","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline_handler: Hide\n\timplementation detail comment from doxygen","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Tue, Jun 29, 2021 at 06:58:30PM +0200, Jean-Michel Hautbois wrote:\n> The comment is a implementation detail and does not belong to API\n> documentation. Move it inside the function.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n\nLooks good to me, feel free to push :-)\n\n> ---\n> src/libcamera/pipeline_handler.cpp | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index f626eddd..0ed172dc 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -707,14 +707,15 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n> \n> /**\n> * \\brief Retrieve the list of all pipeline handler factories\n> - *\n> - * The static factories map is defined inside the function to ensures it gets\n> - * initialized on first use, without any dependency on link order.\n> - *\n> * \\return the list of pipeline handler factories\n> */\n> std::vector &PipelineHandlerFactory::factories()\n> {\n> +\t/*\n> +\t * The static factories map is defined inside the function to ensure\n> +\t * it gets initialized on first use, without any dependency on\n> +\t * link order.\n> +\t */\n> \tstatic std::vector factories;\n> \treturn factories;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50F71C321F\n\tfor ;\n\tTue, 29 Jun 2021 21:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96968684E9;\n\tTue, 29 Jun 2021 23:51:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD53F684CB\n\tfor ;\n\tTue, 29 Jun 2021 23:51:53 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AA0E4AD;\n\tTue, 29 Jun 2021 23:51:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kd+fK0F8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625003513;\n\tbh=oBnAOU1+K9dU/7+BtwOKONkYt6LJ6EJq6xWQe0givSs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kd+fK0F8Oq+6/aQ4kda9GHvUoetWdIWr4S+mJrhT1NevL7oFjR1H9L/zmX6DgLK4R\n\tAW5RwbwMtdiMTlk3YnvZcJ755+jiwPR+AH6qfdn7WtdY4bXD7AYrmz0h+PFM/8oBGm\n\tnxUvJicoi3wrh+XG/bjtKr9pYglL/QXRJatGSEpM=","Date":"Wed, 30 Jun 2021 00:51:16 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210629165830.196578-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210629165830.196578-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline_handler: Hide\n\timplementation detail comment from doxygen","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]