{"id":12738,"url":"https://patchwork.libcamera.org/api/patches/12738/?format=json","web_url":"https://patchwork.libcamera.org/patch/12738/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210628202255.138874-4-jeanmichel.hautbois@ideasonboard.com>","date":"2021-06-28T20:22:51","name":"[libcamera-devel,v1,3/7] ipa: ipu3: Use a common IPU3 header for the constants","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"289f5225496c458dcb97f5398d416793a3aeecb5","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12738/mbox/","series":[{"id":2190,"url":"https://patchwork.libcamera.org/api/series/2190/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2190","date":"2021-06-28T20:22:48","name":"ipa: Introduce a new open AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/2190/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12738/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12738/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC442C321F\n\tfor ;\n\tMon, 28 Jun 2021 20:23:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2546E684DA;\n\tMon, 28 Jun 2021 22:23:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B4E66028C\n\tfor ;\n\tMon, 28 Jun 2021 22:23:00 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c3ad:78d0:405e:fc33])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFC9B26FE;\n\tMon, 28 Jun 2021 22:22:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PQ5knaXr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624911780;\n\tbh=Z1+aTxtelZoqMZmGab2uUv6Y2wd+AI/zZc5WyJunc8U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PQ5knaXrwVmGGoqvbAhC4+ruYb+B5oJf2Hw5WABufXOQ2I5EsIiE4tKg6PgjVgxW4\n\tTsV62sGoGvs+Otz8YYOCicSP0I90DY1DOBbk2vwXJ0Y262i6uTv5ZrA2JhDCaevFQ1\n\tLhmmsB9nxoBzES2I5HJT9Ye5sWI9t6b7F82N8T6k=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Jun 2021 22:22:51 +0200","Message-Id":"<20210628202255.138874-4-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210628202255.138874-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210628202255.138874-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 3/7] ipa: ipu3: Use a common IPU3\n\theader for the constants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Every constants used can be needed by both AWB and AGC (for the moment).\nUse a common header to simplify their usage.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3_agc.h | 2 ++\n src/ipa/ipu3/ipu3_awb.h | 11 ++-------\n src/ipa/ipu3/ipu3_common.h | 49 ++++++++++++++++++++++++++++++++++++++\n 3 files changed, 53 insertions(+), 9 deletions(-)\n create mode 100644 src/ipa/ipu3/ipu3_common.h","diff":"diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\nindex 6ca9af8e..774c8385 100644\n--- a/src/ipa/ipu3/ipu3_agc.h\n+++ b/src/ipa/ipu3/ipu3_agc.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_IPU3_AGC_H__\n #define __LIBCAMERA_IPU3_AGC_H__\n \n+#include \"ipu3_common.h\"\n+\n #include \n #include \n \ndiff --git a/src/ipa/ipu3/ipu3_awb.h b/src/ipa/ipu3/ipu3_awb.h\nindex 6ae111fd..f4100f4a 100644\n--- a/src/ipa/ipu3/ipu3_awb.h\n+++ b/src/ipa/ipu3/ipu3_awb.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_IPU3_AWB_H__\n #define __LIBCAMERA_IPU3_AWB_H__\n \n+#include \"ipu3_common.h\"\n+\n #include \n \n #include \n@@ -34,15 +36,6 @@ public:\n \tvoid calculateWBGains(const ipu3_uapi_stats_3a *stats);\n \tvoid updateWbParameters(ipu3_uapi_params ¶ms, double agcGamma);\n \n-\tstruct Ipu3AwbCell {\n-\t\tunsigned char greenRedAvg;\n-\t\tunsigned char redAvg;\n-\t\tunsigned char blueAvg;\n-\t\tunsigned char greenBlueAvg;\n-\t\tunsigned char satRatio;\n-\t\tunsigned char padding[3];\n-\t} __attribute__((packed));\n-\n private:\n \tvoid generateZones(std::vector &zones);\n \tvoid generateAwbStats(const ipu3_uapi_stats_3a *stats);\ndiff --git a/src/ipa/ipu3/ipu3_common.h b/src/ipa/ipu3/ipu3_common.h\nnew file mode 100644\nindex 00000000..38ef49ce\n--- /dev/null\n+++ b/src/ipa/ipu3/ipu3_common.h\n@@ -0,0 +1,49 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * isp.h - ISP statistics interface\n+ */\n+#ifndef __LIBCAMERA_IPA_IPU3_COMMON_H__\n+#define __LIBCAMERA_IPA_IPU3_COMMON_H__\n+\n+#include \n+\n+namespace libcamera {\n+\n+namespace ipa {\n+\n+/* Region size for the statistics generation algorithm */\n+static constexpr uint32_t kAwbStatsSizeX = 16;\n+static constexpr uint32_t kAwbStatsSizeY = 12;\n+static constexpr uint32_t kAwbStatsSize = kAwbStatsSizeX * kAwbStatsSizeY + 1;\n+\n+static constexpr uint32_t kAgcStatsSizeX = 7;\n+static constexpr uint32_t kAgcStatsSizeY = 5;\n+static constexpr uint32_t kAgcStatsSize = kAgcStatsSizeX * kAgcStatsSizeY + 1;\n+static constexpr uint32_t kNumAgcWeightedZones = 15;\n+static constexpr double kCenteredWeights[kNumAgcWeightedZones] = { 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0 };\n+static constexpr uint32_t kAgcStatsRegions[kAgcStatsSize] = {\n+\t11, 9, 9, 9, 9, 9, 12,\n+\t7, 5, 3, 3, 3, 6, 8,\n+\t7, 5, 1, 0, 2, 6, 8,\n+\t7, 5, 4, 4, 4, 6, 8,\n+\t13, 10, 10, 10, 10, 10, 14\n+};\n+\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n+\n+struct Ipu3AwbCell {\n+\tunsigned char greenRedAvg;\n+\tunsigned char redAvg;\n+\tunsigned char blueAvg;\n+\tunsigned char greenBlueAvg;\n+\tunsigned char satRatio;\n+\tunsigned char padding[3];\n+} __attribute__((packed));\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPA_IPU3_COMMON_H__ */\n","prefixes":["libcamera-devel","v1","3/7"]}