{"id":12734,"url":"https://patchwork.libcamera.org/api/patches/12734/?format=json","web_url":"https://patchwork.libcamera.org/patch/12734/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210628200413.131701-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-06-28T20:04:13","name":"[libcamera-devel] libcamera: Move uneeded comment from pipeline handler","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5b7a78b6563d7eaf924df6d7c0f30b3a17831f98","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12734/mbox/","series":[{"id":2189,"url":"https://patchwork.libcamera.org/api/series/2189/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2189","date":"2021-06-28T20:04:13","name":"[libcamera-devel] libcamera: Move uneeded comment from pipeline handler","version":1,"mbox":"https://patchwork.libcamera.org/series/2189/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12734/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12734/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D4E2C3220\n\tfor ;\n\tMon, 28 Jun 2021 20:04:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10463684D4;\n\tMon, 28 Jun 2021 22:04:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E09626028C\n\tfor ;\n\tMon, 28 Jun 2021 22:04:23 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c3ad:78d0:405e:fc33])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A12DE1A;\n\tMon, 28 Jun 2021 22:04:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NDHdIv+L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624910663;\n\tbh=rSYSDO+cJVWkH3kEkgn6tZAEDo242z2dKw0YR+QTV4k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NDHdIv+Ljfw697SSwWTt2TOkHkUcSKQ2vGhedIbkHu89zTBcSqgGbQXa/OU3QTick\n\twYAWwXXIFDKySu5qHjHL5QCQ5jkO2ER8H+gZa+cboRdWq1zoqp45vPODDkyckE3o3e\n\t+0YC2hJpvStBTAHegE4VuQIife93vw5aqoTc/PdQ=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Jun 2021 22:04:13 +0200","Message-Id":"<20210628200413.131701-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Move uneeded comment from\n\tpipeline handler","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The comment is a implementation detail and does not belong to API\ndocumentation. Move it inside the function.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex f626eddd..39eed678 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -707,14 +707,14 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n \n /**\n * \\brief Retrieve the list of all pipeline handler factories\n- *\n- * The static factories map is defined inside the function to ensures it gets\n- * initialized on first use, without any dependency on link order.\n- *\n * \\return the list of pipeline handler factories\n */\n std::vector &PipelineHandlerFactory::factories()\n {\n+\t/* The static factories map is defined inside the function to ensures\n+\t * it gets initialized on first use, without any dependency on\n+\t * link order.\n+\t */\n \tstatic std::vector factories;\n \treturn factories;\n }\n","prefixes":["libcamera-devel"]}