[{"id":17907,"web_url":"https://patchwork.libcamera.org/comment/17907/","msgid":"<20210629033601.GJ2624@pyrite.rasen.tech>","date":"2021-06-29T03:36:01","subject":"Re: [libcamera-devel] [PATCH v5.1 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Andrey,\n\nOn Mon, Jun 28, 2021 at 06:16:12PM +0300, Andrey Konovalov wrote:\n> bayer_8.* vertex and fragment shaders carry the copy of the 2-Clause\n> BSD License. Replace it with the SPDX-License-Identifier.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Paul Elder \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 25 +------------------------\n> src/qcam/assets/shader/bayer_8.vert | 25 +------------------------\n> 2 files changed, 2 insertions(+), 48 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 74a6322f..a7d65e1d 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Pixel Shader\n> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n> index 3354860f..347c15f7 100644\n> --- a/src/qcam/assets/shader/bayer_8.vert\n> +++ b/src/qcam/assets/shader/bayer_8.vert\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Vertex Shader\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2811BC321F\n\tfor ;\n\tTue, 29 Jun 2021 03:36:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8330C684E8;\n\tTue, 29 Jun 2021 05:36:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0BA36028B\n\tfor ;\n\tTue, 29 Jun 2021 05:36:08 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B505C4AD;\n\tTue, 29 Jun 2021 05:36:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AYwUTGeO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624937768;\n\tbh=xOkvtW5ElmF5NlxJRLV4yve+HDuL+k+oHKoltUYZcnc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AYwUTGeO04UcbXumDkSmvExO2pM3orc41VX9uXsf6AnN/mOiq1YJFDSMCMthPv1rj\n\t/9WdPDAT3jVWbsOHbIp1Mx8QNTMxl/wyZxtS3Ne/hQtuHQJQ3PP+0lxgG6H8DlGViw\n\te+Wc/i9ftReuoN2vB41gK9ClXfwtLMOZVZ1wbAtI=","Date":"Tue, 29 Jun 2021 12:36:01 +0900","From":"paul.elder@ideasonboard.com","To":"Andrey Konovalov ","Message-ID":"<20210629033601.GJ2624@pyrite.rasen.tech>","References":"<20210628151612.4474-1-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210628151612.4474-1-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5.1 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17930,"web_url":"https://patchwork.libcamera.org/comment/17930/","msgid":"","date":"2021-06-30T01:06:14","subject":"Re: [libcamera-devel] [PATCH v5.1 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nThank you for the patch.\n\nOn Mon, Jun 28, 2021 at 06:16:12PM +0300, Andrey Konovalov wrote:\n> bayer_8.* vertex and fragment shaders carry the copy of the 2-Clause\n> BSD License. Replace it with the SPDX-License-Identifier.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 25 +------------------------\n> src/qcam/assets/shader/bayer_8.vert | 25 +------------------------\n> 2 files changed, 2 insertions(+), 48 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 74a6322f..a7d65e1d 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Pixel Shader\n> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n> index 3354860f..347c15f7 100644\n> --- a/src/qcam/assets/shader/bayer_8.vert\n> +++ b/src/qcam/assets/shader/bayer_8.vert\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Vertex Shader","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4EF4C321F\n\tfor ;\n\tWed, 30 Jun 2021 01:06:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C970684E8;\n\tWed, 30 Jun 2021 03:06:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 178ED6028A\n\tfor ;\n\tWed, 30 Jun 2021 03:06:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A94A3F2;\n\tWed, 30 Jun 2021 03:06:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lBzOuDCM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625015211;\n\tbh=PT1JM6402rqP3FtuHe6whBir8JdSK1tW7lE96Tkcb0Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lBzOuDCMdCja4WrXagBQDKOWF6VBq8NR5FPEnehkYA51JOtDjTvf95pbUCAvyQmy9\n\twlVt1adom6EFQs6f7KdiiuSvoVuXiqL3aIAqI1wNXHHnNtCiullP6JWgwLAtq9buQx\n\tXqSR3lG8UqvhN8xK96UOR7GEByZsEr/Z1bHhdAww=","Date":"Wed, 30 Jun 2021 04:06:14 +0300","From":"Laurent Pinchart ","To":"Andrey Konovalov ","Message-ID":"","References":"<20210628151612.4474-1-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210628151612.4474-1-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5.1 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]