[{"id":17849,"web_url":"https://patchwork.libcamera.org/comment/17849/","msgid":"<944d1d74-668c-1976-d96c-8ce2b819a717@ideasonboard.com>","date":"2021-06-28T04:25:15","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Log\n\tpipeline topology","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 6/28/21 12:49 AM, Laurent Pinchart wrote:\n> Log the topology for each valid discovered pipeline to aid debugging.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6ed3da423432..e214a7eb3a47 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -342,8 +342,15 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> \t/* Finally also remember the sensor. */\n> \tsensor_ = std::make_unique(sensor);\n> \tret = sensor_->init();\n> -\tif (ret)\n> +\tif (ret) {\n> \t\tsensor_.reset();\n> +\t\treturn;\n> +\t}\n> +\n> +\tLOG(SimplePipeline, Debug)\n> +\t\t<< \"Found pipeline: \"\n> +\t\t<< utils::join(entities_, \" -> \",\n> +\t\t\t [](const Entity &e) { return e.entity->name(); });\nNice handy utility function that I learnt about it today. :-)\n> }\n> \n> int SimpleCameraData::init()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37142C321A\n\tfor ;\n\tMon, 28 Jun 2021 04:25:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5DB3684D5;\n\tMon, 28 Jun 2021 06:25:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 858116028C\n\tfor ;\n\tMon, 28 Jun 2021 06:25:21 +0200 (CEST)","from [IPv6:2409:4041:2d81:a1f7:cd6e:3470:7a1e:8c71] (unknown\n\t[IPv6:2409:4041:2d81:a1f7:cd6e:3470:7a1e:8c71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A052B8A;\n\tMon, 28 Jun 2021 06:25:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rgwrZTlV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624854321;\n\tbh=b4O2IUJl3DnBWCAsi/ydQZomaNUu/TBOn7hhuvYnGK4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=rgwrZTlVP7ZZ1ShGEBFMB9Z5vj1cTahLgvCcb4IimRt5YsAWXtZId4Hns4KwFV8q1\n\tKKyrd4fjxkbIFfq2y3yD6N+AiHqgFsA9UqtjZMN/5ynwXXu2u0YW/nD6uNm57jOdE2\n\tuQUN10AoHXBi7KLyQv1izbzHYIFJ5FvP244L8AdQ=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<944d1d74-668c-1976-d96c-8ce2b819a717@ideasonboard.com>","Date":"Mon, 28 Jun 2021 09:55:15 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Log\n\tpipeline topology","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17856,"web_url":"https://patchwork.libcamera.org/comment/17856/","msgid":"<20210628045653.GU2599@pyrite.rasen.tech>","date":"2021-06-28T04:56:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Log\n\tpipeline topology","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sun, Jun 27, 2021 at 10:19:37PM +0300, Laurent Pinchart wrote:\n> Log the topology for each valid discovered pipeline to aid debugging.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6ed3da423432..e214a7eb3a47 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -342,8 +342,15 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> \t/* Finally also remember the sensor. */\n> \tsensor_ = std::make_unique(sensor);\n> \tret = sensor_->init();\n> -\tif (ret)\n> +\tif (ret) {\n> \t\tsensor_.reset();\n> +\t\treturn;\n> +\t}\n> +\n> +\tLOG(SimplePipeline, Debug)\n> +\t\t<< \"Found pipeline: \"\n> +\t\t<< utils::join(entities_, \" -> \",\n> +\t\t\t [](const Entity &e) { return e.entity->name(); });\n> }\n> \n> int SimpleCameraData::init()\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D63C0C321E\n\tfor ;\n\tMon, 28 Jun 2021 04:57:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E6F7684D5;\n\tMon, 28 Jun 2021 06:57:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD95B6028C\n\tfor ;\n\tMon, 28 Jun 2021 06:57:01 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47FF5B8A;\n\tMon, 28 Jun 2021 06:56:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VTlXs7JF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624856221;\n\tbh=b32xJDwpY8kGeo9ROroPBqK7Fe03QW4hqVp918u/Gd8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VTlXs7JFFqwPl3RIlq6J7S/fcjMwbppcG4zSXhyk0TNvvKDT2MG5H+Iz5WY3SKtSv\n\tkv+BJzZlPXobQU8cBYMRxRDm8sNRWAXVhZHXYeyJbS6n2z1iZOPrw+XxTuXTUG98OJ\n\tIDtzBSOrGpu1esfGaGqZ53qm2z4dW6WW3t2y9B98=","Date":"Mon, 28 Jun 2021 13:56:53 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210628045653.GU2599@pyrite.rasen.tech>","References":"<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210627191937.14030-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Log\n\tpipeline topology","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]