{"id":12717,"url":"https://patchwork.libcamera.org/api/patches/12717/?format=json","web_url":"https://patchwork.libcamera.org/patch/12717/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210627190009.12272-1-laurent.pinchart@ideasonboard.com>","date":"2021-06-27T19:00:09","name":"[libcamera-devel] libcamera: pipeline: simple: converter: Improve error message","commit_ref":"12809ff171aee57b306a9b29d6593793ea984ae6","pull_url":null,"state":"accepted","archived":false,"hash":"0d6fe5c26674c940a2d1f6f9907974d3d4bd7672","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12717/mbox/","series":[{"id":2180,"url":"https://patchwork.libcamera.org/api/series/2180/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2180","date":"2021-06-27T19:00:09","name":"[libcamera-devel] libcamera: pipeline: simple: converter: Improve error message","version":1,"mbox":"https://patchwork.libcamera.org/series/2180/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12717/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12717/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4E81C321A\n\tfor ;\n\tSun, 27 Jun 2021 19:00:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 248CA684D5;\n\tSun, 27 Jun 2021 21:00:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D6D6684D0\n\tfor ;\n\tSun, 27 Jun 2021 21:00:44 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E614229A\n\tfor ;\n\tSun, 27 Jun 2021 21:00:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kx1TO3uj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624820444;\n\tbh=88e8dZCHHs8sdxJ8JJn7fbtCEBYNrpveQGONakjtLyY=;\n\th=From:To:Subject:Date:From;\n\tb=Kx1TO3uj2iFsbw3wZwb4XCZYsD2xX0feGqOXzSXX3REKYRullt0s+osUOCwxxPDoW\n\tYc+VuclZMIrsPGsFXFWEjzI+4wV4aW9rqnPN/D71ywWQpf/6CxsZEvoF2YkATlhrYU\n\t3EiLYX0/Wgzj3MASq4k1tdb04sfNNis3L77/67jw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 27 Jun 2021 22:00:09 +0300","Message-Id":"<20210627190009.12272-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: simple: converter:\n\tImprove error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the configuration of the converter fails due to format mismatch,\nthe error messages only indicates that a failure occurred. Improve it to\nease debugging by printing the requested and obtained formats.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/simple/converter.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex 9af1096be834..3baf78f9364c 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -64,7 +64,9 @@ int SimpleConverter::Stream::configure(const StreamConfiguration &inputCfg,\n \tif (format.fourcc != videoFormat || format.size != inputCfg.size ||\n \t format.planes[0].bpl != inputCfg.stride) {\n \t\tLOG(SimplePipeline, Error)\n-\t\t\t<< \"Input format not supported\";\n+\t\t\t<< \"Input format not supported (requested \"\n+\t\t\t<< inputCfg.size.toString() << \"-\" << videoFormat.toString()\n+\t\t\t<< \", got \" << format.toString() << \")\";\n \t\treturn -EINVAL;\n \t}\n \n","prefixes":["libcamera-devel"]}