[{"id":17823,"web_url":"https://patchwork.libcamera.org/comment/17823/","msgid":"","date":"2021-06-27T11:55:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 25/06/2021 23:05, Laurent Pinchart wrote:\n> The device_enumerator_sysfs.h and device_enumerator_udev.h internal\n> headers are not at the correct location. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/device_enumerator.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 1f33faf5e7aa..cfd1e6b22f64 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -6,13 +6,13 @@\n> */\n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> -#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> -#include \"libcamera/internal/device_enumerator_udev.h\"\n> \n> #include \n> \n> #include \n> \n> +#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> +#include \"libcamera/internal/device_enumerator_udev.h\"\n\nI think I remember seeing these fly by, and didn't process them at the\ntime, due to the huge churn already.\n\nThere's a .clang-format update that will handle a lot of this on it's\nway, but one issue is that your hunk matcher often can't match the full\nmove, as it often sees the changes being made by clang-format as two\ndistinct hunks, and will only display one of them. I'm not yet sure what\nto do about that other than ... ignore it for now and consider the\nsingle hunk as a 'suggestion' that something has changed, rather than\nthe 'solution...\n\nThanks,\n\nReviewed-by: Kieran Bingham \n\n> #include \"libcamera/internal/media_device.h\"\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0611EC321A\n\tfor ;\n\tSun, 27 Jun 2021 11:55:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F704684D6;\n\tSun, 27 Jun 2021 13:55:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DED8684D0\n\tfor ;\n\tSun, 27 Jun 2021 13:55:22 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4AF029B;\n\tSun, 27 Jun 2021 13:55:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nm4m0UvI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624794921;\n\tbh=Szfg4NjytzVyZxikd55wTMsWdYWlUJlKzKYFqgU0TlI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Nm4m0UvIhkAfo7L7NaL1U4tUmNhNyy87d4SnRFEmW10bsoK9246PmGiByALdq6+7r\n\tfEtntWkievH4ZTBePt4WV2y7Ujn6t/CvS6MFgGMfnGnjOHpDfRUsLyoGn6zQO4FhEP\n\tK4ZxyHAjg+ITx2YE1zipXNn0LVpgBdLaVabAO7p8=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Sun, 27 Jun 2021 12:55:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17824,"web_url":"https://patchwork.libcamera.org/comment/17824/","msgid":"","date":"2021-06-27T18:13:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Sun, Jun 27, 2021 at 12:55:19PM +0100, Kieran Bingham wrote:\n> On 25/06/2021 23:05, Laurent Pinchart wrote:\n> > The device_enumerator_sysfs.h and device_enumerator_udev.h internal\n> > headers are not at the correct location. Fix it.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/device_enumerator.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > index 1f33faf5e7aa..cfd1e6b22f64 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> > @@ -6,13 +6,13 @@\n> > */\n> > \n> > #include \"libcamera/internal/device_enumerator.h\"\n> > -#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> > -#include \"libcamera/internal/device_enumerator_udev.h\"\n> > \n> > #include \n> > \n> > #include \n> > \n> > +#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> > +#include \"libcamera/internal/device_enumerator_udev.h\"\n> \n> I think I remember seeing these fly by, and didn't process them at the\n> time, due to the huge churn already.\n> \n> There's a .clang-format update that will handle a lot of this on it's\n> way, but one issue is that your hunk matcher often can't match the full\n> move, as it often sees the changes being made by clang-format as two\n> distinct hunks, and will only display one of them. I'm not yet sure what\n> to do about that other than ... ignore it for now and consider the\n> single hunk as a 'suggestion' that something has changed, rather than\n> the 'solution...\n\nIndeed. It would be nice to handle this correctly in checkstyle.py, but\nit's a rabbit hole I won't explore just yet.\n\n> Reviewed-by: Kieran Bingham \n> \n> > #include \"libcamera/internal/media_device.h\"\n> > \n> > /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B590C321D\n\tfor ;\n\tSun, 27 Jun 2021 18:13:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 621A6684D5;\n\tSun, 27 Jun 2021 20:13:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 354F1684D0\n\tfor ;\n\tSun, 27 Jun 2021 20:13:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A622E29A;\n\tSun, 27 Jun 2021 20:13:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eFiYQZJj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624817636;\n\tbh=ivmfqDa/JQwe6P7fGe9i/8BuHCdwmrisgcbGDI5BIps=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eFiYQZJjz3XFSP2wZ7IYJh08BujHC1caunItzVyDxBwvFPMoM90xIshNxwX+ixOwq\n\tnsDsLjoVc16JlAHU3w14LeMOE9am2CTZoxvmd22tBBAQr2Iiv4scvQCEePN87OCP+1\n\tQvKuQaB+n1trRVVXA3MjODaoZXCszfTfAonoM+fE=","Date":"Sun, 27 Jun 2021 21:13:24 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17858,"web_url":"https://patchwork.libcamera.org/comment/17858/","msgid":"<20210628045923.GW2599@pyrite.rasen.tech>","date":"2021-06-28T04:59:23","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sat, Jun 26, 2021 at 01:05:54AM +0300, Laurent Pinchart wrote:\n> The device_enumerator_sysfs.h and device_enumerator_udev.h internal\n> headers are not at the correct location. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/device_enumerator.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 1f33faf5e7aa..cfd1e6b22f64 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -6,13 +6,13 @@\n> */\n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> -#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> -#include \"libcamera/internal/device_enumerator_udev.h\"\n> \n> #include \n> \n> #include \n> \n> +#include \"libcamera/internal/device_enumerator_sysfs.h\"\n> +#include \"libcamera/internal/device_enumerator_udev.h\"\n> #include \"libcamera/internal/media_device.h\"\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B419C321E\n\tfor ;\n\tMon, 28 Jun 2021 04:59:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F348684D5;\n\tMon, 28 Jun 2021 06:59:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 097216028C\n\tfor ;\n\tMon, 28 Jun 2021 06:59:31 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FD3AB8A;\n\tMon, 28 Jun 2021 06:59:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"APauQkNZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624856370;\n\tbh=osj2Mk5XRRLUXM9ntjEC0fGGuLRogdKZKq2dDTdHWcE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=APauQkNZKu9ImCRG6MQ9O6xdzihoRv5QsnB340YEQjFYsbbV3+J68o7l+V3wM7xCU\n\tVcaiwWPSpFmBhqM0VD4kjeufQbe5TVnGEIyInB+wrupdzVwZiN9sOLq8fh5+ZyNQTJ\n\tmV2SgjCWmdirEtEjoUjJbNnyPd+oWTRZcPtJdmKs=","Date":"Mon, 28 Jun 2021 13:59:23 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210628045923.GW2599@pyrite.rasen.tech>","References":"<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210625220554.1261-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Fix\n\tinclude order for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]