[{"id":1691,"web_url":"https://patchwork.libcamera.org/comment/1691/","msgid":"<20190524064055.alinsiruu4vvurec@uno.localdomain>","date":"2019-05-24T06:40:55","subject":"Re: [libcamera-devel] [PATCH v2 2/3] test: v4l2_device: Extend\n\tformats test with tryFromat()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, May 23, 2019 at 02:58:59PM +0100, Kieran Bingham wrote:\n> Add a new test to verify the tryFormat() functionality updates the\n> attempted format.\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  test/v4l2_device/formats.cpp | 16 ++++++++++++++++\n>  1 file changed, 16 insertions(+)\n>\n> diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\n> index 6be045ff754c..1ed9901a9e4e 100644\n> --- a/test/v4l2_device/formats.cpp\n> +++ b/test/v4l2_device/formats.cpp\n> @@ -31,6 +31,22 @@ protected:\n>  \t\t\treturn TestFail;\n>  \t\t}\n>\n> +\t\tformat.size = { UINT_MAX, UINT_MAX };\n> +\t\tret = capture_->tryFormat(&format);\n> +\t\tif (ret) {\n> +\t\t\tcerr << \"Failed to try format: image resolution is invalid: \"\n> +\t\t\t     << \"(UINT_MAX x UINT_MAX) but setFormat() should not fail.\"\n\nnit: \"but tryFormat() should not fail\"\n\n> +\t\t\t     << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (format.size.width == UINT_MAX ||\n> +\t\t    format.size.height == UINT_MAX) {\n> +\t\t\tcerr << \"Failed to update image (try) format = (UINT_MAX x UINT_MAX)\"\n> +\t\t\t     << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n\nLooks good!\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n>  \t\tformat.size = { UINT_MAX, UINT_MAX };\n>  \t\tret = capture_->setFormat(&format);\n>  \t\tif (ret) {\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFA8B60BFD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 May 2019 08:39:48 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4890940002;\n\tFri, 24 May 2019 06:39:48 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 May 2019 08:40:55 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190524064055.alinsiruu4vvurec@uno.localdomain>","References":"<20190523135900.24029-1-kieran.bingham@ideasonboard.com>\n\t<20190523135900.24029-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"hhpkyv5xfwpd3ox2\"","Content-Disposition":"inline","In-Reply-To":"<20190523135900.24029-3-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] test: v4l2_device: Extend\n\tformats test with tryFromat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 24 May 2019 06:39:48 -0000"}}]