[{"id":17852,"web_url":"https://patchwork.libcamera.org/comment/17852/","msgid":"","date":"2021-06-28T04:29:35","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop\n\tundefined functions","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Fri, Jun 25, 2021 at 10:09 PM Laurent Pinchart\n wrote:\n>\n> The CameraBuffer::Private::planeAddr() functions are declared but not\n> defined (and of course not used). Drop them.\n>\n> Fixes: d8d6a78f223e (\"android: Introduce Chromium OS buffer manager\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/mm/cros_camera_buffer.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index c4157606d762..317d3e23687f 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -42,9 +42,6 @@ private:\n> void *addr;\n> android_ycbcr ycbcr;\n> } mem;\n> -\n> - const uint8_t *planeAddr(unsigned int plane) const;\n> - uint8_t *planeAddr(unsigned int plane);\n> };\n>\n> CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2974FC321A\n\tfor ;\n\tMon, 28 Jun 2021 04:29:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D37E6684D3;\n\tMon, 28 Jun 2021 06:29:47 +0200 (CEST)","from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com\n\t[IPv6:2a00:1450:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA016028C\n\tfor ;\n\tMon, 28 Jun 2021 06:29:45 +0200 (CEST)","by mail-ed1-x52a.google.com with SMTP id t3so2193471edt.12\n\tfor ;\n\tSun, 27 Jun 2021 21:29:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ju84bRTf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Y/FfhIigdviTDdxOr2x+x4eqbKwB4fkFU4zKDOOJ4sc=;\n\tb=ju84bRTfaSidbHTKIY2aeu+h52/0vfPGdDITGe9Dya7JKKM+7qIulTPPKMeQvfmOCI\n\tQ/rQK1EvGgLYmmkaJ4sqzz+6jpLMTHgQ75XnT2OZ54wz3zN7913511jr78Qv1+oGeLpa\n\tE6/gt0sbH80ri2dTOO5CEmqfD7JEyLAclTg68=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Y/FfhIigdviTDdxOr2x+x4eqbKwB4fkFU4zKDOOJ4sc=;\n\tb=K8iVIR5kCSHxQzJRlT1xd51iM7J2R2Z0PCglSxbJ3ex+IhlXAPlutu2O2rxZslcifr\n\tetIIFDHYPQkWd/hlMmsta6/0g0L7bEcx1YF7YK5Clb2PKdiXwOOmG0DEsbEEVPpMJf9M\n\t5oE5+872fNoZWKgNaUpZiotIXlT+t6QecTvng84jyI5lX9Mzdw6S5ocf1u35bowDhZKH\n\tQRC7nitm+W1vimTo3RM1pYd5ZcChe04vn0ECQumrU0UrlQdBfOs1Q/XyRqCgf3nuftqT\n\tqyF9pc3nfzpAXuDOCDOxizwZzUW6BAORtU2l2CEt+wDMQHsUTt5KvpoZUWhkBKcLJQ0d\n\tfEzA==","X-Gm-Message-State":"AOAM532QB0kdX+M8rT6FaCwELmPcPLwZ5+jaQOKQ9zjkPGpvCPAs1fDv\n\tTDkHTPHX4KIZPEah/JhRSankqcc3xkdVSAlgg4xWhw==","X-Google-Smtp-Source":"ABdhPJzzzkEDm32hSz3m9+PTG3JmCxXzKriO6zJ/Zmf0jQ7Bf6WO+nG2tGaOY4XsK9LXz1LcWNB219gIAgFaSCVXLqw=","X-Received":"by 2002:a05:6402:2885:: with SMTP id\n\teg5mr30642615edb.73.1624854585707; \n\tSun, 27 Jun 2021 21:29:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 28 Jun 2021 13:29:35 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop\n\tundefined functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17853,"web_url":"https://patchwork.libcamera.org/comment/17853/","msgid":"","date":"2021-06-28T04:31:53","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop\n\tundefined functions","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 6/25/21 6:38 PM, Laurent Pinchart wrote:\n> The CameraBuffer::Private::planeAddr() functions are declared but not\n> defined (and of course not used). Drop them.\n>\n> Fixes: d8d6a78f223e (\"android: Introduce Chromium OS buffer manager\")\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> \t\n> ---\n> src/android/mm/cros_camera_buffer.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index c4157606d762..317d3e23687f 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -42,9 +42,6 @@ private:\n> \t\tvoid *addr;\n> \t\tandroid_ycbcr ycbcr;\n> \t} mem;\n> -\n> -\tconst uint8_t *planeAddr(unsigned int plane) const;\n> -\tuint8_t *planeAddr(unsigned int plane);\n> };\n> \n> CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09E57C321D\n\tfor ;\n\tMon, 28 Jun 2021 04:32:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56391684D5;\n\tMon, 28 Jun 2021 06:32:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5F266028C\n\tfor ;\n\tMon, 28 Jun 2021 06:31:59 +0200 (CEST)","from [IPv6:2409:4041:2d81:a1f7:cd6e:3470:7a1e:8c71] (unknown\n\t[IPv6:2409:4041:2d81:a1f7:cd6e:3470:7a1e:8c71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D50BB8A;\n\tMon, 28 Jun 2021 06:31:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XHl5du9z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624854719;\n\tbh=TTFGQmSwm+RhezvqQTKTxbCtvqfJwD6NVd5rkm8BzhE=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=XHl5du9zkzCoMHblKn8xxGWcav+9rBU/KEW1AUiIqSaQhav/qwdqhcSfz7Ux7lW+v\n\t8emHTNa0y4p5UzjShXDUfM8W8UFMaFB0vJ2o6cIRjppql9avVXxWbC+4Jqi17KD2hV\n\tGJ5qaFjw2HucPXUxTEVq93YuT6AstIhz4utZGutg=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 28 Jun 2021 10:01:53 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop\n\tundefined functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]