[{"id":17772,"web_url":"https://patchwork.libcamera.org/comment/17772/","msgid":"","date":"2021-06-25T04:49:54","subject":"Re: [libcamera-devel] [RFC PATCH v2 3/3] android: Plumb AwbLock\n\tcontrol","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Paul, thank you for the patch.\n\nOn Thu, Jun 24, 2021 at 7:51 PM Paul Elder wrote:\n>\n> Plumb the AwbLock control into the HAL for\n> CONTROL_AWB_LOCK_AVAILABLE_MODES for static metadata.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=45\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v2:\n> - use new setMetadata\n> - rebase on camera capabilities refactor\n>\n> TODO: plumb result metadata\n> ---\n> src/android/camera_capabilities.cpp | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 212d61d9..164006f2 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -602,9 +602,14 @@ int CameraCapabilities::initializeStaticMetadata()\n> staticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> aeLockAvailable);\n>\n> - uint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n> - staticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> - awbLockAvailable);\n> + uint8_t awbLockAvailable =\n> + setMetadata(staticMetadata_.get(), ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> + controlsInfo, &controls::AwbLock,\n> + (uint8_t)ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE, Max);\n> + if (!awbLockAvailable) {\n\nawbLockAvailable == ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE\nor\nawbLockAvailable != ANDROID_CONTROL_AWB_LOCK_AVAILABLE_TRUE\n\nseems to be more right.\n\n> + capabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE] = false;\n> + capabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING] = false;\n> + }\n>\n> char availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n> staticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42AAFC321D\n\tfor ;\n\tFri, 25 Jun 2021 04:50:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74A79684CF;\n\tFri, 25 Jun 2021 06:50:06 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n\t[IPv6:2a00:1450:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC70F60508\n\tfor ;\n\tFri, 25 Jun 2021 06:50:04 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id d16so9596564ejm.7\n\tfor ;\n\tThu, 24 Jun 2021 21:50:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"guebJ0aL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=EWGuBj4wXd5oERZiXOT84V3aUxLo0433bRch9dNU2OM=;\n\tb=guebJ0aLwJXsN1qQkRePE7LFDPa5C+bIMzLkFWO/Hc26MuIf6lBKGWn9IL7ZlzMjFy\n\tP6XutRiluN6kUJH6aW0zMGubVGNEL0yH3QYmmlWmUFyiG4O7Sdt/DhbxfAavpu2UH8k9\n\thOQSyV0QDsqe5ZQwP7/uKFsJfk5At0CDEnvCs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=EWGuBj4wXd5oERZiXOT84V3aUxLo0433bRch9dNU2OM=;\n\tb=NRwDcocbi1a41LFLB30lUkeVrZR48t7/AqgW3MinhILFLSyABuKIA+ifEZIvcTOqRx\n\toJh2HTTeFuUpB3uMTFhkc9AAzCclwrOFDy5EAx53sxYrJiNpAco4sTWv01PCzQcvTOcr\n\tf0U1ARyg4g1avS7LnRu4zeZeILXAtgPZOV+8e22bBtSEYXIplQIf11mQeOW8921RZt86\n\tdKbEt/1VrU0+1BSNNzFt1E7jbmnVDNISFlq60Ow9+xBCK3sPV0WYN/mACedihaHVHZa1\n\tjdmdI/XJZyiLOJ0G4jcjfLQe/K/ld46fHXbwuHV2yZwQHPeltyybWDcWi9xdvQhldS5q\n\t3MSw==","X-Gm-Message-State":"AOAM5338lC2C1shPbP5YGj2ohPFFoAhjPeZS/EaLTDETMeLGNWb2ytUm\n\tPY/on2auAjUAurBVUd7as4/BWYsyklJcXdh1Uw84KA==","X-Google-Smtp-Source":"ABdhPJyu/tG3gFeEd2BCCPG4MZf779OLVmCL7oklT9qjBdNb/XEFI1vgkJxatPLxuTCSjJr0pP30EuIVyjUfAoLU/vw=","X-Received":"by 2002:a17:906:a20b:: with SMTP id\n\tr11mr8694396ejy.221.1624596604522; \n\tThu, 24 Jun 2021 21:50:04 -0700 (PDT)","MIME-Version":"1.0","References":"<20210624105054.51700-1-paul.elder@ideasonboard.com>\n\t<20210624105054.51700-4-paul.elder@ideasonboard.com>","In-Reply-To":"<20210624105054.51700-4-paul.elder@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Fri, 25 Jun 2021 13:49:54 +0900","Message-ID":"","To":"Paul Elder ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [RFC PATCH v2 3/3] android: Plumb AwbLock\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]