[{"id":17891,"web_url":"https://patchwork.libcamera.org/comment/17891/","msgid":"<20210628102829.GH2624@pyrite.rasen.tech>","date":"2021-06-28T10:28:29","subject":"Re: [libcamera-devel] [PATCH v5 8/9] qcam: viewfinder_gl: Add\n\tsupport for RAW8 Bayer formats","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Andrey,\n\nOn Tue, Jun 22, 2021 at 04:46:51PM +0300, Andrey Konovalov wrote:\n> This integrates the vertex and the fragment shaders by Morgan McGuire\n> into qcam.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Paul Elder \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 9 ++++---\n> src/qcam/assets/shader/bayer_8.vert | 26 ++++++++++--------\n> src/qcam/assets/shader/shaders.qrc | 2 ++\n> src/qcam/viewfinder_gl.cpp | 41 +++++++++++++++++++++++++++--\n> 4 files changed, 62 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index a7d65e1d..4ece44ab 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -9,20 +9,23 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> +\n> +Modified by Linaro Ltd to integrate it into libcamera.\n> +Copyright (C) 2021, Linaro\n> */\n> \n> //Pixel Shader\n> \n> /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n> -uniform sampler2D source;\n> +uniform sampler2D tex_y;\n> varying vec4 center;\n> varying vec4 yCoord;\n> varying vec4 xCoord;\n> \n> void main(void) {\n> - #define fetch(x, y) texture2D(source, vec2(x, y)).r\n> + #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r\n> \n> - float C = texture2D(source, center.xy).r; // ( 0, 0)\n> + float C = texture2D(tex_y, center.xy).r; // ( 0, 0)\n> const vec4 kC = vec4( 4.0, 6.0, 5.0, 5.0) / 8.0;\n> \n> // Determine which of four types of pixels we are on.\n> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n> index 347c15f7..3695a5e9 100644\n> --- a/src/qcam/assets/shader/bayer_8.vert\n> +++ b/src/qcam/assets/shader/bayer_8.vert\n> @@ -9,17 +9,22 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> +\n> +Modified by Linaro Ltd to integrate it into libcamera.\n> +Copyright (C) 2021, Linaro\n> */\n> \n> //Vertex Shader\n> \n> +attribute vec4 vertexIn;\n> +attribute vec2 textureIn;\n> \n> -/** (w,h,1/w,1/h) */\n> -uniform vec4 sourceSize;\n> +uniform vec2 tex_size;\t/* The texture size in pixels */\n> +uniform vec2 tex_step;\n> \n> /** Pixel position of the first red pixel in the */\n> /** Bayer pattern. [{0,1}, {0, 1}]*/\n> -uniform vec2 firstRed;\n> +uniform vec2 tex_bayer_first_red;\n> \n> /** .xy = Pixel being sampled in the fragment shader on the range [0, 1]\n> .zw = ...on the range [0, sourceSize], offset by firstRed */\n> @@ -34,14 +39,13 @@ varying vec4 xCoord;\n> varying vec4 yCoord;\n> \n> void main(void) {\n> - center.xy = gl_MultiTexCoord0.xy;\n> - center.zw = gl_MultiTexCoord0.xy * sourceSize.xy + firstRed;\n> + center.xy = textureIn;\n> + center.zw = textureIn * tex_size + tex_bayer_first_red;\n> \n> - vec2 invSize = sourceSize.zw;\n> - xCoord = center.x + vec4(-2.0 * invSize.x,\n> - -invSize.x, invSize.x, 2.0 * invSize.x);\n> - yCoord = center.y + vec4(-2.0 * invSize.y,\n> - -invSize.y, invSize.y, 2.0 * invSize.y);\n> + xCoord = center.x + vec4(-2.0 * tex_step.x,\n> + -tex_step.x, tex_step.x, 2.0 * tex_step.x);\n> + yCoord = center.y + vec4(-2.0 * tex_step.y,\n> + -tex_step.y, tex_step.y, 2.0 * tex_step.y);\n> \n> - gl_Position = gl_ModelViewProjectionMatrix * gl_Vertex;\n> + gl_Position = vertexIn;\n> }\n> diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc\n> index d76d65c5..96c709f9 100644\n> --- a/src/qcam/assets/shader/shaders.qrc\n> +++ b/src/qcam/assets/shader/shaders.qrc\n> @@ -6,6 +6,8 @@\n> \tYUV_3_planes.frag\n> \tYUV_packed.frag\n> \tbayer_1x_packed.frag\n> +\tbayer_8.frag\n> +\tbayer_8.vert\n> \tidentity.vert\n> \n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 6d1d80bd..e7c8620c 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -36,6 +36,11 @@ static const QList supportedFormats{\n> \tlibcamera::formats::RGBA8888,\n> \tlibcamera::formats::BGR888,\n> \tlibcamera::formats::RGB888,\n> +\t/* Raw Bayer 8-bit */\n> +\tlibcamera::formats::SBGGR8,\n> +\tlibcamera::formats::SGBRG8,\n> +\tlibcamera::formats::SGRBG8,\n> +\tlibcamera::formats::SRGGB8,\n> \t/* Raw Bayer 10-bit packed */\n> \tlibcamera::formats::SBGGR10_CSI2P,\n> \tlibcamera::formats::SGBRG10_CSI2P,\n> @@ -223,6 +228,34 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n> \t\tfragmentShaderDefines_.append(\"#define RGB_PATTERN bgr\");\n> \t\tfragmentShaderFile_ = \":RGB.frag\";\n> \t\tbreak;\n> +\tcase libcamera::formats::SBGGR8:\n> +\t\tfirstRed_.setX(1.0);\n> +\t\tfirstRed_.setY(1.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SGBRG8:\n> +\t\tfirstRed_.setX(0.0);\n> +\t\tfirstRed_.setY(1.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SGRBG8:\n> +\t\tfirstRed_.setX(1.0);\n> +\t\tfirstRed_.setY(0.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SRGGB8:\n> +\t\tfirstRed_.setX(0.0);\n> +\t\tfirstRed_.setY(0.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> \tcase libcamera::formats::SBGGR10_CSI2P:\n> \t\tfirstRed_.setX(1.0);\n> \t\tfirstRed_.setY(1.0);\n> @@ -627,6 +660,10 @@ void ViewFinderGL::doRender()\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \t\tbreak;\n> \n> +\tcase libcamera::formats::SBGGR8:\n> +\tcase libcamera::formats::SGBRG8:\n> +\tcase libcamera::formats::SGRBG8:\n> +\tcase libcamera::formats::SRGGB8:\n> \tcase libcamera::formats::SBGGR10_CSI2P:\n> \tcase libcamera::formats::SGBRG10_CSI2P:\n> \tcase libcamera::formats::SGRBG10_CSI2P:\n> @@ -636,8 +673,8 @@ void ViewFinderGL::doRender()\n> \tcase libcamera::formats::SGRBG12_CSI2P:\n> \tcase libcamera::formats::SRGGB12_CSI2P:\n> \t\t/*\n> -\t\t * Packed raw Bayer 10-bit and 12-bit formats are stored in\n> -\t\t * GL_RED texture.\n> +\t\t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n> +\t\t * are stored in GL_RED texture.\n> \t\t * The texture width is equal to the stride.\n> \t\t */\n> \t\tglActiveTexture(GL_TEXTURE0);\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2D87C3220\n\tfor ;\n\tMon, 28 Jun 2021 10:28:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A09E0684D7;\n\tMon, 28 Jun 2021 12:28:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F15F684D3\n\tfor ;\n\tMon, 28 Jun 2021 12:28:37 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CDDACC;\n\tMon, 28 Jun 2021 12:28:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wQzz+dOK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624876117;\n\tbh=xON2Vtd6xJO6iIs5aYt64FvQZillAQxmGJIqVWFgKJ4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wQzz+dOKfndTWhFjOwVPPNoxwhQ3RfXaahaZR30obEntHK3hM38Yd+cyr8ivr5ax/\n\t1cA5JEP2WfCNBKwZskzIV2/rzINNvlgCAO5+yKs3Ne+ogEuDf5H+EVJGQWzNzp9C7A\n\tdoRPcUEJt83U7G5CY1g5vDtyVLdHgJidma91addg=","Date":"Mon, 28 Jun 2021 19:28:29 +0900","From":"paul.elder@ideasonboard.com","To":"Andrey Konovalov ","Message-ID":"<20210628102829.GH2624@pyrite.rasen.tech>","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-9-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210622134652.1279260-9-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5 8/9] qcam: viewfinder_gl: Add\n\tsupport for RAW8 Bayer formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17932,"web_url":"https://patchwork.libcamera.org/comment/17932/","msgid":"","date":"2021-06-30T01:12:10","subject":"Re: [libcamera-devel] [PATCH v5 8/9] qcam: viewfinder_gl: Add\n\tsupport for RAW8 Bayer formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nThank you for the patch.\n\nOn Tue, Jun 22, 2021 at 04:46:51PM +0300, Andrey Konovalov wrote:\n> This integrates the vertex and the fragment shaders by Morgan McGuire\n> into qcam.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 9 ++++---\n> src/qcam/assets/shader/bayer_8.vert | 26 ++++++++++--------\n> src/qcam/assets/shader/shaders.qrc | 2 ++\n> src/qcam/viewfinder_gl.cpp | 41 +++++++++++++++++++++++++++--\n> 4 files changed, 62 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index a7d65e1d..4ece44ab 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -9,20 +9,23 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> +\n> +Modified by Linaro Ltd to integrate it into libcamera.\n> +Copyright (C) 2021, Linaro\n> */\n> \n> //Pixel Shader\n> \n> /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n> -uniform sampler2D source;\n> +uniform sampler2D tex_y;\n> varying vec4 center;\n> varying vec4 yCoord;\n> varying vec4 xCoord;\n> \n> void main(void) {\n> - #define fetch(x, y) texture2D(source, vec2(x, y)).r\n> + #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r\n> \n> - float C = texture2D(source, center.xy).r; // ( 0, 0)\n> + float C = texture2D(tex_y, center.xy).r; // ( 0, 0)\n> const vec4 kC = vec4( 4.0, 6.0, 5.0, 5.0) / 8.0;\n> \n> // Determine which of four types of pixels we are on.\n> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n> index 347c15f7..3695a5e9 100644\n> --- a/src/qcam/assets/shader/bayer_8.vert\n> +++ b/src/qcam/assets/shader/bayer_8.vert\n> @@ -9,17 +9,22 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> +\n> +Modified by Linaro Ltd to integrate it into libcamera.\n> +Copyright (C) 2021, Linaro\n> */\n> \n> //Vertex Shader\n> \n> +attribute vec4 vertexIn;\n> +attribute vec2 textureIn;\n> \n> -/** (w,h,1/w,1/h) */\n> -uniform vec4 sourceSize;\n> +uniform vec2 tex_size;\t/* The texture size in pixels */\n> +uniform vec2 tex_step;\n> \n> /** Pixel position of the first red pixel in the */\n> /** Bayer pattern. [{0,1}, {0, 1}]*/\n> -uniform vec2 firstRed;\n> +uniform vec2 tex_bayer_first_red;\n> \n> /** .xy = Pixel being sampled in the fragment shader on the range [0, 1]\n> .zw = ...on the range [0, sourceSize], offset by firstRed */\n> @@ -34,14 +39,13 @@ varying vec4 xCoord;\n> varying vec4 yCoord;\n> \n> void main(void) {\n> - center.xy = gl_MultiTexCoord0.xy;\n> - center.zw = gl_MultiTexCoord0.xy * sourceSize.xy + firstRed;\n> + center.xy = textureIn;\n> + center.zw = textureIn * tex_size + tex_bayer_first_red;\n> \n> - vec2 invSize = sourceSize.zw;\n> - xCoord = center.x + vec4(-2.0 * invSize.x,\n> - -invSize.x, invSize.x, 2.0 * invSize.x);\n> - yCoord = center.y + vec4(-2.0 * invSize.y,\n> - -invSize.y, invSize.y, 2.0 * invSize.y);\n> + xCoord = center.x + vec4(-2.0 * tex_step.x,\n> + -tex_step.x, tex_step.x, 2.0 * tex_step.x);\n> + yCoord = center.y + vec4(-2.0 * tex_step.y,\n> + -tex_step.y, tex_step.y, 2.0 * tex_step.y);\n> \n> - gl_Position = gl_ModelViewProjectionMatrix * gl_Vertex;\n> + gl_Position = vertexIn;\n> }\n> diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc\n> index d76d65c5..96c709f9 100644\n> --- a/src/qcam/assets/shader/shaders.qrc\n> +++ b/src/qcam/assets/shader/shaders.qrc\n> @@ -6,6 +6,8 @@\n> \tYUV_3_planes.frag\n> \tYUV_packed.frag\n> \tbayer_1x_packed.frag\n> +\tbayer_8.frag\n> +\tbayer_8.vert\n> \tidentity.vert\n> \n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 6d1d80bd..e7c8620c 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -36,6 +36,11 @@ static const QList supportedFormats{\n> \tlibcamera::formats::RGBA8888,\n> \tlibcamera::formats::BGR888,\n> \tlibcamera::formats::RGB888,\n> +\t/* Raw Bayer 8-bit */\n> +\tlibcamera::formats::SBGGR8,\n> +\tlibcamera::formats::SGBRG8,\n> +\tlibcamera::formats::SGRBG8,\n> +\tlibcamera::formats::SRGGB8,\n> \t/* Raw Bayer 10-bit packed */\n> \tlibcamera::formats::SBGGR10_CSI2P,\n> \tlibcamera::formats::SGBRG10_CSI2P,\n> @@ -223,6 +228,34 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n> \t\tfragmentShaderDefines_.append(\"#define RGB_PATTERN bgr\");\n> \t\tfragmentShaderFile_ = \":RGB.frag\";\n> \t\tbreak;\n> +\tcase libcamera::formats::SBGGR8:\n> +\t\tfirstRed_.setX(1.0);\n> +\t\tfirstRed_.setY(1.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SGBRG8:\n> +\t\tfirstRed_.setX(0.0);\n> +\t\tfirstRed_.setY(1.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SGRBG8:\n> +\t\tfirstRed_.setX(1.0);\n> +\t\tfirstRed_.setY(0.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> +\tcase libcamera::formats::SRGGB8:\n> +\t\tfirstRed_.setX(0.0);\n> +\t\tfirstRed_.setY(0.0);\n> +\t\tvertexShaderFile_ = \":bayer_8.vert\";\n> +\t\tfragmentShaderFile_ = \":bayer_8.frag\";\n> +\t\ttextureMinMagFilters_ = GL_NEAREST;\n> +\t\tbreak;\n> \tcase libcamera::formats::SBGGR10_CSI2P:\n> \t\tfirstRed_.setX(1.0);\n> \t\tfirstRed_.setY(1.0);\n> @@ -627,6 +660,10 @@ void ViewFinderGL::doRender()\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \t\tbreak;\n> \n> +\tcase libcamera::formats::SBGGR8:\n> +\tcase libcamera::formats::SGBRG8:\n> +\tcase libcamera::formats::SGRBG8:\n> +\tcase libcamera::formats::SRGGB8:\n> \tcase libcamera::formats::SBGGR10_CSI2P:\n> \tcase libcamera::formats::SGBRG10_CSI2P:\n> \tcase libcamera::formats::SGRBG10_CSI2P:\n> @@ -636,8 +673,8 @@ void ViewFinderGL::doRender()\n> \tcase libcamera::formats::SGRBG12_CSI2P:\n> \tcase libcamera::formats::SRGGB12_CSI2P:\n> \t\t/*\n> -\t\t * Packed raw Bayer 10-bit and 12-bit formats are stored in\n> -\t\t * GL_RED texture.\n> +\t\t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n> +\t\t * are stored in GL_RED texture.\n> \t\t * The texture width is equal to the stride.\n> \t\t */\n> \t\tglActiveTexture(GL_TEXTURE0);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 296A9C3220\n\tfor ;\n\tWed, 30 Jun 2021 01:12:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A49C9684E8;\n\tWed, 30 Jun 2021 03:12:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B217D6028A\n\tfor ;\n\tWed, 30 Jun 2021 03:12:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FFA73F2;\n\tWed, 30 Jun 2021 03:12:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MzKPMbN0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625015568;\n\tbh=XQCfPlfHkorPN0BccgUr8y7umYx2G5GpAGiN62W2rps=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MzKPMbN0tKxg0BTu/BK8y6T2uqdM3gElKhmyM2Y6CHTk/RgdFFb03UXQLXSXV9O1D\n\tMR5t40Ang+wAC60TekVV1Y83m1OI8Imf4X075eqJaka/+OrIRRV0yZV9OwyJRlpRug\n\tNiDsmsfFJ1TNvjn9PBq3OXrdYa4kdV81sBSEccmI=","Date":"Wed, 30 Jun 2021 04:12:10 +0300","From":"Laurent Pinchart ","To":"Andrey Konovalov ","Message-ID":"","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-9-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210622134652.1279260-9-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5 8/9] qcam: viewfinder_gl: Add\n\tsupport for RAW8 Bayer formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]