[{"id":17889,"web_url":"https://patchwork.libcamera.org/comment/17889/","msgid":"<20210628102725.GF2624@pyrite.rasen.tech>","date":"2021-06-28T10:27:25","subject":"Re: [libcamera-devel] [PATCH v5 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Andrey,\n\nI think there should still be some changelog, even if just one line\nthat's practically the same as the subject.\n\nOn Tue, Jun 22, 2021 at 04:46:49PM +0300, Andrey Konovalov wrote:\n> Signed-off-by: Andrey Konovalov \n> ---\n> src/qcam/assets/shader/bayer_8.frag | 25 +------------------------\n> src/qcam/assets/shader/bayer_8.vert | 25 +------------------------\n> 2 files changed, 2 insertions(+), 48 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 74a6322f..a7d65e1d 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Pixel Shader\n> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n> index 3354860f..347c15f7 100644\n> --- a/src/qcam/assets/shader/bayer_8.vert\n> +++ b/src/qcam/assets/shader/bayer_8.vert\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> From http://jgt.akpeters.com/papers/McGuire08/\n> \n> @@ -8,30 +9,6 @@ Morgan McGuire\n> This paper appears in issue Volume 13, Number 4.\n> ---------------------------------------------------------\n> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n> -\n> -Redistribution and use in source and binary forms, with or without\n> -modification, are permitted provided that the following conditions are\n> -met:\n> -\n> - * Redistributions of source code must retain the above copyright\n> - notice, this list of conditions and the following disclaimer.\n> -\n> - * Redistributions in binary form must reproduce the above\n> - copyright notice, this list of conditions and the following\n> - disclaimer in the documentation and/or other materials provided\n> - with the distribution.\n> -\n> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> */\n> \n> //Vertex Shader\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 072ACC3220\n\tfor ;\n\tMon, 28 Jun 2021 10:27:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1B67684D7;\n\tMon, 28 Jun 2021 12:27:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07AEC684D3\n\tfor ;\n\tMon, 28 Jun 2021 12:27:34 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8E49CC;\n\tMon, 28 Jun 2021 12:27:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VB1BMMvY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624876053;\n\tbh=VbqrB9Odn/dn+XFo9CRpAj3nDuRFdclV/BLVK3nDPcE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VB1BMMvYDwOhsi0T45xVhIJi5J4QWy0EztkWABHN8+v/Yn01tug/nIX+KrP7GHeD5\n\t1eSr8gNhkgOXrZkoPXhHrpgsJ0CT0FZEhRMOCjJ/ixpRg+qGQS9iyBTOmOxGaj1T7i\n\tDqQvz+3eJqHKEGBqz6DYTTfHqZa8PWUYIV8r1dCU=","Date":"Mon, 28 Jun 2021 19:27:25 +0900","From":"paul.elder@ideasonboard.com","To":"Andrey Konovalov ","Message-ID":"<20210628102725.GF2624@pyrite.rasen.tech>","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-7-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210622134652.1279260-7-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17895,"web_url":"https://patchwork.libcamera.org/comment/17895/","msgid":"<764cec22-5125-9bd0-a296-8b5b4ec0dbb3@linaro.org>","date":"2021-06-28T15:13:30","subject":"Re: [libcamera-devel] [PATCH v5 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Paul,\n\nThank you for reviewing the patchset!\n\nOn 28.06.2021 13:27, paul.elder@ideasonboard.com wrote:\n> Hi Andrey,\n> \n> I think there should still be some changelog, even if just one line\n> that's practically the same as the subject.\n\nOK. I'll send the v5.1 version of this patch with a commit description.\n\nThanks,\nAndrey\n\n> On Tue, Jun 22, 2021 at 04:46:49PM +0300, Andrey Konovalov wrote:\n>> Signed-off-by: Andrey Konovalov \n>> ---\n>> src/qcam/assets/shader/bayer_8.frag | 25 +------------------------\n>> src/qcam/assets/shader/bayer_8.vert | 25 +------------------------\n>> 2 files changed, 2 insertions(+), 48 deletions(-)\n>>\n>> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n>> index 74a6322f..a7d65e1d 100644\n>> --- a/src/qcam/assets/shader/bayer_8.frag\n>> +++ b/src/qcam/assets/shader/bayer_8.frag\n>> @@ -1,3 +1,4 @@\n>> +/* SPDX-License-Identifier: BSD-2-Clause */\n>> /*\n>> From http://jgt.akpeters.com/papers/McGuire08/\n>> \n>> @@ -8,30 +9,6 @@ Morgan McGuire\n>> This paper appears in issue Volume 13, Number 4.\n>> ---------------------------------------------------------\n>> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n>> -\n>> -Redistribution and use in source and binary forms, with or without\n>> -modification, are permitted provided that the following conditions are\n>> -met:\n>> -\n>> - * Redistributions of source code must retain the above copyright\n>> - notice, this list of conditions and the following disclaimer.\n>> -\n>> - * Redistributions in binary form must reproduce the above\n>> - copyright notice, this list of conditions and the following\n>> - disclaimer in the documentation and/or other materials provided\n>> - with the distribution.\n>> -\n>> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n>> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n>> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n>> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n>> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n>> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n>> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n>> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n>> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n>> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n>> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n>> */\n>> \n>> //Pixel Shader\n>> diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\n>> index 3354860f..347c15f7 100644\n>> --- a/src/qcam/assets/shader/bayer_8.vert\n>> +++ b/src/qcam/assets/shader/bayer_8.vert\n>> @@ -1,3 +1,4 @@\n>> +/* SPDX-License-Identifier: BSD-2-Clause */\n>> /*\n>> From http://jgt.akpeters.com/papers/McGuire08/\n>> \n>> @@ -8,30 +9,6 @@ Morgan McGuire\n>> This paper appears in issue Volume 13, Number 4.\n>> ---------------------------------------------------------\n>> Copyright (c) 2008, Morgan McGuire. All rights reserved.\n>> -\n>> -Redistribution and use in source and binary forms, with or without\n>> -modification, are permitted provided that the following conditions are\n>> -met:\n>> -\n>> - * Redistributions of source code must retain the above copyright\n>> - notice, this list of conditions and the following disclaimer.\n>> -\n>> - * Redistributions in binary form must reproduce the above\n>> - copyright notice, this list of conditions and the following\n>> - disclaimer in the documentation and/or other materials provided\n>> - with the distribution.\n>> -\n>> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n>> -\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n>> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n>> -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n>> -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n>> -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n>> -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n>> -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n>> -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n>> -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n>> -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n>> */\n>> \n>> //Vertex Shader\n>> -- \n>> 2.25.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E43F2C321F\n\tfor ;\n\tMon, 28 Jun 2021 15:13:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 804D6684D4;\n\tMon, 28 Jun 2021 17:13:34 +0200 (CEST)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CBA06028C\n\tfor ;\n\tMon, 28 Jun 2021 17:13:32 +0200 (CEST)","by mail-lj1-x22d.google.com with SMTP id w11so5616696ljh.0\n\tfor ;\n\tMon, 28 Jun 2021 08:13:32 -0700 (PDT)","from [192.168.88.254] ([85.249.44.185])\n\tby smtp.gmail.com with ESMTPSA id\n\tm23sm1457548lfq.230.2021.06.28.08.13.30\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 28 Jun 2021 08:13:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DCj+XckZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=9DxgKOWk8x4GhNIXA94yshbTiu64NZa+AMsu7CUGta0=;\n\tb=DCj+XckZf0i4+VG6AJ5Wl2mqZ+RzDcmMFDafkuhMnaIE8kDw7IAn/roKgeBfan2TfZ\n\tVfMqGnwvWUWQB+MjgUlKl9rMTMxRhmrywcJOERsERz7lSD+mQwbfIald3PDd570lma+q\n\tfKHRuaJNica5vk68N7QX9roszv7WHpRvr5fN1cyzNE+L/QG5uY5CLfGYaplCBH4k4mrO\n\tRK4stxX6djM9PB+e8oH/y62Tw/f66taB7inURi7EI+G7SUCIzBOFP+TlGuAvoGkCm+26\n\t3Qx1mDf6Flg8Ljxd5E5x7M7AYp1zj+5bxgnkMoz3Vo3Ipp7XDzLehxviqYJoqjl31Qhb\n\t39Gg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=9DxgKOWk8x4GhNIXA94yshbTiu64NZa+AMsu7CUGta0=;\n\tb=NWM2rYFUD+b2F3aBkLmwShlXO1Y3EW7fGfGfed6JFpv01OUXt27kgzGAZc15X03E2P\n\tKEVV103Bw9EAXTN5J7dBoC2lqsRakUx+gCsG0wiZeqi6glU4DOLJ88dv9jhIUm6gDwRD\n\tn9lfnXAdI7GzQZHD9SfMXHSkrmnkq/RkCJGPK+IZ/oGzraYXEJsJefOJkARIPjr4P3dO\n\trbxoIWtBxEaI/XpCTnh5BSZKiiLcLmT2s7pIPRK/fuT0EHz7HQXTnCY8qQuSI1mPNHyT\n\tI7gHEtJlqflFyoPglb0gv1lPz6dvh6nfCv0vMdKjp2i87W5MAJoWr4Sl2A7QJSH8lUAA\n\txoZA==","X-Gm-Message-State":"AOAM531hl0UZzFyehbQy9H/cI4LNW7v3EvOYNd6lk0lrQn9qbiepbUAz\n\tLV+TFJPbl7Uw0mbLzDk5NZl8kQ==","X-Google-Smtp-Source":"ABdhPJzUrb/Xm8H7RFVHHdg82gariCY27YODp8IpbBR+XjZI6G9lyisLd5Q0D+8cnGQKxHgwyPQrMQ==","X-Received":"by 2002:a2e:3507:: with SMTP id z7mr3871994ljz.460.1624893211853;\n\tMon, 28 Jun 2021 08:13:31 -0700 (PDT)","To":"paul.elder@ideasonboard.com","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-7-andrey.konovalov@linaro.org>\n\t<20210628102725.GF2624@pyrite.rasen.tech>","From":"Andrey Konovalov ","Message-ID":"<764cec22-5125-9bd0-a296-8b5b4ec0dbb3@linaro.org>","Date":"Mon, 28 Jun 2021 18:13:30 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210628102725.GF2624@pyrite.rasen.tech>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 6/9] qcam: viewfinder_gl: use\n\tSPDX-License-Identifier in bayer_8.* shaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]