[{"id":17888,"web_url":"https://patchwork.libcamera.org/comment/17888/","msgid":"<20210628102603.GE2624@pyrite.rasen.tech>","date":"2021-06-28T10:26:03","subject":"Re: [libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong\n\tcomment in bayer_8.frag","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Andrey,\n\nOn Tue, Jun 22, 2021 at 04:46:48PM +0300, Andrey Konovalov wrote:\n> Fetching into value[2] corresponds to E0, and fetching into value[3] - to\n> F0. The fetch()-es themselves are correct, but the comments were not.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Paul Elder \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 707e76ed..74a6322f 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -68,8 +68,8 @@ void main(void) {\n> vec4 value = vec4(\n> fetch(center.x, yCoord[0]), // ( 0,-2)\n> fetch(center.x, yCoord[1]), // ( 0,-1)\n> - fetch(xCoord[0], center.y), // (-1, 0)\n> - fetch(xCoord[1], center.y)); // (-2, 0)\n> + fetch(xCoord[0], center.y), // (-2, 0)\n> + fetch(xCoord[1], center.y)); // (-1, 0)\n> \n> vec4 temp = vec4(\n> fetch(center.x, yCoord[3]), // ( 0, 2)\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B058CC3220\n\tfor ;\n\tMon, 28 Jun 2021 10:26:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAD70684D4;\n\tMon, 28 Jun 2021 12:26:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6946C6028C\n\tfor ;\n\tMon, 28 Jun 2021 12:26:11 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 314F4CC;\n\tMon, 28 Jun 2021 12:26:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wgyXo+CM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624875971;\n\tbh=dZ+x+4ickIsXQmMzqJMNSJW/2QkTkTa7UA/cgKvNPt0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wgyXo+CMo8iUAVzNw2UkbrD1b3zXD3uHrzp/VwZFC0fRg84047NrfLMRh++Mto2UK\n\t0nl8ADDpgybvULtWAI0c9iRKehKBXWsax+hZs0WJQAcrdBEQhY168o8FwHtUbSWoml\n\tePD2qK/Kon8VqH2JuM4attmF6zWV/Z8T2090jufQ=","Date":"Mon, 28 Jun 2021 19:26:03 +0900","From":"paul.elder@ideasonboard.com","To":"Andrey Konovalov ","Message-ID":"<20210628102603.GE2624@pyrite.rasen.tech>","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-6-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210622134652.1279260-6-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong\n\tcomment in bayer_8.frag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17929,"web_url":"https://patchwork.libcamera.org/comment/17929/","msgid":"","date":"2021-06-30T01:04:19","subject":"Re: [libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong\n\tcomment in bayer_8.frag","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nThank you for the patch.\n\nOn Tue, Jun 22, 2021 at 04:46:48PM +0300, Andrey Konovalov wrote:\n> Fetching into value[2] corresponds to E0, and fetching into value[3] - to\n> F0. The fetch()-es themselves are correct, but the comments were not.\n> \n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/assets/shader/bayer_8.frag | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 707e76ed..74a6322f 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -68,8 +68,8 @@ void main(void) {\n> vec4 value = vec4(\n> fetch(center.x, yCoord[0]), // ( 0,-2)\n> fetch(center.x, yCoord[1]), // ( 0,-1)\n> - fetch(xCoord[0], center.y), // (-1, 0)\n> - fetch(xCoord[1], center.y)); // (-2, 0)\n> + fetch(xCoord[0], center.y), // (-2, 0)\n> + fetch(xCoord[1], center.y)); // (-1, 0)\n> \n> vec4 temp = vec4(\n> fetch(center.x, yCoord[3]), // ( 0, 2)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34588C3220\n\tfor ;\n\tWed, 30 Jun 2021 01:05:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E044684E8;\n\tWed, 30 Jun 2021 03:04:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 902776028A\n\tfor ;\n\tWed, 30 Jun 2021 03:04:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01D383F2;\n\tWed, 30 Jun 2021 03:04:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PX4NG0zm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625015097;\n\tbh=hDTFP2QG8YOYm4FpOBTcqUIMb7quq3CJ26hLdVnZ1ZE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PX4NG0zm7nVg3en2NmQ5bLEKotSfGpOuvrYwftBpSGKt7Iof9Hjf95Z5PlfIRiRPx\n\tfk8K0X+3DfjsZnQBiVtETMsS+f6duyq8psdV3/IE9aQ6Bax6FFeumuKEdZF1nBKah8\n\tlGT+O3C26tWDV3m2HyZIO30QBLLtUBrU5/v9eJ5E=","Date":"Wed, 30 Jun 2021 04:04:19 +0300","From":"Laurent Pinchart ","To":"Andrey Konovalov ","Message-ID":"","References":"<20210622134652.1279260-1-andrey.konovalov@linaro.org>\n\t<20210622134652.1279260-6-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210622134652.1279260-6-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong\n\tcomment in bayer_8.frag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]