{"id":12680,"url":"https://patchwork.libcamera.org/api/patches/12680/?format=json","web_url":"https://patchwork.libcamera.org/patch/12680/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210622094523.42915-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-06-22T09:45:23","name":"[libcamera-devel,v6,2/2] ipa: ipu3: Initialize CameraSensorHelper at IPU3 init stage","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e1a8e458dc4b0cf18c8b3281975c4f914de3ecd8","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12680/mbox/","series":[{"id":2166,"url":"https://patchwork.libcamera.org/api/series/2166/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2166","date":"2021-06-22T09:45:21","name":"libipa: Add support for a new sensor helper","version":6,"mbox":"https://patchwork.libcamera.org/series/2166/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12680/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12680/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 583B8C321A\n\tfor ;\n\tTue, 22 Jun 2021 09:45:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE0F56893A;\n\tTue, 22 Jun 2021 11:45:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 471C268936\n\tfor ;\n\tTue, 22 Jun 2021 11:45:28 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:59b9:69b1:8141:7f28])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C240EBBE;\n\tTue, 22 Jun 2021 11:45:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"veaZFVOn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624355127;\n\tbh=pZqR5s4wrPBoWxVGaYAbdsUMKphAMMMhbIWgKfHElVs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=veaZFVOnordn7uULI7Fb1L8s7stwJH0dKpNcWqEYtsDhduOIBJmJp0+K/RZ9tJXlh\n\tLs/Q0dYXl2GisveDqjzMQ9juMHsm2jGqqZERJPE5kHHL+DUR6n2+KpAZN8zNZSVHBY\n\t8Vthjle9X4kkJ8sDaGIU77kX6OuAryLBjd0f1dqg=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Jun 2021 11:45:23 +0200","Message-Id":"<20210622094523.42915-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210622094523.42915-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210622094523.42915-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 2/2] ipa: ipu3: Initialize\n\tCameraSensorHelper at IPU3 init stage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order for the CameraSensorHelper to be instantiated, we need to find\nits factory using the camera sensor model name stored in\nIPASettings::sensorModel. As we don't need to do it at each configure\ncall (the sensor is not changing in-between), implement the init call in\nIPAIPU3 to do that.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Umang Jain \nReviewed-by: Jacopo Mondi \n---\n src/ipa/ipu3/ipu3.cpp | 19 +++++++++++++++----\n 1 file changed, 15 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 8b4c7351..0a557825 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -23,6 +23,7 @@\n \n #include \"ipu3_agc.h\"\n #include \"ipu3_awb.h\"\n+#include \"libipa/camera_sensor_helper.h\"\n \n static constexpr uint32_t kMaxCellWidthPerSet = 160;\n static constexpr uint32_t kMaxCellHeightPerSet = 56;\n@@ -36,10 +37,7 @@ namespace ipa::ipu3 {\n class IPAIPU3 : public IPAIPU3Interface\n {\n public:\n-\tint init([[maybe_unused]] const IPASettings &settings) override\n-\t{\n-\t\treturn 0;\n-\t}\n+\tint init(const IPASettings &settings) override;\n \tint start() override;\n \tvoid stop() override {}\n \n@@ -78,6 +76,8 @@ private:\n \tstd::unique_ptr awbAlgo_;\n \t/* Interface to the AEC/AGC algorithm */\n \tstd::unique_ptr agcAlgo_;\n+\t/* Interface to the Camera Helper */\n+\tstd::unique_ptr camHelper_;\n \n \t/* Local parameter storage */\n \tstruct ipu3_uapi_params params_;\n@@ -85,6 +85,17 @@ private:\n \tstruct ipu3_uapi_grid_config bdsGrid_;\n };\n \n+int IPAIPU3::init(const IPASettings &settings)\n+{\n+\tcamHelper_ = CameraSensorHelperFactory::create(settings.sensorModel);\n+\tif (camHelper_ == nullptr) {\n+\t\tLOG(IPAIPU3, Error) << \"Failed to create camera sensor helper for \" << settings.sensorModel;\n+\t\treturn -ENODEV;\n+\t}\n+\n+\treturn 0;\n+}\n+\n int IPAIPU3::start()\n {\n \tsetControls(0);\n","prefixes":["libcamera-devel","v6","2/2"]}