[{"id":17702,"web_url":"https://patchwork.libcamera.org/comment/17702/","msgid":"<20210623031816.GB1967419@pyrite.rasen.tech>","date":"2021-06-23T03:18:16","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Fix V4L2 pixel format\n\tmapping for XRGB32 and RGBX32","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nOn Tue, Jun 22, 2021 at 01:04:33PM +0530, Vedant Paranjape wrote:\n> On running libcamera gstreamer element on Raspberry Pi 4B+, there was a\n> warning as follows:\n> \n> [3:23:59.717513107] [3577] WARN V4L2 v4l2_pixelformat.cpp:180 Unsupported V4L2 pixel format XB24\n> \n> This patch fixes the following warning, by updating the existing\n> mapping of V4L2_PIX_FMT_XRGB32 to libcamera pixel format. Additionally,\n> adds a new mapping of V4L2_PIX_FMT_RBGX32 to formats::XBGR8888\n> \n> This patch does the following changes:\n> - add the BGRX8888 format in libcamera\n> - fix the mapping of XRGB32 to BGRX8888\n> - fix the mapping of RGBX32 to XBGR8888\n\nI was listing these to make it clear what was going on. The last two\npoints are redundant as you already mention them above.\n\n\nPaul\n\n> \n> Signed-off-by: Vedant Paranjape \n> ---\n> src/libcamera/formats.cpp | 12 +++++++++++-\n> src/libcamera/v4l2_pixelformat.cpp | 3 ++-\n> 2 files changed, 13 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 55822f4c..e41bfc05 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -198,13 +198,23 @@ const std::map pixelFormatInfo{\n> \t{ formats::XBGR8888, {\n> \t\t.name = \"XBGR8888\",\n> \t\t.format = formats::XBGR8888,\n> -\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n> \t\t.bitsPerPixel = 32,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::BGRX8888, {\n> +\t\t.name = \"BGRX8888\",\n> +\t\t.format = formats::BGRX8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\t\n> \t{ formats::ABGR8888, {\n> \t\t.name = \"ABGR8888\",\n> \t\t.format = formats::ABGR8888,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 166d93cf..78a08303 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -51,7 +51,8 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> -\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::BGRX8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7DD2C321A\n\tfor ;\n\tWed, 23 Jun 2021 03:18:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 307AA68932;\n\tWed, 23 Jun 2021 05:18:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 745EF6050A\n\tfor ;\n\tWed, 23 Jun 2021 05:18:25 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1C949B1;\n\tWed, 23 Jun 2021 05:18:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IMp+NH3Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624418305;\n\tbh=f/9B8tVDOCgmYpIEyHh6zpc3nsRomf5SOUm18qaeYQY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IMp+NH3Zgj24YPxlPwbc/nAMj/EQARnDjOOB4Yve6Oq+pCczLWARm5e7gHbjarJxN\n\tXtzpotUsC0GEPUTv6L4z7UT4aEORJpYmpgJewJANMzFs+fanazb/IFxreXyma+nJJT\n\tifCStbJg+ghiOMJsBX6wrtYy8sx6qeZDSrzYRtqE=","Date":"Wed, 23 Jun 2021 12:18:16 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210623031816.GB1967419@pyrite.rasen.tech>","References":"<20210622073433.61678-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210622073433.61678-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Fix V4L2 pixel format\n\tmapping for XRGB32 and RGBX32","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]