{"id":12674,"url":"https://patchwork.libcamera.org/api/patches/12674/?format=json","web_url":"https://patchwork.libcamera.org/patch/12674/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210622023654.969162-3-hiroh@chromium.org>","date":"2021-06-22T02:36:52","name":"[libcamera-devel,RFC,v2,3/5] libcamera: ipu3: Disable a sensor test pattern mode at initialization","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e51f9418711f201b48d3ece076cc29e8eb5af956","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12674/mbox/","series":[{"id":2164,"url":"https://patchwork.libcamera.org/api/series/2164/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2164","date":"2021-06-22T02:36:50","name":"[libcamera-devel,RFC,v2,1/5] libcamera: camera_sensor: Reverse the key and value of test pattern mode map","version":2,"mbox":"https://patchwork.libcamera.org/series/2164/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12674/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12674/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18C59C321B\n\tfor ;\n\tTue, 22 Jun 2021 02:37:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F0156893C;\n\tTue, 22 Jun 2021 04:37:06 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB96468935\n\tfor ;\n\tTue, 22 Jun 2021 04:37:03 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id x22so8118412pll.11\n\tfor ;\n\tMon, 21 Jun 2021 19:37:03 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:a025:f98b:b63b:e6b2])\n\tby smtp.gmail.com with ESMTPSA id\n\to7sm18947145pgs.45.2021.06.21.19.37.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Jun 2021 19:37:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"J0Ma+yPD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PEUhCurabQ7SLRxMeXHtynWRRCGWPJc8pvJwqNePAac=;\n\tb=J0Ma+yPDbMQW5H1GeOrTkSTsvngKbe/bBk7v/WMZjj5SuK6WiNxoYLt7g9KtpGmc5y\n\tBO0Bvr8Y15D9wDwmcWh8f6WUKH/iXGug4Llg5ZlTZD5SwasEgzgx0+2ub0W29bFHtFmH\n\tI0Cfme7Ahp5kEj5kns/YhmdXh1JIn7/IKhSw8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PEUhCurabQ7SLRxMeXHtynWRRCGWPJc8pvJwqNePAac=;\n\tb=HcV4a/obObSmCNOtCLFnuEbDLD6RM80Q0ybJDT0oIHyfrsTPKgjEuVUZ9TZmqrGcmY\n\tKCoODwakv+Xlc4uVmz4G027B4i2ow5rv4wnUUcRDe094ZRU4R9LIjATDqKWil0Va9t77\n\t/LlZBs22nyyg0Dg9gSLO+e2hzT2MbZdLdUaj8odka81kCTNw9HlR5PoNPGLlDatu1yie\n\tsti6QtXwqZ5R4Jar6MuabZDtsDktmnqjZ6Xrj+jULB010Ln7hsS9rDliDK+TtyZcIxtP\n\tIwJX9N9Jn/QknYCh/ESdlWPm3f4UX/nLRB7q9s9tXVtglbpi7OUslhr9MyMk8Z2SFQvR\n\tQJmg==","X-Gm-Message-State":"AOAM533lV0hkZS03jmAQTCHLDhoA9xuvnUR8wCF8Yi3Krd2/HgLOl7Ju\n\trK82ZvqMHpk8wIPL9uSAoF737OJ7PioXlw==","X-Google-Smtp-Source":"ABdhPJzga2SI3nXeU4VtmBvkSVUWLAXIHV/zh+GGZqDWez27ut+ZFgOKAll6pHh8dnq/iE8l3JqHkA==","X-Received":"by 2002:a17:902:c613:b029:122:641e:8720 with SMTP id\n\tr19-20020a170902c613b0290122641e8720mr16001817plr.41.1624329422342; \n\tMon, 21 Jun 2021 19:37:02 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Jun 2021 11:36:52 +0900","Message-Id":"<20210622023654.969162-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.32.0.288.g62a8d224e6-goog","In-Reply-To":"<20210622023654.969162-1-hiroh@chromium.org>","References":"<20210622023654.969162-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 3/5] libcamera: ipu3: Disable a\n\tsensor test pattern mode at initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Turns off a sensor test pattern mode at the initialization of the\nsensor. Without this, the camera sensor is configured with the last\ntest pattern mode that has been set.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex 1be2cbcd..8548f749 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -9,6 +9,7 @@\n \n #include \n \n+#include \n #include \n #include \n #include \n@@ -192,6 +193,13 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n \n \tLOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat->toString();\n \n+\tret = sensor_->setTestPatternMode(controls::draft::TestPatternModeOff);\n+\tif (ret) {\n+\t\tLOG(IPU3, Error)\n+\t\t\t<< \"Failed to reset test pattern mode: \" << ret;\n+\t\treturn ret;\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","RFC","v2","3/5"]}