[{"id":17675,"web_url":"https://patchwork.libcamera.org/comment/17675/","msgid":"<20210622040639.GD1899306@pyrite.rasen.tech>","date":"2021-06-22T04:06:39","subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Add OV5647 sensor\n\tproperties","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nOn Tue, Jun 22, 2021 at 01:34:26AM +0530, Vedant Paranjape wrote:\n> Brief specifications available at\n> https://cdn.sparkfun.com/datasheets/Dev/RaspberryPi/ov5647_full.pdf\n> \n> > pixel size: 1.4 μm x 1.4 μm\n> \n> Change in this patch is referenced from Page 5: key specifications\n> section of the above linked pdf\n> \n> Signed-off-by: Vedant Paranjape \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index f660743a..fc4ea78d 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -81,6 +81,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov5647\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"ov5693\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43CF3C321B\n\tfor ;\n\tTue, 22 Jun 2021 04:06:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EF8D68939;\n\tTue, 22 Jun 2021 06:06:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0328768931\n\tfor ;\n\tTue, 22 Jun 2021 06:06:47 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95615A15;\n\tTue, 22 Jun 2021 06:06:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sWh2XFJP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624334806;\n\tbh=hnl0QvSy5NxIchb5nTzVdNq9Z1VB9BtSQhx3uuTIn2o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sWh2XFJPibhvPm0GCoBzbxJ9saflT508DVZj9bgnsDgXx98V53/i9T9FE2FbedEze\n\tDSzS2CZKMs9DIEixPJNqGi8IcRnvNnIiLwNWVZnKESV3ykfu/jYNjp16GhWFeP/P1Q\n\tyHnbR8fpm9V9yXWneuZqmZblSbVE5JJUpbDXqbz0=","Date":"Tue, 22 Jun 2021 13:06:39 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210622040639.GD1899306@pyrite.rasen.tech>","References":"<20210621200426.533327-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210621200426.533327-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v4] libcamera: Add OV5647 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]