[{"id":17866,"web_url":"https://patchwork.libcamera.org/comment/17866/","msgid":"","date":"2021-06-28T06:10:57","subject":"Re: [libcamera-devel] [PATCH v3 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Jun 18, 2021 at 11:04:29PM +0100, David Plowman wrote:\n> Warnings about the lack of AWB status results are demoted to being\n> just \"Debug\". With monochrome sensors becoming more common this would\n> otherwise overwhelm the console output, and in practice nothing is\n> really lost as it is normally very evident if AWB is failing to run.\n> \n> Signed-off-by: David Plowman \n> Reviewed-by: Naushir Patuck \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 55e80ac7..2c95f287 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n> \tawb_.gain_g = 1.0;\n> \tawb_.gain_b = 1.0;\n> \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n> -\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n> +\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n> }\n> \n> static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index b0d24aa2..ef99c1b0 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct)\n> \tAwbStatus awb_status;\n> \tawb_status.temperature_K = default_ct; // in case nothing found\n> \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n> -\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n> -\t\t\t\t << awb_status.temperature_K;\n> +\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n> +\t\t\t\t << awb_status.temperature_K;\n> \telse\n> \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n> \t\t\t\t << awb_status.temperature_K;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB208C321A\n\tfor ;\n\tMon, 28 Jun 2021 06:11:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 594AA684D5;\n\tMon, 28 Jun 2021 08:11:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D59E6028C\n\tfor ;\n\tMon, 28 Jun 2021 08:10:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00894B8A;\n\tMon, 28 Jun 2021 08:10:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H878MIHu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624860659;\n\tbh=6R6tg9/ScBug3g2mvcaGdNIx4+Pgq41t5vm8Dn9fCjQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H878MIHukgMPKCyHsVaZf08N/jDnMJAi/ILCY6PRKAqTatx/fD1KIYGZ/oyMSSjKY\n\tGCaqNfQEl2Y/A2Qa2D/wBAaAAUn6zVtixktQV/YLyY13+H4pG88CvpBfGd8Gw1C8eq\n\tZsJdBAxMcMNcurEz99ov4PiuN7BUj76lWiaV9uKM=","Date":"Mon, 28 Jun 2021 09:10:57 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210618220430.31457-1-david.plowman@raspberrypi.com>\n\t<20210618220430.31457-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618220430.31457-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]