[{"id":17735,"web_url":"https://patchwork.libcamera.org/comment/17735/","msgid":"","date":"2021-06-23T20:36:12","subject":"Re: [libcamera-devel] [PATCH v6] gstreamer: Added virtual functions\n\tneeded to support request pads","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le samedi 19 juin 2021 à 00:02 +0530, Vedant Paranjape a écrit :\n> This patch adds support for using request pads in libcamerasrc Gst\n> Element. It allows a user to request multiple streams if the platform\n> supports multistream output using libcamera.\n> \n> This was tested on Raspberry Pi 4B+ with a camera connected to CSI port.\n> It can be tested by running the following command\n> \n> gst-launch-1.0 libcamerasrc camera-name=\"\" name=src src.src ! queue ! videoconvert ! autovideosink src.src_0 ! queue ! videoconvert ! autovideosink\n> \n> Signed-off-by: Vedant Paranjape \n\nReviewed-by: Nicolas Dufresne \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 53 ++++++++++++++++++++++++++++++-\n> 1 file changed, 52 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index ccc61590..ea53c2b5 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -361,10 +361,12 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n> \n> \tguint group_id = gst_util_group_id_next();\n> +\tgint stream_id_num = 0;\n> \tStreamRoles roles;\n> \tfor (GstPad *srcpad : state->srcpads_) {\n> \t\t/* Create stream-id and push stream-start. */\n> -\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n> +\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n> +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n> \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n> \t\tgst_event_set_group_id(event, group_id);\n> \t\tgst_pad_push_event(srcpad, event);\n> @@ -640,6 +642,53 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> \tself->state = state;\n> }\n> \n> +static GstPad *\n> +gst_libcamera_src_request_new_pad(GstElement *element, GstPadTemplate *templ,\n> +\t\t\t\t const gchar *name, [[maybe_unused]] const GstCaps *caps)\n> +{\n> +\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n> +\tg_autoptr(GstPad) pad = NULL;\n> +\n> +\tGST_DEBUG_OBJECT(self, \"new request pad created\");\n> +\n> +\tpad = gst_pad_new_from_template(templ, name);\n> +\tg_object_ref_sink(pad);\n> +\n> +\tif (gst_element_add_pad(element, pad)) {\n> +\t\tGLibLocker lock(GST_OBJECT(self));\n> +\t\tself->state->srcpads_.push_back(reinterpret_cast(g_object_ref(pad)));\n> +\t} else {\n> +\t\tGST_ELEMENT_ERROR(element, STREAM, FAILED,\n> +\t\t\t\t (\"Internal data stream error.\"),\n> +\t\t\t\t (\"Could not add pad to element\"));\n> +\t\treturn NULL;\n> +\t}\n> +\n> +\treturn reinterpret_cast(g_steal_pointer(&pad));\n> +}\n> +\n> +static void\n> +gst_libcamera_src_release_pad(GstElement *element, GstPad *pad)\n> +{\n> +\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n> +\n> +\tGST_DEBUG_OBJECT(self, \"Pad %\" GST_PTR_FORMAT \" being released\", pad);\n> +\n> +\t{\n> +\t\tGLibLocker lock(GST_OBJECT(self));\n> +\t\tstd::vector &pads = self->state->srcpads_;\n> +\t\tauto begin_iterator = pads.begin();\n> +\t\tauto end_iterator = pads.end();\n> +\t\tauto pad_iterator = std::find(begin_iterator, end_iterator, pad);\n> +\n> +\t\tif (pad_iterator != end_iterator) {\n> +\t\t\tg_object_unref(*pad_iterator);\n> +\t\t\tpads.erase(pad_iterator);\n> +\t\t}\n> +\t}\n> +\tgst_element_remove_pad(element, pad);\n> +}\n> +\n> static void\n> gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> {\n> @@ -650,6 +699,8 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> \tobject_class->get_property = gst_libcamera_src_get_property;\n> \tobject_class->finalize = gst_libcamera_src_finalize;\n> \n> +\telement_class->request_new_pad = gst_libcamera_src_request_new_pad;\n> +\telement_class->release_pad = gst_libcamera_src_release_pad;\n> \telement_class->change_state = gst_libcamera_src_change_state;\n> \n> \tgst_element_class_set_metadata(element_class,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F226C321A\n\tfor ;\n\tWed, 23 Jun 2021 20:36:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 746DC68937;\n\tWed, 23 Jun 2021 22:36:16 +0200 (CEST)","from mail-qt1-x832.google.com (mail-qt1-x832.google.com\n\t[IPv6:2607:f8b0:4864:20::832])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 424FF68932\n\tfor ;\n\tWed, 23 Jun 2021 22:36:15 +0200 (CEST)","by mail-qt1-x832.google.com with SMTP id g14so3160660qtv.4\n\tfor ;\n\tWed, 23 Jun 2021 13:36:15 -0700 (PDT)","from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net.\n\t[173.246.12.168]) by smtp.gmail.com with ESMTPSA id\n\te10sm717807qkg.18.2021.06.23.13.36.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 23 Jun 2021 13:36:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com\n\theader.b=\"mmvo5uuC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=XjRCpkGzmFOyQIUUzTK7bmSDTM6jSPBA6Ne1jW3hEZk=;\n\tb=mmvo5uuC7SUfih/mVW8sXeUEpTC+1lTO7A05pZtYglSYetxpgL0gCuvBMQ9jc3mW4p\n\tZlKabXdVcFeYrM+QtczNlWZRFKs2nLMxhcFaWh/7pEqEuKpErj2dyR21Mdi3sjJznYCS\n\tZmNHWkeYJwISvl91BPAKXVQYCFjYTHBjeF2zaK0O9n/k+brHozvIkH5kvHaYm2HW6KPi\n\tSM4lmCxd5DSp1Aa6xBX9gnVO4lZpcUc1n9MU19VsWdQAm+mCt4rKh6EVCx7JKmQ4aDEX\n\t1+DeeNd2E/nCdIWWcvhzMdgJFoKy79f3t8lmiC34HbgmViimfxHDNNoWWQ8ld8zesLqK\n\tQ7Ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=XjRCpkGzmFOyQIUUzTK7bmSDTM6jSPBA6Ne1jW3hEZk=;\n\tb=I4YH1TF3W6Gwd9Nj64306KHC3MTWm+ii546Qq5aoKQmHR7oqift0jsamOZmCLUiUDj\n\tnI7dBJDTHHzzlWxPEL/bO3kyYKwBeRmk3GI4DkXlldIN+30iTFDdlFzU6AtYGpfWtqjU\n\tgP0INysUPBNZvZ5HsqniuNrLRFfSeb2jQayua53lStmNzqmoHtkxsypTG1PmMweLfj9c\n\tQFGdJpw2pfa/PFNK/NON8AeI/OBBe63PIRfSaTOd9vsrRKNxZSL7wyoGWFNz0cBN+6iL\n\tjYajZvrAiP1zztW2yQcClHJaPp2QdzpF9VtUJLzX8OrNY0ZQF2VDEf2HhqxIu6ydahAI\n\tahEg==","X-Gm-Message-State":"AOAM531XyZfr5VAT5OJaFq3/xuc3KDt7jTtOxp2kwcSjiqCOmsSIgk+P\n\t7py6KTFrEzGR/WXd4XDkCbGwkQ==","X-Google-Smtp-Source":"ABdhPJxbuS1W60S4CQobiTYIzSjZQ8jv49hDnLMKwpzyi4bscIzUd2UlY/pZcGUD6rAgROlsd+UVZg==","X-Received":"by 2002:ac8:b02:: with SMTP id e2mr1631374qti.159.1624480574097; \n\tWed, 23 Jun 2021 13:36:14 -0700 (PDT)","Message-ID":"","From":"Nicolas Dufresne ","To":"Vedant Paranjape , \n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 23 Jun 2021 16:36:12 -0400","In-Reply-To":"<20210618183218.449146-1-vedantparanjape160201@gmail.com>","References":"<20210618183218.449146-1-vedantparanjape160201@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.40.1 (3.40.1-1.fc34) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v6] gstreamer: Added virtual functions\n\tneeded to support request pads","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17797,"web_url":"https://patchwork.libcamera.org/comment/17797/","msgid":"<20210625110149.GT2599@pyrite.rasen.tech>","date":"2021-06-25T11:01:49","subject":"Re: [libcamera-devel] [PATCH v6] gstreamer: Added virtual functions\n\tneeded to support request pads","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nOn Sat, Jun 19, 2021 at 12:02:18AM +0530, Vedant Paranjape wrote:\n> This patch adds support for using request pads in libcamerasrc Gst\n> Element. It allows a user to request multiple streams if the platform\n> supports multistream output using libcamera.\n> \n> This was tested on Raspberry Pi 4B+ with a camera connected to CSI port.\n> It can be tested by running the following command\n> \n> gst-launch-1.0 libcamerasrc camera-name=\"\" name=src src.src ! queue ! videoconvert ! autovideosink src.src_0 ! queue ! videoconvert ! autovideosink\n> \n> Signed-off-by: Vedant Paranjape \n\nReviewed-by: Paul Elder \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 53 ++++++++++++++++++++++++++++++-\n> 1 file changed, 52 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index ccc61590..ea53c2b5 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -361,10 +361,12 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n> \n> \tguint group_id = gst_util_group_id_next();\n> +\tgint stream_id_num = 0;\n> \tStreamRoles roles;\n> \tfor (GstPad *srcpad : state->srcpads_) {\n> \t\t/* Create stream-id and push stream-start. */\n> -\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n> +\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n> +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n> \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n> \t\tgst_event_set_group_id(event, group_id);\n> \t\tgst_pad_push_event(srcpad, event);\n> @@ -640,6 +642,53 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> \tself->state = state;\n> }\n> \n> +static GstPad *\n> +gst_libcamera_src_request_new_pad(GstElement *element, GstPadTemplate *templ,\n> +\t\t\t\t const gchar *name, [[maybe_unused]] const GstCaps *caps)\n> +{\n> +\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n> +\tg_autoptr(GstPad) pad = NULL;\n> +\n> +\tGST_DEBUG_OBJECT(self, \"new request pad created\");\n> +\n> +\tpad = gst_pad_new_from_template(templ, name);\n> +\tg_object_ref_sink(pad);\n> +\n> +\tif (gst_element_add_pad(element, pad)) {\n> +\t\tGLibLocker lock(GST_OBJECT(self));\n> +\t\tself->state->srcpads_.push_back(reinterpret_cast(g_object_ref(pad)));\n> +\t} else {\n> +\t\tGST_ELEMENT_ERROR(element, STREAM, FAILED,\n> +\t\t\t\t (\"Internal data stream error.\"),\n> +\t\t\t\t (\"Could not add pad to element\"));\n> +\t\treturn NULL;\n> +\t}\n> +\n> +\treturn reinterpret_cast(g_steal_pointer(&pad));\n> +}\n> +\n> +static void\n> +gst_libcamera_src_release_pad(GstElement *element, GstPad *pad)\n> +{\n> +\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n> +\n> +\tGST_DEBUG_OBJECT(self, \"Pad %\" GST_PTR_FORMAT \" being released\", pad);\n> +\n> +\t{\n> +\t\tGLibLocker lock(GST_OBJECT(self));\n> +\t\tstd::vector &pads = self->state->srcpads_;\n> +\t\tauto begin_iterator = pads.begin();\n> +\t\tauto end_iterator = pads.end();\n> +\t\tauto pad_iterator = std::find(begin_iterator, end_iterator, pad);\n> +\n> +\t\tif (pad_iterator != end_iterator) {\n> +\t\t\tg_object_unref(*pad_iterator);\n> +\t\t\tpads.erase(pad_iterator);\n> +\t\t}\n> +\t}\n> +\tgst_element_remove_pad(element, pad);\n> +}\n> +\n> static void\n> gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> {\n> @@ -650,6 +699,8 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> \tobject_class->get_property = gst_libcamera_src_get_property;\n> \tobject_class->finalize = gst_libcamera_src_finalize;\n> \n> +\telement_class->request_new_pad = gst_libcamera_src_request_new_pad;\n> +\telement_class->release_pad = gst_libcamera_src_release_pad;\n> \telement_class->change_state = gst_libcamera_src_change_state;\n> \n> \tgst_element_class_set_metadata(element_class,\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16F23C321A\n\tfor ;\n\tFri, 25 Jun 2021 11:01:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8AD60684CC;\n\tFri, 25 Jun 2021 13:01:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F0DB684C9\n\tfor ;\n\tFri, 25 Jun 2021 13:01:57 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B271501;\n\tFri, 25 Jun 2021 13:01:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hfZXc3oJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624618917;\n\tbh=5DxTf1b7KjGq/J3Vxq1Ab9Ebyj/2jumwznMG1sFN1s8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hfZXc3oJvLF+0HbBOlEbWpOgmEmFnrnfXzqJQFI2PVwU8fBbUwAZpsnvXESy46lIV\n\tuaJc6Dgys9qEew5NjlP9OtrjDOm6pcgy3teJHxhzh01NN/VRcAtsgjFdhMtop4GOls\n\toNETM0qfTBLR7g5yvQ0U+QBP5ACC2K1t4pnTfJIQ=","Date":"Fri, 25 Jun 2021 20:01:49 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210625110149.GT2599@pyrite.rasen.tech>","References":"<20210618183218.449146-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210618183218.449146-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v6] gstreamer: Added virtual functions\n\tneeded to support request pads","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]